mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-27 09:11:53 -05:00
a43ea22479
Co-author: @wxiaoguang Close #25096 The way to fix it in this PR is to change form submit to fetch using formData, and add flags to avoid post repeatedly. Should be able to apply to more forms that have the same issue after this PR. In the demo below, 'approve' is clicked several times, and then 'comment' is clicked several time after 'request changes' clicked. After: https://github.com/go-gitea/gitea/assets/17645053/beabeb1d-fe66-4b76-b048-4f022b4e83a0 Update: screenshots from /devtest > ![image](https://user-images.githubusercontent.com/2114189/245680011-ee4231e0-a53d-4c2a-a9c2-71ccd98005cc.png) > > ![image](https://user-images.githubusercontent.com/2114189/245680057-9215d348-63d8-406d-8828-17e171163aaa.png) > > ![image](https://user-images.githubusercontent.com/2114189/245680148-89d7b3d1-d7b6-442f-b69e-eadaee112482.png) --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
24 lines
927 B
JavaScript
24 lines
927 B
JavaScript
import $ from 'jquery';
|
|
|
|
export function handleGlobalEnterQuickSubmit(target) {
|
|
const form = target.closest('form');
|
|
if (form) {
|
|
if (!form.checkValidity()) {
|
|
form.reportValidity();
|
|
return;
|
|
}
|
|
|
|
if (form.classList.contains('form-fetch-action')) {
|
|
form.dispatchEvent(new SubmitEvent('submit', {bubbles: true, cancelable: true}));
|
|
return;
|
|
}
|
|
|
|
// here use the event to trigger the submit event (instead of calling `submit()` method directly)
|
|
// otherwise the `areYouSure` handler won't be executed, then there will be an annoying "confirm to leave" dialog
|
|
$(form).trigger('submit');
|
|
} else {
|
|
// if no form, then the editor is for an AJAX request, dispatch an event to the target, let the target's event handler to do the AJAX request.
|
|
// the 'ce-' prefix means this is a CustomEvent
|
|
target.dispatchEvent(new CustomEvent('ce-quick-submit', {bubbles: true}));
|
|
}
|
|
}
|