1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-29 09:31:11 -05:00
forgejo/models/migrations
mrsdizzie 8d99ee2773
Add Organization Wide Labels (#10814)
* Add organization wide labels

Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).

This makes it possible for small organizations with many repos to use
labels effectively.

Fixes #7406

* Add migration

* remove comments

* fix tests

* Update options/locale/locale_en-US.ini

Removed unused translation string

* show org labels in issue search label filter

* Use more clear var name

* rename migration after merge from master

* comment typo

* update migration again after rebase with master

* check for orgID <=0 per guillep2k review

* fmt

* Apply suggestions from code review

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* remove unused code

* Make sure RepoID is 0 when searching orgID per code review

* more changes/code review requests

* More descriptive translation var per code review

* func description/delete comment when issue label deleted instead of hiding it

* remove comment

* only use issues in that repo when calculating number of open issues for org label on repo label page

* Add integration test for IssuesSearch API with labels

* remove unused function

* Update models/issue_label.go

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* Use subquery in GetLabelIDsInReposByNames

* Fix tests to use correct orgID

* fix more tests

* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well

* update comment for clarity

* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition

* Don't sort repos by date in IssuesSearch API

After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45

Returns different results for MySQL than other engines. However, the similar query:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30

Returns the same results.

This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.

* linter is back!

* code review

* remove now unused option

* Fix newline at end of files

* more unused code

* update to master

* check for matching ids before query

* Update models/issue_label.go

Co-Authored-By: 6543 <6543@obermui.de>

* Update models/issue_label.go

* update comments

* Update routers/org/setting.go

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 01:14:46 -03:00
..
migrations.go Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
v70.go Remove migration support from versions earlier than 1.6.0 (#10026) 2020-01-31 21:42:45 +08:00
v71.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v72.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v73.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v74.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v75.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v76.go Remove migration support from versions earlier than 1.6.0 (#10026) 2020-01-31 21:42:45 +08:00
v77.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v78.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v79.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v80.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v81.go Upgrade xorm to v1.0.0 (#10646) 2020-03-22 11:12:55 -04:00
v82.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
v83.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v84.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v85.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v86.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v87.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v88.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v89.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v90.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v91.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v92.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v93.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v94.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v95.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v96.go Fix migration bug on v96.go (#10572) 2020-03-02 12:53:39 -03:00
v97.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v98.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v99.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v100.go Upgrade xorm to v0.8.0 (#8536) 2019-10-17 11:26:49 +02:00
v101.go Allow more than 255 characters for tokens in external_login_user table (#8554) 2019-10-18 09:58:36 +03:00
v102.go Fix bug on pull requests when transfer head repository (#8564) 2019-10-18 19:13:31 +08:00
v103.go Allow Protected Branches to Whitelist Deploy Keys (#8483) 2019-10-21 09:21:45 +01:00
v104.go Fix extra columns from label table (#8633) 2019-10-23 14:48:32 +03:00
v105.go Add team option to grant rights for all organization repositories (#8688) 2019-11-06 11:37:14 +02:00
v106.go Auto-subscribe user to repository when they commit/tag to it (#7657) 2019-11-10 09:22:19 +00:00
v107.go Template Repositories (#8768) 2019-11-11 23:15:29 +08:00
v108.go Improve notification (#8835) 2019-11-12 16:33:34 +08:00
v109.go Team permission to create repository in organization (#8312) 2019-11-20 19:27:49 +08:00
v110.go Upgrade xorm to v1.0.0 (#10646) 2020-03-22 11:12:55 -04:00
v111.go Issue with Migration rule v111 (#9449) 2019-12-21 11:12:39 +01:00
v112.go fix wrong migration (#9381) 2019-12-17 14:58:30 +08:00
v113.go Change target branch for pull request (#6488) 2019-12-16 14:20:25 +08:00
v114.go Add migration to sanitize repository original_url (#9423) 2019-12-19 17:49:48 +08:00
v115.go Ignore empty avatars in v115.go (#9520) 2019-12-28 00:57:37 +02:00
v116.go [API] Extend times API (#9200) 2019-12-27 20:30:58 +00:00
v117.go Add branch protection option to block merge on requested changes. (#9592) 2020-01-03 19:47:09 +02:00
v118.go Mark PR reviews as stale at push and allow to dismiss stale approvals (#9532) 2020-01-09 01:47:45 +00:00
v119.go Fix wrong original git service type on a migrated repository (#9693) 2020-01-10 23:35:17 +08:00
v120.go Add owner_name column for table repository for maintaince reason (#9717) 2020-01-12 17:36:21 +08:00
v121.go Restricted users (#6274) 2020-01-13 18:33:46 +01:00
v122.go Add require signed commit for protected branch (#9708) 2020-01-15 09:32:57 +01:00
v123.go Migrate reactions when migrating repository from github (#9599) 2020-01-15 12:14:07 +01:00
v124.go Add missing columns to repository and user (#9861) 2020-01-19 22:27:44 +00:00
v125.go Migrate reviews when migrating repository from github (#9463) 2020-01-23 19:28:15 +02:00
v126.go Update topics repo count when deleting repository (#10051) 2020-01-31 08:57:19 +02:00
v127.go Language statistics bar for repositories (#8037) 2020-02-11 11:34:17 +02:00
v128.go Various Merge Base fixes (#10786) 2020-03-31 16:42:44 +03:00
v129.go Migration for deleting orphaned dependencies (#10617) 2020-03-05 16:54:50 +01:00
v130.go Fix migration (#10641) 2020-03-06 17:43:37 +02:00
v131.go System-wide webhooks (#10546) 2020-03-09 00:08:05 +02:00
v132.go Allow to set protected file patterns that can not be changed under no conditions (#10806) 2020-03-27 00:26:34 +02:00
v133.go make avatar lookup occur at image request (#10540) 2020-03-27 14:34:39 +02:00
v134.go Various Merge Base fixes (#10786) 2020-03-31 16:42:44 +03:00
v135.go Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00