mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-28 09:21:13 -05:00
138942c09e
- Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M)
34 lines
891 B
Go
34 lines
891 B
Go
// Copyright 2024 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v1_22 //nolint
|
|
|
|
import (
|
|
"testing"
|
|
|
|
migration_tests "code.gitea.io/gitea/models/migrations/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_RemoveSSHSignaturesFromReleaseNotes(t *testing.T) {
|
|
// A reduced mock of the `repo_model.Release` struct.
|
|
type Release struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
Note string `xorm:"TEXT"`
|
|
}
|
|
|
|
x, deferable := migration_tests.PrepareTestEnv(t, 0, new(Release))
|
|
defer deferable()
|
|
|
|
assert.NoError(t, RemoveSSHSignaturesFromReleaseNotes(x))
|
|
|
|
var releases []Release
|
|
err := x.Table("release").OrderBy("id ASC").Find(&releases)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, releases, 3)
|
|
|
|
assert.Equal(t, "", releases[0].Note)
|
|
assert.Equal(t, "A message.\n", releases[1].Note)
|
|
assert.Equal(t, "no signature present here", releases[2].Note)
|
|
}
|