1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-27 13:39:19 -05:00
forgejo/web_src/js/components
wxiaoguang 59d060622d
Improve RSS (#24335)
Follow  #22719

### Major changes

1. `ServerError` doesn't do format, so remove the `%s`
2. Simplify `RenderBranchFeed` (slightly)
3. Remove unused `BranchFeedRSS`
4. Make `feed.RenderBranchFeed` respect `EnableFeed` config
5. Make `RepoBranchTagSelector.vue` respect `EnableFeed` setting,
otherwise there is always RSS icon
6. The `(branchURLPrefix + item.url).replace('src', 'rss')` doesn't seem
right for all cases, for example, the string `src` could appear in
`branchURLPrefix`, so we need a separate `rssURLPrefix`
7. The `<a>` in Vue menu needs `@click.stop`, otherwise the menu itself
would be triggered at the same time
8. Change `<a><button></button></a>` to `<a role=button>`
9. Use `{{PathEscapeSegments .TreePath}}` instead of `{{range $i, $v :=
.TreeNames}}/{{$v}}{{end}}`


Screenshot of changed parts:

<details>


![image](https://user-images.githubusercontent.com/2114189/234315538-66603694-9093-48a8-af33-83575fd7a018.png)


![image](https://user-images.githubusercontent.com/2114189/234315786-f1efa60b-012e-490b-8ce2-d448dc6fe5c9.png)


![image](https://user-images.githubusercontent.com/2114189/234334941-446941bc-1baa-4256-8850-ccc439476cda.png)

</details>


### Other thoughts

Should we remove the RSS icon from the branch dropdown list? It seems
too complex for a list UI, and users already have the chance to get the
RSS feed URL from "branches" page.

---------

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
2023-04-25 22:53:44 -04:00
..
.eslintrc.yaml Update eslints for Vue 3 (#23935) 2023-04-05 16:59:40 -04:00
ActionRunStatus.vue Use same action status svg icons on actions list as on action page (#24178) 2023-04-19 13:42:53 +08:00
ActivityHeatmap.vue Localize activity heatmap (except tooltip) (#24131) 2023-04-17 14:26:01 -04:00
ContextPopup.vue Improve <SvgIcon> to make it output svg node and optimize performance (#23570) 2023-03-23 11:24:16 +08:00
DashboardRepoList.vue Automatically select the org when click create repo from org dashboard (#24325) 2023-04-25 22:25:29 -04:00
DiffFileList.vue Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
DiffFileTree.vue Update the value of the diffEnd when click Show More btn in the DiffFileTree (#24069) 2023-04-12 15:11:23 +02:00
DiffFileTreeItem.vue Use reactive store to share data between components (#23996) 2023-04-11 20:44:26 -04:00
PullRequestMergeForm.vue Refactor branch/tag selector to Vue SFC (#23421) 2023-03-14 17:51:20 +08:00
RepoActionView.test.js Improve action log display with control chars (#23820) 2023-04-01 20:57:05 +08:00
RepoActionView.vue Add job.duration in web ui (#23963) 2023-04-07 18:20:50 -04:00
RepoActivityTopAuthors.vue Refactor dashboard repo list to Vue SFC (#23405) 2023-03-14 12:09:06 +08:00
RepoBranchTagSelector.vue Improve RSS (#24335) 2023-04-25 22:53:44 -04:00