foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
Code Issues Packages 1 Wiki Activity

Add item to CONTRIBUTING.md about needing tests

Browse source 
This adds requiring tests covering the change as a pre-req before raising a PR.
This commit is contained in:
Kitson Kelly 2019-02-01 13:31:26 +10:00 committed by Ryan Dahl
parent eff7a1484e
commit 81372e8267
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
.github/CONTRIBUTING.md vendored
View file

@ -17,9 +17,10 @@ Docs are [here](https://github.com/denoland/deno/blob/master/Docs.md).
Before submitting, please make sure the following is done:
1. Ensure `./tools/test.py` passes.
2. Format your code with `./tools/format.ts`.
3. Make sure `./tools/lint.py` passes.
1. There are tests that cover the changes.
2. Ensure `./tools/test.py` passes.
3. Format your code with `./tools/format.ts`.
4. Make sure `./tools/lint.py` passes.
## Changes to `third_party`