foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-24 15:19:26 -05:00
Code Issues Packages 1 Wiki Activity

fix(install): percent encodings in interactive progress bar (#26600)

Browse source 
Fixes percent encodings showing up when installing scoped packages via
`deno add` or `deno install`. The issue is caused by us trying to map
back the package name from the resolved http url. This doesn't and has
never worked with private registries. The proper solution would be to
pass the original specifier into here, but that's a bit of a bigger
refactor.

So for now the quickest workaround is to replace `%2f` back to `/`.

Fixes https://github.com/denoland/deno/issues/26576
This commit is contained in:
Marvin Hagemeister 2024-10-30 00:35:42 +01:00 committed by GitHub
parent 3b28446000
commit c8d229dbf0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
cli/util/progress_bar/renderer.rs
View file

@ -193,10 +193,16 @@ impl ProgressBarRenderer for TextOnlyProgressBarRenderer {
} }
}; };
// TODO(@marvinhagemeister): We're trying to reconstruct the original
// specifier from the resolved one, but we lack the information about
// private registries URLs and other things here.
let message = display_entry let message = display_entry
.message .message
.replace("https://registry.npmjs.org/", "npm:") .replace("https://registry.npmjs.org/", "npm:")
.replace("https://jsr.io/", "jsr:"); .replace("https://jsr.io/", "jsr:")
.replace("%2f", "/")
.replace("%2F", "/");
display_str.push_str( display_str.push_str(
&colors::gray(format!(" - {}{}\n", message, bytes_text)).to_string(), &colors::gray(format!(" - {}{}\n", message, bytes_text)).to_string(),
); );