foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
Code Issues Packages 1 Wiki Activity

test: disable flaky Node test (#18821)

Browse source 
If we hit a slow runner this test almost always fails.
This commit is contained in:
Bartek Iwańczuk 2023-04-24 15:55:06 +02:00 committed by GitHub
parent 652694f15d
commit ebfc75fe8c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 52 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cli/tests/node_compat/config.jsonc
View file

@ -32,7 +32,8 @@
"test-child-process-exec-std-encoding.js",
// TODO(bartlomieju): this test was flaky on macOS CI
// "test-child-process-exec-timeout-expire.js",
"test-child-process-exec-timeout-kill.js",
// TODO(bartlomieju): this test was flaky on macOS CI
// "test-child-process-exec-timeout-kill.js",
"test-child-process-exec-timeout-not-expired.js",
"test-child-process-execFile-promisified-abortController.js",
"test-child-process-execfile.js",
@ -212,7 +213,8 @@
"test-child-process-exec-stdout-stderr-data-string.js",
// TODO(bartlomieju): this test was flaky on macOS CI
// "test-child-process-exec-timeout-expire.js",
"test-child-process-exec-timeout-kill.js",
// TODO(bartlomieju): this test was flaky on macOS CI
// "test-child-process-exec-timeout-kill.js",
// TODO(bartlomieju): this test was flaky on macOS CI
// "test-child-process-execFile-promisified-abortController.js",
"test-child-process-execfile-maxbuf.js",

50
cli/tests/node_compat/test/parallel/test-child-process-exec-timeout-kill.js
View file

@ -1,50 +0,0 @@
// deno-fmt-ignore-file
// deno-lint-ignore-file
// Copyright Joyent and Node contributors. All rights reserved. MIT license.
// Taken from Node 18.12.1
// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
// TODO(PolarETech): The process.argv[3] check should be argv[2], and the
// command passed to exec() should not need to include "run", "-A",
// and "require.ts".
'use strict';
// Test exec() with both a timeout and a killSignal.
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const {
cleanupStaleProcess,
logInTimeout,
kExpiringChildRunTime,
kExpiringParentTimer,
} = require('../common/child_process');
if (process.argv[3] === 'child') {
logInTimeout(kExpiringChildRunTime);
return;
}
const cmd = `"${process.execPath}" run -A require.ts "${__filename}" child`;
// Test with a different kill signal.
cp.exec(cmd, {
timeout: kExpiringParentTimer,
killSignal: 'SIGKILL'
}, common.mustCall((err, stdout, stderr) => {
console.log('[stdout]', stdout.trim());
console.log('[stderr]', stderr.trim());
assert.strictEqual(err.killed, true);
assert.strictEqual(err.code, null);
assert.strictEqual(err.signal, 'SIGKILL');
assert.strictEqual(err.cmd, cmd);
assert.strictEqual(stdout.trim(), '');
assert.strictEqual(stderr.trim(), '');
}));
cleanupStaleProcess(__filename);