This commit fixes a bug introduced in #5029 that caused bad
handling of redirects during module analysis.
Also ensured that duplicate modules are not downloaded.
This adds [Node's `util.callbackify`][0] to `std/node/util.ts`.
I lifted most of this from the [original Node source code][1] (and [its
tests][2]). I tried to make minimal modifications to the source.
I made a few arbitrary decisions:
- I was unable to do the function's types elegantly. I made overloads
for functions that have 0 to 5 (inclusive) arguments, excluding the
callback. I would love to know a better way to do this. (It seems that
the folks at DefinitelyTyped [were also stumped][3], though maybe
their solution is deliberate.)
- There are a few edge cases that cause custom Node errors to be
produced. Instead of re-implementing those errors completely, I
created simplified classes. These are mostly correct but are not
identical to the real Node errors.
- The tests implement a possibly-arcane `TestQueue` class. I originally
used a lot of inline promises but found it too repetitive.
Closes [#5366][4].
[0]: https://nodejs.org/api/util.html#util_util_callbackify_original
[1]: 4780493301/lib/util.js (L183-L226)
[2]: 4780493301/test/parallel/test-util-callbackify.js
[3]: 7d24857ddb/types/node/util.d.ts (L61-L84)
[4]: https://github.com/denoland/deno/issues/5366
This commit disabled flaky test in cli/module_graph.rs.
The test uses 019_media_types.ts which was known to be flaky
for some time. Test should be reenabled once test HTTP server
is rewritten to Rust.
This commit completely overhauls how module analysis is
performed in TS compiler by moving the logic to Rust.
In the current setup module analysis is performed using
"ts.preProcessFile" API in a special TS compiler worker
running on a separate thread.
"ts.preProcessFile" allowed us to build a lot of functionality
in CLI including X-TypeScript-Types header support
and @deno-types directive support. Unfortunately at the
same time complexity of the ops required to perform
supporting tasks exploded and caused some hidden
permission escapes.
This PR introduces "ModuleGraphLoader" which can parse
source and load recursively all dependent source files; as
well as declaration files. All dependencies used in TS
compiler and now fetched and collected upfront in Rust
before spinning up TS compiler.
To achieve feature parity with existing APIs this commit
includes a lot of changes:
* add "ModuleGraphLoader"
- can fetch local and remote sources
- parses source code using SWC and extracts imports, exports, file references, special
headers
- this struct inherited all of the hidden complexity and cruft from TS version and requires
several follow up PRs
* rewrite cli/tsc.rs to perform module analysis upfront and send all required source code to
TS worker in one message
* remove op_resolve_modules and op_fetch_source_files from cli/ops/compiler.rs
* run TS worker on the same thread
