Kenta Moriuchi
fb1d33a711
chore: update dlint to v0.68.0 for internal ( #26711 )
2024-11-04 12:17:11 -05:00
Nathan Whitaker
951103fc8d
fix(ext/node): convert errors from fs.readFile/fs.readFileSync to node format ( #26632 )
...
Fixes the original issue reported in #26404 . storybook runs into other
errors after this PR (the new errors will be fixed in other PRs).
Some code used by a dependency of storybook does a [string comparison on
the error
message](ce30b2be34/node-src/lib/getConfiguration.ts (L88-L92)
2024-10-31 10:02:17 -07:00
familyboat
c314b2d857
fix(ext/node): add path to fs.stat and fs.statSync error ( #26037 )
2024-10-27 08:34:35 +05:30
Nathan Whitaker
1bccf45ecb
fix(ext/node): properly map reparse point error in readlink ( #26375 )
2024-10-18 10:11:06 -07:00
Nathan Whitaker
9fde5cb5e0
fix(node/fs): copyFile with COPYFILE_EXCL should not throw if the destination doesn't exist ( #26360 )
...
Fixes #26313 .
We were checking for the NotFound error, but still calling the callback
with the error / throwing.
2024-10-17 19:51:15 +00:00
Satya Rohith
ff4e682ff9
fix(ext/node): internal buffer length in readSync ( #26064 )
...
Closes https://github.com/denoland/deno/issues/26054
2024-10-08 10:41:32 +00:00
David Sherret
3dd83fdbdb
Revert "feat(fmt): sort type-only named import/exports last" ( #25705 )
...
Reverts #25690
This was not an issue with the ts compiler anymore. Discussion here:
https://github.com/dprint/dprint-plugin-typescript/pull/664#issuecomment-2357000053
2024-09-18 13:54:52 +00:00
David Sherret
a14e9f55b4
feat(fmt): sort type-only named import/exports last ( #25690 )
...
Closes #22583
2024-09-17 18:26:23 +01:00
Yoshiya Hinosawa
8bdd364dd5
fix(ext/node): add FileHandle#writeFile ( #25555 )
...
This PR adds `writeFile` methods of `FileHandle` class
https://nodejs.org/api/fs.html#filehandlewritefiledata-options
2024-09-11 11:08:40 +02:00
Nathan Whitaker
1521adf5ed
fix(ext/node): Add missing node:fs and node:constants exports ( #25568 )
...
Just a bunch of random fs constants
2024-09-11 00:37:23 +00:00
Asher Gomez
c73b4a0877
BREAKING(fs): remove Deno.seek[Sync]() ( #25449 )
...
Towards #22079
2024-09-05 20:37:28 +10:00
Nathan Whitaker
ff4226a3cd
fix(node/fs): Use correct offset and length in node:fs.read and write ( #25049 )
...
My fix in #25030 was buggy, I forgot to pass the `byteOffset` and
`byteLength`. Whoops.
I also discovered that fs.read was not respecting the `offset` argument,
and we were constructing a new `Buffer` for the callback instead of just
passing the original one (which is what node does, and the @types/node
definitions also indicate the callback should get the same type).
Fixes #25028 .
2024-08-16 09:48:57 -07:00
Nathan Whitaker
1f2d48cd97
fix(node/fs): node:fs.read and write should accept typed arrays other than Uint8Array ( #25030 )
...
Part of #25028 .
Our underlying read/write operations in `io` assume the buffer is a
Uint8Array, but we were passing in other typed arrays (in the case above
it was `Int8Array`).
2024-08-14 09:42:31 -07:00
Kenta Moriuchi
76f4f202e7
chore: update the copyright of c, mjs, and jsx ( #25005 )
2024-08-12 12:41:32 -04:00
Marvin Hagemeister
9d6da1036d
fix: rename watch event missing ( #24893 )
...
This PR ensures that we forward a `rename` event in our file watcher.
The rust lib we use combines that with the `modify` event.
This fixes a compatibility issue with Node too, which sends the `rename`
event as well.
Fixes https://github.com/denoland/deno/issues/24880
2024-08-07 18:15:57 +02:00
Marvin Hagemeister
9e6288ec61
fix(node/fs/promises): watch should be async iterable ( #24805 )
...
The way `fs.watch` works is different in `node:fs/promises` than
`node:fs`. It has a different function signature and it returns an async
iterable instead, see
https://nodejs.org/api/fs.html#fspromiseswatchfilename-options
Fixes https://github.com/denoland/deno/issues/24661
2024-07-31 13:07:49 +02:00
Divy Srivastava
078def0ff8
perf(ext/node): optimize fs.exists[Sync] ( #24613 )
...
Use `access` on *nix and `GetFileAttributesW` on Windows.
[Benchmark](https://paste.divy.work/p/-gq8Ark.js ):
```
$ deno run -A bench.mjs # main (568dd)
existsSync: 8980.636629ms
$ target/release/deno run -A bench.mjs # this PR
existsSync: 6448.7604519999995ms
$ bun bench.mjs
existsSync: 6562.88671ms
$ node bench.mjs
existsSync: 7740.064653ms
```
Ref https://github.com/denoland/deno/pull/24434#discussion_r1679777912
2024-07-17 18:05:51 +05:30
Nathan Whitaker
d4d3a3c54f
fix(node): Implement fs.lchown (and process.getegid) ( #24418 )
...
Closes https://github.com/denoland/deno/issues/21260 .
Part of https://github.com/denoland/deno/issues/18218 .
Implements `node:fs.lchown`, and enables the node_compat test for it.
The test uses `process.getegid`, which we didn't have implemented, so I
went ahead and implemented that as well to get the test working.
2024-07-05 18:32:51 +00:00
David Sherret
d91215d418
fix: revert accidentally added parentPath on DirEntry ( #24438 )
...
Reverts the accidentally added `.parentPath` on dir entries in
https://github.com/denoland/deno/pull/24257/files
This should not have been added to the public api and is not documented.
2024-07-04 20:58:30 -04:00
Nathan Whitaker
dadc606419
fix(ext/node): Add fs.lutimes / fs.lutimesSync ( #23172 )
...
Part of #18218
- Adds `fs.lutimes` and `fs.lutimesSync` to our node polyfills. To do
this I added methods to the `FileSystem` trait + ops to expose the
functionality to JS.
- Exports `fs._toUnixTimestamp`. Node exposes an internal util
`toUnixTimestamp` from the fs module to be used by unit tests (so we
need it for the unit test to pass unmodified). It's weird because it's
only supposed to be used internally but it's still publicly accessible
- Matches up error handling and timestamp handling for fs.futimes and
fs.utimes with node
- Enables the node_compat utimes test - this exercises futimes, lutimes,
and utimes.
2024-07-02 19:33:32 -07:00
Asher Gomez
ff53506107
fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_dir.ts ( #24319 )
...
Towards #24236
---------
Signed-off-by: Asher Gomez <ashersaupingomez@gmail.com>
Co-authored-by: Satya Rohith <me@satyarohith.com>
2024-06-24 06:22:55 +00:00
Asher Gomez
0833a1617c
fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_cp.js ( #24320 )
...
Towards #24236
2024-06-24 16:17:26 +10:00
Divy Srivastava
209b286813
fix(ext/node): Add Dirent.path and Dirent.parentPath ( #24257 )
2024-06-19 12:51:01 +05:30
Bartek Iwańczuk
6a356aff13
chore: sync up Node.js test files for v20.11.1 ( #24066 )
...
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
2024-06-11 11:41:44 +00:00
Marvin Hagemeister
a0ddf73058
fix(ext/node): add throwIfNoEntry option in fs.lstatSync ( #24006 )
...
We didn't support the `throwIfNoEntry` option for Node's `fs.lstatSync`
method. Note that the async variant doesn't have this option.
Fixes https://github.com/denoland/deno/issues/23996
2024-05-28 12:24:54 +02:00
Nathan Whitaker
7ad76fd453
fix(ext/node): Add fs.readv, fs.readvSync ( #23166 )
...
Part of #18218 .
Implements `fs.readv` and `fs.readvSync` and enables the corresponding
`node_compat` tests.
2024-04-01 20:42:49 -07:00
Divy Srivastava
5b2f689f08
fix(ext/node): FsWatcher ref and unref ( #22987 )
...
Fixes https://github.com/denoland/deno/issues/22973
---------
Co-authored-by: Satya Rohith <me@satyarohith.com>
2024-03-20 11:19:53 +05:30
Divy Srivastava
9c5ddf7c69
fix(ext/node): pass normalized watchFile handler to StatWatcher ( #22940 )
...
Fixes https://github.com/denoland/deno/issues/22939
2024-03-16 09:44:47 +05:30
Nayeem Rahman
f377fce640
feat(node): implement fs.statfs() ( #22862 )
2024-03-13 10:57:59 +00:00
Divy Srivastava
0bed4d3e51
fix(ext/node): support junction symlinks on Windows ( #22762 )
...
Fixes https://github.com/denoland/deno/issues/20609
Vitepress support! `vitepress dev` and `vitepress build` via BYONM
2024-03-09 09:07:29 +05:30
Divy Srivastava
39d9281bb9
fix(ext/node): add default methods to fs.StatsBase ( #22750 )
2024-03-06 23:01:20 +01:00
Divy Srivastava
6ba0b7952d
fix(node): stat/statSync returns instance of fs.Stats ( #22294 )
...
Fixes https://github.com/denoland/deno/issues/22291
---------
Signed-off-by: Divy Srivastava <dj.srivastava23@gmail.com>
2024-03-06 13:59:10 +01:00
Bartek Iwańczuk
909986fa6e
refactor: migrate 'ext/node' extension to virtual ops module ( #22157 )
...
Follow up to https://github.com/denoland/deno/pull/22135
2024-01-29 14:58:08 +01:00
Bartek Iwańczuk
942fb5e038
chore: upgrade deno_core ( #22124 )
...
Co-authored-by: Matt Mastracci <matthew@mastracci.com>
2024-01-26 14:04:07 -05:00
Bartek Iwańczuk
9951506506
fix(node): remove deprecation warnings ( #22120 )
...
Closes https://github.com/denoland/deno/issues/22116
2024-01-26 00:36:03 +01:00
Bartek Iwańczuk
0b0fb94ce2
fix(fs): instanceof check for Deno.FsFile ( #22121 )
...
Regression caused by https://github.com/denoland/deno/pull/22072 .
I added a relevant test so we don't regress again.
Fixes https://github.com/denoland/deno/issues/22115
2024-01-25 23:51:29 +01:00
Bartek Iwańczuk
801ed74118
revert: Remove deprecations of file sync APIs ( #22085 )
...
- `Deno.FsFile.dataSync` -> `Deno.FsFile.syncData`
- `Deno.FsFile.dataSyncSync` -> `Deno.FsFile.syncDataSync`
Also marks these APIs as unstable
2024-01-24 23:38:18 +01:00
Asher Gomez
48c19d0bab
feat: deprecate Deno.fstat() and Deno.fstatSync() ( #22068 )
...
For removal in Deno v2.
2024-01-24 18:53:20 +01:00
Asher Gomez
f5097d9d3b
feat: Deno.FsFile.{utime,utimeSync}() and deprecate Deno.{futime,futimeSync} ( #22070 )
...
For removal in Deno v2.
---------
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
2024-01-24 17:26:49 +01:00
Asher Gomez
62786cfebb
feat: deprecate Deno.close() ( #22066 )
...
For removal in Deno v2.
---------
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
2024-01-24 15:59:55 +01:00
Asher Gomez
4af121687c
feat: deprecate Deno.ftruncate() and Deno.ftruncateSync() ( #22069 )
...
For removal in Deno 2.0.
2024-01-24 15:12:22 +01:00
Asher Gomez
aac0ad32bd
feat: deprecate Deno.FsFile constructor and Deno.FsFile.rid ( #22072 )
2024-01-24 13:36:35 +01:00
Asher Gomez
47620641e7
feat: FsFile.sync() and FsFile.syncSync() ( #22017 )
...
This change:
1. Implements `Deno.FsFile.sync()` and `Deno.FsFile.syncSync()`.
2. Deprecates `Deno.fsync()` and `Deno.fsyncSync()` for removal in Deno
v2, in favour of the above corresponding methods.
Related #21995
---------
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
2024-01-24 01:07:06 +01:00
Asher Gomez
2f47ec6c3a
feat: Deno.FsFile.dataSync() and Deno.FsFile.dataSyncSync() ( #22019 )
...
This change:
1. Implements `Deno.FsFile.dataSync()` and `Deno.FsFile.dataSyncSync()`.
2. Deprecates `Deno.fdatasync()` and `Deno.fdatasyncSync()` for removal
in Deno v2, in favour of the above corresponding methods.
3. Replaces use of `Deno.fdatasync()` and `Deno.fdatasyncSync()` with
the above instance methods.
Related #21995
2024-01-24 00:31:52 +01:00
Yoshiya Hinosawa
2af0c0a3c6
fix(ext/node): fix no arg call of fs.promises.readFile ( #22030 )
2024-01-23 12:59:39 +09:00
Kenta Moriuchi
515a34b4de
refactor: use core.ensureFastOps() ( #21888 )
2024-01-10 15:37:25 -07:00
Kenta Moriuchi
e7e25db24f
chore: update deno_lint for CI ( #21802 )
2024-01-05 15:03:06 +00:00
Divy Srivastava
611993fbe0
fix(ci): update copright year for _fs_cp.js ( #21803 )
2024-01-05 13:43:56 +00:00
Divy Srivastava
df062d2c78
fix(ext/node): add fs.cp, fs.cpSync, promises.cp ( #21745 )
...
Fixes https://github.com/denoland/deno/issues/20803
Fixes https://github.com/denoland/deno/issues/21723
Performance: copying a 48GiB rust `target` folder (recursive)
| Platform | `deno` | `node v21.5` | Improvement |
| -------- | ------- | ------- | ------- |
| macOS (APFS) | 3.1secs | 127.99 secs | **42x** |
| Windows | 18.3secs | 67.2secs | **3.8x** |
Copying files with varying sizes:
2024-01-05 18:28:33 +05:30
David Sherret
7e72f3af61
chore: update copyright to 2024 ( #21753 )
2024-01-01 19:58:21 +00:00
