1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-17 21:03:01 -05:00
denoland-deno/cli/tests/unit_node/fs_test.ts
Marvin Hagemeister 692738232b
fix(node/fs): promises not exporting fs constants (#21997)
<!--
Before submitting a PR, please read https://deno.com/manual/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't
run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench'
label.
-->

We were missing the `constants` export in the promise `fs` API which is
available in node.

```ts
import { constants, promises } from "node:fs";
import { constants as fsPromiseConstants } from "node:fs/promises";
console.log(constants === promises.constants); // logs: true
console.log(constants === fsPromiseConstants); // logs: true
```

Fixes https://github.com/denoland/deno/issues/21994
2024-01-21 21:48:48 +01:00

102 lines
2.4 KiB
TypeScript

// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
import {
assert,
assertEquals,
assertThrows,
} from "../../../test_util/std/assert/mod.ts";
import { join } from "node:path";
import { tmpdir } from "node:os";
import {
constants,
existsSync,
mkdtempSync,
promises,
readFileSync,
writeFileSync,
} from "node:fs";
import { constants as fsPromiseConstants } from "node:fs/promises";
import { pathToAbsoluteFileUrl } from "../unit/test_util.ts";
Deno.test(
"[node/fs writeFileSync] write file without option",
() => {
const data = "Hello";
const filename = mkdtempSync(join(tmpdir(), "foo-")) + "/test.txt";
writeFileSync(filename, data);
const dataRead = readFileSync(filename, "utf8");
assert(dataRead === "Hello");
},
);
Deno.test(
"[node/fs writeFileSync] write file with option ASCII",
() => {
const data = "Hello";
const filename = mkdtempSync(join(tmpdir(), "foo-")) + "/test.txt";
writeFileSync(filename, data, { encoding: "ascii" });
const dataRead = readFileSync(filename, "utf8");
assert(dataRead === "Hello");
},
);
Deno.test(
"[node/fs writeFileSync] write file throws error when encoding is not implemented",
() => {
const data = "Hello";
const filename = mkdtempSync(join(tmpdir(), "foo-")) + "/test.txt";
assertThrows(
() => writeFileSync(filename, data, { encoding: "utf16le" }),
'The value "utf16le" is invalid for option "encoding"',
);
},
);
Deno.test(
"[node/fs existsSync] path",
{ permissions: { read: true } },
() => {
assert(existsSync("cli/tests/testdata/assets/fixture.json"));
},
);
Deno.test(
"[node/fs existsSync] url",
{ permissions: { read: true } },
() => {
assert(existsSync(
pathToAbsoluteFileUrl("cli/tests/testdata/assets/fixture.json"),
));
},
);
Deno.test(
"[node/fs existsSync] no permission",
{ permissions: { read: false } },
() => {
assertThrows(() => {
existsSync("cli/tests/testdata/assets/fixture.json");
}, Deno.errors.PermissionDenied);
},
);
Deno.test(
"[node/fs existsSync] not exists",
{ permissions: { read: true } },
() => {
assert(!existsSync("bad_filename"));
},
);
Deno.test(
"[node/fs/promises constants] is the same as from node:fs",
() => {
assertEquals(constants, fsPromiseConstants);
assertEquals(constants, promises.constants);
},
);