foster/denoland-rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2024-11-25 15:29:43 -05:00
Code Issues Activity

Fix incorrect function signatures in module.rs (#388)

Browse source 
* `usize` and `int` are not equivalent or interchangeable at any level.
* Removed an unnecessary mutable borrow.
This commit is contained in:
Bert Belder 2020-05-31 18:35:41 +02:00
parent af9ac3c4b9
commit c114c46e15
No known key found for this signature in database
GPG key ID: 7A77887B2E2ED461
1 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/module.rs
View file

@ -1,3 +1,4 @@
use std::convert::TryInto;
use std::mem::MaybeUninit;
use std::ptr::null;
@ -90,7 +91,7 @@ extern "C" {
-> *const String;
fn v8__Module__GetModuleRequestLocation(
this: *const Module,
i: usize,
i: int,
out: *mut MaybeUninit<Location>,
) -> Location;
fn v8__Module__GetModuleNamespace(this: *const Module) -> *const Value;
@ -151,15 +152,18 @@ impl Module {
/// Returns the number of modules requested by this module.
pub fn get_module_requests_length(&self) -> usize {
unsafe { v8__Module__GetModuleRequestsLength(self) as usize }
unsafe { v8__Module__GetModuleRequestsLength(self) }
.try_into()
.unwrap()
}
/// Returns the ith module specifier in this module.
/// i must be < self.get_module_requests_length() and >= 0.
pub fn get_module_request(&self, i: usize) -> Local<String> {
unsafe {
Local::from_raw(v8__Module__GetModuleRequest(self, i as int)).unwrap()
Local::from_raw(v8__Module__GetModuleRequest(self, i.try_into().unwrap()))
}
.unwrap()
}
/// Returns the source location (line number and column number) of the ith
@ -167,7 +171,11 @@ impl Module {
pub fn get_module_request_location(&self, i: usize) -> Location {
let mut out = MaybeUninit::<Location>::uninit();
unsafe {
v8__Module__GetModuleRequestLocation(self, i, &mut out);
v8__Module__GetModuleRequestLocation(
self,
i.try_into().unwrap(),
&mut out,
);
out.assume_init()
}
}
@ -180,7 +188,7 @@ impl Module {
/// Returns the namespace object of this module.
///
/// The module's status must be at least kInstantiated.
pub fn get_module_namespace(&mut self) -> Local<Value> {
pub fn get_module_namespace(&self) -> Local<Value> {
unsafe { Local::from_raw(v8__Module__GetModuleNamespace(self)).unwrap() }
}