foster/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-14 11:48:09 -05:00
Code Issues Wiki Activity
21767 commits 22 branches 237 tags 593 MiB
Commit graph

1110 commits

Author SHA1 Message Date
Shiny Nematoda
53d4e90411 [FEAT] folding results for repo search (#4134) 
closes #3855

unlike #3854, this implementation uses a generic details html tag and a bit of tailwind magic...

---
## Maintainers Note
- previously tailwind classes of the form `[-a-zA-Z:0-9_.]` was disabled, however they were enabled since they were required for the `group-open:` classes

---

## Manual Testing
1. Visit the code search results after submitting a valid query for repo (if indexer disabled) or repo, user, explore (if indexer enabled)
2. Verify thst
    1. the results are unfloded/open by default
    2. the chevron points down when open and right when closed

<video src="/attachments/5a55c56f-6159-4422-ab80-962e0121e7d2" title="fold2.mp4" controls></video>

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4134
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Beowulf <beowulf@noreply.codeberg.org>
Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
 2024-06-15 20:16:18 +00:00
Danko Aleksejevs
221ca0c404 Implement tab indentation and list continuation in the new editor (#3848, #3849) (#4072) 
This overrides handling of Tab and Enter keys in the ComboMarkdownEditor, so that:

* Pressing Tab prepending 4 spaces to the line under cursor, or all the lines in the selection.
* Pressing Shift+Tab removes up to 4 spaces.
* Pressing Enter repeats any indentation and a "repeatable" prefix (list or blockquote) from the current line.

Since Tab "capture" can interfere with keyboard navigation, it's only done if there was any previous input in the textarea or if it was selected with a pointer. Additionally, presing Esc will make the textarea lose focus, resuming tab navigation. This seems adequate to me, but I might be wrong.

Had to use the "deprecated" execCommand method, since anything else I tried messes up the undo history. There's a fallback for when (if?) it's actually removed.

Only tested in desktop Firefox and Chrome so far.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4072
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Beowulf <beowulf@noreply.codeberg.org>
Co-authored-by: Danko Aleksejevs <danko@very.lv>
Co-committed-by: Danko Aleksejevs <danko@very.lv>
 2024-06-15 13:40:31 +00:00
Beowulf
09aa1c57f1
show edit textfield always initially when editing comments 
When a comment was added and saved with the preview tab active, the
preview tab is still active, when the comment is edited again.
This adds a "hacky" solution, but it works and is simple.
Every time the edit is "started" and the editor already exists, the tab
with the edit text field gets clicked to activate it.

Fixes #1334
 2024-06-14 15:42:21 +02:00
Earl Warren
e99d3f7055
feat(F3): CLI: f3 mirror to convert to/from Forgejo 
feat(F3): driver stub

feat(F3): util.Logger

feat(F3): driver compliance tests

feat(F3): driver/users implementation

feat(F3): driver/user implementation

feat(F3): driver/{projects,project} implementation

feat(F3): driver/{labels,label} implementation

feat(F3): driver/{milestones,milestone} implementation

feat(F3): driver/{repositories,repository} implementation

feat(F3): driver/{organizations,organization} implementation

feat(F3): driver/{releases,release} implementation

feat(F3): driver/{issues,issue} implementation

feat(F3): driver/{comments,comment} implementation

feat(F3): driver/{assets,asset} implementation

feat(F3): driver/{pullrequests,pullrequest} implementation

feat(F3): driver/{reviews,review} implementation

feat(F3): driver/{topics,topic} implementation

feat(F3): driver/{reactions,reaction} implementation

feat(F3): driver/{reviewComments,reviewComment} implementation

feat(F3): CLI: f3 mirror

chore(F3): move to code.forgejo.org

feat(f3): upgrade to gof3 3.1.0

repositories in pull requests are represented with a reference instead
of an owner/project pair of names
 2024-06-14 12:52:12 +02:00
Earl Warren
df373c9f7e Merge pull request '[gitea] week 2024-24 cherry pick (gitea/main -> forgejo)' (#4083) from earl-warren/wcp/2024-24 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4083
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
 2024-06-11 10:37:26 +00:00
0ko
367317af6c Disable issue subscribe button for guest users (#4095) 
* disabled the button itself, but added the tooltip to the form, because it didn't work for the button and likely has something to do with JS
* added an integration test to verify the new logic

## Preview

|Signed in|Guest|
|-|-|
|![](/attachments/b1441565-6aec-4a72-a28f-6383914c8918)|![](/attachments/839cc58e-18cf-4a5d-a9d7-f0e3e2556c98)|

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4095
Reviewed-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
 2024-06-11 05:54:35 +00:00
oliverpool
985939c145 test: pkce only for OpenID Connect 2024-06-10 11:24:32 +02:00
Mai-Lapyst
0a7767eaaa [FEAT] Adds x-mode-only anchor styles to display images based if the theme is light or dark mode. (#3985) 
Adds a feature similar to this https://github.blog/changelog/2021-11-24-specify-theme-context-for-images-in-markdown/ , by adding styles to elements which `src` or `href` attribute ends with `#light-mode-only` or `#dark-mode-only`. To improve compability, the github variants with the `gh-` prefix are also contained.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3985
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
Co-committed-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
 2024-06-09 10:50:53 +00:00
silverwind
6582f0029b
Add lint-go-gopls (#30729) 
Uses `gopls check <files>` as a linter. Tested locally and brings up 149
errors currently for me. I don't think I want to fix them in this PR,
but I would like at least to get this analysis running on CI.

List of errors:
```
modules/indexer/code/indexer.go:181:11: impossible condition: nil != nil
routers/private/hook_post_receive.go:120:15: tautological condition: nil == nil
services/auth/source/oauth2/providers.go:185:9: tautological condition: nil == nil
services/convert/issue.go:216:11: tautological condition: non-nil != nil
tests/integration/git_test.go:332:9: impossible condition: nil != nil
services/migrations/migrate.go:179:24-43: unused parameter: ctx
services/repository/transfer.go:288:48-69: unused parameter: doer
tests/integration/api_repo_tags_test.go:75:41-61: unused parameter: session
tests/integration/git_test.go:696:64-74: unused parameter: baseBranch
tests/integration/gpg_git_test.go:265:27-39: unused parameter: t
tests/integration/gpg_git_test.go:284:23-29: unused parameter: tmpDir
tests/integration/gpg_git_test.go:284:31-35: unused parameter: name
tests/integration/gpg_git_test.go:284:37-42: unused parameter: email
```

(cherry picked from commit 816222243af523316041692622be6f48ef068693)

Conflicts:
	Makefile
	trivial context conflict and also ask renovate to watch over it
	do not include it in lint-backend because the errors are not fixed
 2024-06-09 11:13:39 +02:00
Thomas Desveaux
c6e04c3c9e
Fix NuGet Package API for $filter with Id equality (#31188) 
Fixes issue when running `choco info pkgname` where `pkgname` is also a
substring of another package Id.

Relates to #31168

---

This might fix the issue linked, but I'd like to test it with more choco
commands before closing the issue in case I find other problems if
that's ok.

---------

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
(cherry picked from commit c888c933a930ee2ba4e7bb0bf6678aaf45a9778a)
 2024-06-09 11:13:39 +02:00
0ko
2599737033 Update instance title in tests 2024-06-08 23:33:55 +05:00
mirko
f015846c11 Add slogan config (#3752) 
This is a PR for #3616

Currently added a new optional config `SLOGAN`  in ini file. When this config is set title page is modified in APP_NAME [ - SLOGAN]

Example in image below

![Selezione_075.png](/attachments/7a72171e-e730-4e57-8c97-ffc94258e00f)

Add the new config value in the admin settings page (readonly)

![Screenshot 2024-05-13 at 18-04-13 My Forgejo.png](/attachments/dad00fc2-29fa-4371-a7b9-5233eadeac13)

## TODO

* [x] Add the possibility to add the `SLOGAN` config from the installation form
* [ ] Update https://forgejo.org/docs/next/admin/config-cheat-sheet

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3752
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: mirko <mirko.perillo@gmail.com>
Co-committed-by: mirko <mirko.perillo@gmail.com>
 2024-06-07 17:12:48 +00:00
Earl Warren
d8319b6cc2 Merge pull request 'test(oauth): RFC 6749 Section 10.2 conformance' (#4032) from earl-warren/forgejo:wip-oauth-public into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4032
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
 2024-06-06 10:00:37 +00:00
Earl Warren
dd0cabdaa4
feat(federated-star) star repositories via ActivityPub (#1680) 
commit 1be80cfdbca10d5014cec904e96c7a390b338493
Merge: c01b10a593 130981af64
Author: Earl Warren <earl-warren@noreply.codeberg.org>
Date:   Thu Jun 6 06:36:34 2024 +0000

    Merge pull request 'federated-star' (#1680) from meissa/forgejo:forgejo-federated-star into forgejo

    Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/1680
    Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>

commit 130981af64
Merge: 62856e639e c01b10a593
Author: Earl Warren <earl-warren@noreply.codeberg.org>
Date:   Thu Jun 6 06:07:34 2024 +0000

    Merge branch 'forgejo' into forgejo-federated-star

commit 62856e639e
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Jun 6 07:26:28 2024 +0200

    adjust field name

commit 81236bc9ef
Merge: c0b9ab2060 1b3ccfffe8
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Jun 5 07:33:12 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit c0b9ab2060
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Tue Jun 4 12:37:18 2024 +0200

    Extend integration test for staring federated repo

commit 98939c4745
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 31 18:05:29 2024 +0200

    remove no longer used doc

commit 17e3f6c6f3
Merge: 58b8f57d3f f887972348
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 31 18:03:19 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit 58b8f57d3f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 29 09:20:39 2024 +0200

    more lint

commit c3650cb2fe
Merge: 07e2708e3d 73f6e8809a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 29 09:01:00 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit 07e2708e3d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 29 08:59:32 2024 +0200

    lint

commit e7580da130
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 29 08:58:19 2024 +0200

    lint

commit 7b2309592c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 29 08:55:47 2024 +0200

    remove unused

commit dadfb29ae9
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 29 08:44:00 2024 +0200

    relax validation

commit 26612aa75b
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue May 28 15:37:53 2024 +0200

    Add ToDo

commit fa5806cecf
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue May 28 15:37:41 2024 +0200

    Use StatusSeeOther

commit 75c93e5319
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue May 28 12:54:49 2024 +0200

    Update NewRepositoryID with case for following repo

commit 9c9333868c
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue May 28 12:38:27 2024 +0200

    Add todo

    We currently validate RepositoryID uris to be a valid api address from our own server.

commit 69e79e50c2
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue May 28 12:36:34 2024 +0200

    Lift test env prep one up

commit 72f2f35bd8
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue May 28 08:57:03 2024 +0200

    wip integration test

commit a133b6de31
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue May 28 08:53:19 2024 +0200

    rename

commit 3d1586d9cb
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon May 27 08:20:43 2024 +0200

    translation hast to be done in translation tool

commit 108971ddc8
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon May 27 08:18:09 2024 +0200

    add migration

commit 6ef691b8d7
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 24 16:34:11 2024 +0200

    lint

commit a3c90e3085
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 24 13:27:37 2024 +0200

    field no longer in use

commit 5ace6816ac
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 24 08:50:54 2024 +0200

    remove todo - no change required

commit 64be24ed0c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 24 08:49:08 2024 +0200

    Format & remove old todos

commit 30e2582f24
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 24 08:24:54 2024 +0200

    mv doc to doc project

commit 2e72b5e05b
Merge: 4c87b0b3ee eea841d25d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 24 07:25:20 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit 4c87b0b3ee
Merge: a1acc46c88 9c7ff70072
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 22 18:23:21 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit a1acc46c88
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue May 21 18:46:48 2024 +0200

    make mocked user consistent

commit a62c2afcea
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Tue May 21 11:43:15 2024 +0200

    Extended integration test

commit 07659a5e7e
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 17 08:15:33 2024 +0200

    rename fxct name

commit 86db5f612c
Merge: 307b27bbaa 45a41811de
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu May 16 18:28:43 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit 307b27bbaa
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu May 16 18:22:09 2024 +0200

    choose a not local avail federated userid

commit a9c00d49da
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Thu May 16 10:55:17 2024 +0200

    Set LowerName to name with lower case

commit 6457ace318
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Thu May 16 10:26:51 2024 +0200

    Added migrations for User and FederatedUser

commit 1b3c4dcd85
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Thu May 16 10:06:13 2024 +0200

    Extended AP like-repo integration test

commit 94be68725a
Merge: 08fe47d5c8 fe3473fc8b
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 15 09:35:02 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit 08fe47d5c8
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue May 14 07:48:00 2024 +0200

    Do not relay on ID start at 1

commit 57a9729094
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Mon May 13 14:29:54 2024 +0200

    linting

commit e55533d64d
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Mon May 13 14:15:36 2024 +0200

    Added migration for creation of federation_host table

commit cf9953a612
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Mon May 13 12:28:31 2024 +0200

    linting

commit c3fb34d5b4
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Mon May 13 12:00:16 2024 +0200

    fixed some comments

commit 379b0234eb
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Mon May 13 12:00:02 2024 +0200

    added test cases for federationhost

commit 8f42684599
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Mon May 13 11:24:50 2024 +0200

    Renamed field of FederationHost

commit c4f9f8578a
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Mon May 13 11:14:04 2024 +0200

    Introduced ErrNotValid

commit cb4690e570
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon May 13 07:45:37 2024 +0200

    linting

commit 3cc48a5c9f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 10 17:44:26 2024 +0200

    format

commit 3bf423c97f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 10 17:29:49 2024 +0200

    assert, that federation-host is present.

commit 8d330fdb5d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 10 17:01:15 2024 +0200

    Now we've an intergration test with second federation server

commit 0665c1252e
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 10 16:25:54 2024 +0200

    make start time more flexible

commit c4c03dab4b
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 10 15:27:54 2024 +0200

    on the way to test with second server

commit 8ec570841a
Merge: e122df36f8 99d1ae52fc
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue May 7 17:49:26 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit e122df36f8
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue May 7 17:47:35 2024 +0200

    prepare for next pr

commit fdfc21a6b8
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue May 7 07:38:20 2024 +0200

    review results

commit 82fe1d3e42
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Mon May 6 16:01:23 2024 +0200

    make fmt

commit a485837b9c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon May 6 08:52:25 2024 +0200

    removed unused code

commit c70b8d28a3
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon May 6 08:12:43 2024 +0200

    linting

commit 8f298a9901
Merge: b99d66b530 8c3511a8b3
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon May 6 07:58:50 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit b99d66b530
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sun May 5 18:04:12 2024 +0200

    linting

commit 3a6dfadcd0
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sun May 5 17:10:16 2024 +0200

    linting

commit 510868731d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sun May 5 16:58:15 2024 +0200

    linting

commit 1a07db1a40
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sun May 5 16:35:25 2024 +0200

    omit linting next try

commit ca0a53bf5f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat May 4 17:58:54 2024 +0200

    omit linting maybe?

commit ee71f86432
Merge: 957b1023e9 85f2727872
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 3 08:44:49 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit 957b1023e9
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri May 3 08:00:17 2024 +0200

    refactoring: separaate model & module

commit 42837f5dab
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu May 2 08:56:36 2024 +0200

    fix linting

commit ded7b60d0c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 1 15:46:15 2024 +0200

    wix the invalid test

commit 534d692d68
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 1 15:46:03 2024 +0200

    fix field names

commit 715ff0eb7f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 1 15:23:39 2024 +0200

    remove unused & fix wording

commit 87036ec719
Merge: be6e6eb96a bbec2e2960
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 1 15:02:36 2024 +0200

    Merge branch 'forgejo-federated-star' of codeberg.org:meissa/forgejo into forgejo-federated-star

commit be6e6eb96a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 1 15:02:27 2024 +0200

    refactor validation

commit bbec2e2960
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed May 1 14:53:42 2024 +0200

    Fix test and add symmetry

    This maybe was a mixup with TestActivityValidation.
    We now test if the UnmarshalJSON actually threw an error.

commit 4b2802a6ba
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 1 14:39:23 2024 +0200

    internal refactoring

commit 6c7cff4f16
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed May 1 14:39:09 2024 +0200

    fix NPE

commit e9fed7a488
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Apr 29 20:13:37 2024 +0200

    found NPE

commit 285e72e4e6
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Apr 29 19:51:28 2024 +0200

    found issue during test

commit a9a30fc212
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Apr 29 08:40:46 2024 +0200

    remove resolved todo & integration test

commit 2f2330c450
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sun Apr 28 13:52:51 2024 +0200

    first integration test

commit 70ae102597
Merge: df2fd904b3 d6c36ec406
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Apr 26 17:16:15 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit df2fd904b3
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Apr 26 16:37:16 2024 +0200

    drop some words on normalized uri as id

commit 37ed52cfd9
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Apr 26 16:19:31 2024 +0200

    start add NormalizedFederatedUri to user

commit f687f79ed0
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Apr 26 15:48:56 2024 +0200

    start add NormalizedFederatedUri to user

commit b878e74f76
Merge: 71141a5ff3 37420442de
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Apr 12 14:33:57 2024 +0200

    Merge branch 'forgejo-federated-star' of codeberg.org:meissa/forgejo into forgejo-federated-star

commit 71141a5ff3
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Apr 12 14:33:47 2024 +0200

    WIP Refactoring and solving (adding) ToDos

commit fb1d0df791
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Apr 12 14:29:32 2024 +0200

    Also check for RepoID to be unique

commit f3e58f29b0
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Apr 12 14:24:38 2024 +0200

    Pass unvalidated input to field

commit feca77b040
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Apr 12 13:58:55 2024 +0200

    Rename for clearer semantics

commit 37420442de
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Apr 12 13:52:26 2024 +0200

    unify copyright comment

commit 94091cc144
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 16:38:49 2024 +0200

    Don't use TEXT type

commit 6310e75d8d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 16:33:13 2024 +0200

    Update todo

commit 075857f030
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 16:32:49 2024 +0200

    Update docs

commit 19628b84c6
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 16:00:51 2024 +0200

    use context

commit 80888b80d6
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 16:00:28 2024 +0200

    Fix imports

commit af0d0f7745
Merge: bbcb8e7060 9d6389352d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 15:38:11 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit bbcb8e7060
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 14:21:51 2024 +0200

    Bits of format

commit bb83a8d85e
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 12:58:28 2024 +0200

    make fmt

commit 0eb71098a2
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 12:53:56 2024 +0200

    make tidy

commit e2c9653b33
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 12:47:26 2024 +0200

    Update go version and protobuf deps

commit 2b9977d843
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 11:46:11 2024 +0200

    Linting

commit 511ef0bf5b
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 11:24:22 2024 +0200

    Use federated staring func

commit 8579b7f7bb
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 11:21:57 2024 +0200

    Use optional.Some

commit 97343470bc
Merge: 213fc3a97d 21b1381e36
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 9 10:42:42 2024 +0200

    Merge branch 'forgejo' into forgejo-federated-star

commit 213fc3a97d
Merge: c908455998 765298814c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Apr 6 10:59:41 2024 +0200

    Merge branch 'forgejo-federated-star' of codeberg.org:meissa/forgejo into forgejo-federated-star

commit c908455998
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Apr 6 10:59:36 2024 +0200

    fix multiple federation in one host

commit 765298814c
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Apr 5 17:07:04 2024 +0200

    Add ToDo

commit 33c60ebdff
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Apr 5 17:06:57 2024 +0200

    Add logging

commit 41f066a1a6
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Apr 4 18:33:08 2024 +0200

    add notes for setup

commit 15bb774409
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Apr 4 18:05:55 2024 +0200

    add relation details

commit 8d78c3edca
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Thu Apr 4 15:12:41 2024 +0200

    make fmt

commit b4e6a7ea3f
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Thu Apr 4 15:09:40 2024 +0200

    make lint-go-fix

commit 92d011f1a5
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Thu Apr 4 15:08:02 2024 +0200

    fix some linting issues

commit 976d79044f
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Thu Apr 4 08:32:37 2024 +0200

    show apapiurl in repo settings

commit 73cf1e3901
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Thu Apr 4 07:22:04 2024 +0200

    Revert "added repoUri to federationService"

    This reverts commit 8cd89bf4d3.

commit 8cd89bf4d3
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Wed Apr 3 15:39:37 2024 +0200

    added repoUri to federationService

    This does not work yet. APAPI url OR host and id have to be derived from repoUri.

commit 2b7a22afb3
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Wed Apr 3 12:26:33 2024 +0200

    renamed FederatedRepo to FollowingRepo

commit daccaed157
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Apr 3 12:08:44 2024 +0200

    Rename federatedRepo to followingRepo

commit d240a9bc90
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Wed Apr 3 10:25:40 2024 +0200

    trim trailing semicolon

commit 5671566df6
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Wed Apr 3 09:53:19 2024 +0200

    adjust fed repo splitting

commit 7a142c876e
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Apr 2 18:36:22 2024 +0200

    remove federated user in case of user deletion

commit 5edf7d0e61
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Apr 2 17:33:32 2024 +0200

    Also trim whitespaces within the list items

commit 431b4c2829
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Tue Apr 2 12:38:06 2024 +0200

    optimize function

commit 962cd374e2
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Tue Apr 2 12:36:04 2024 +0200

    delete federated repos when deleting repository

commit 8b56159042
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Tue Apr 2 11:13:50 2024 +0200

    prevent error when setting no fed repos

commit 9212fb1633
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Apr 2 09:03:49 2024 +0200

    feedback from discussion

commit b747342672
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Mar 28 16:08:29 2024 +0100

    separate collecting activities from sending them

commit 2ad685fd2c
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Thu Mar 28 15:41:43 2024 +0100

    fix like target

commit e2b11b93bc
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Mar 28 15:21:40 2024 +0100

    Merge branch 'forgejo-federated-star' of codeberg.org:meissa/forgejo into forgejo-federated-star

commit fc8e2b3f8a
Merge: 4d5c8b5563 7f19247b0a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Mar 28 15:05:35 2024 +0100

    Merge branch 'forgejo-federated-star' of codeberg.org:meissa/forgejo into forgejo-federated-star

commit 4d5c8b5563
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Mar 28 15:00:55 2024 +0100

    refactor services

commit 7f19247b0a
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Thu Mar 28 14:27:50 2024 +0100

    Moved sendLikeActivities to federation_service

commit 1ad7bdf983
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Thu Mar 28 09:36:08 2024 +0100

    fixed tests
    part1, one test still failing

commit d624ebb712
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Mar 28 08:13:00 2024 +0100

    use doer coming from api

commit 992fbf6898
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Mar 28 07:44:22 2024 +0100

    comments

commit 259c0202c7
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Mar 27 19:56:32 2024 +0100

    fix test & add some review

commit 8eae48761f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Mar 27 19:26:55 2024 +0100

    add some pictures

commit e75bcb2f89
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Mar 27 19:02:37 2024 +0100

    rename file

commit 97b5e0da91
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Wed Mar 27 16:20:33 2024 +0100

    revise NewForgeLike
    Also added new test, which still fails since time.Now() does not match

commit 911e916a4f
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Wed Mar 27 11:33:00 2024 +0100

    Added new blog post

commit a2a5956d79
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Wed Mar 27 09:29:23 2024 +0100

    Added context and choices to new adr

commit dd37e3a7b8
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Mar 27 08:25:16 2024 +0100

    wip

commit a950ba4631
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Mar 27 08:21:44 2024 +0100

    prepare state of the month

commit 84f73d9db8
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 26 16:56:06 2024 +0100

    Add ToDo

commit 01e9853161
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 26 16:54:55 2024 +0100

    Add ToDo for storing federated repos

    We need to check whether federated repos already exist in db. This way multiple repos on a server (forks) can have the same federated repos.

commit 45cddb4ac7
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 26 16:53:02 2024 +0100

    Add logging

commit 436466dcad
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 26 16:21:28 2024 +0100

    Check if federation enabled in StarRepo

commit e9bbdc678b
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 26 16:21:09 2024 +0100

    Not using object URL

commit 04f907c8c8
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 26 15:28:55 2024 +0100

    Revert

commit 32d457f9a3
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 26 15:28:36 2024 +0100

    StarRepo Wrapper

commit 0b8aa3105c
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 26 15:28:11 2024 +0100

    Create object manually

commit b2105de36f
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 26 14:39:25 2024 +0100

    SendLikeActivity to api

    It might not be a good idea to start a possibly long lasting http call during a running DB transaction. I.E. in the case of failing transaction we already sent some data into the world which might not be valid.

commit bbe5096307
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Tue Mar 26 14:02:30 2024 +0100

    fixed circular dependencies
    next: fix post call error

commit 7f0371056e
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Tue Mar 26 10:23:14 2024 +0100

    moved functionality
    import of forgefed causes circular dependencies. This has to be solved!

commit d251fc2611
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Tue Mar 26 08:28:22 2024 +0100

    set federatedRepoList into context

commit cf8a30efac
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Mar 26 07:58:04 2024 +0100

    mob-next: how to store port & schema

commit 5b8173f660
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Mar 26 07:36:09 2024 +0100

    do not return invalid result

commit 6d814447d0
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Mon Mar 25 16:52:39 2024 +0100

    Use Plural

commit 653ced5596
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Mon Mar 25 16:47:18 2024 +0100

    Validate before returning

commit 35d3fc199c
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Mon Mar 25 16:35:35 2024 +0100

    Rename to StoreFederatedRepo*

commit ca7d1c6f78
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Mon Mar 25 16:30:02 2024 +0100

    Localize error messages

commit 828e7a76f6
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Mar 25 09:15:32 2024 +0100

    use new table to populate settings

commit a9d18e5327
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Mar 23 17:01:25 2024 +0100

    fixed issues, store now works

commit ce317c33cb
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Mar 23 15:27:45 2024 +0100

    fix context

commit 950dcd959e
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Mar 22 20:14:20 2024 +0100

    implement storage of federated_repo

commit 6b767684a7
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Mar 22 17:51:20 2024 +0100

    Add discussion ToDo

commit 0f27f0a05b
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Mar 22 17:49:29 2024 +0100

    Add discussion ToDo

commit 0f9d1c80be
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Mar 22 17:42:38 2024 +0100

    Implement CreateFederatedRepoList

commit 36c0c1c3c1
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Mar 22 17:41:59 2024 +0100

    Add DB functionality for federated repos

commit 288dda282c
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Mar 22 17:41:36 2024 +0100

    Add more ToDos

commit 508b4deac8
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Mar 22 08:37:06 2024 +0100

    add test & fix compile

commit 4938d38e39
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Mar 22 08:08:54 2024 +0100

    more review

commit 9ccad50b05
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Mar 22 07:52:03 2024 +0100

    review

commit 7316108d56
Merge: 7e355986f8 3e6eb255b3
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Mar 22 07:32:30 2024 +0100

    Merge branch 'forgejo-federated-star' of codeberg.org:meissa/forgejo into forgejo-federated-star

commit 7e355986f8
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Mar 22 07:32:22 2024 +0100

    fix wording

commit 3e6eb255b3
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Mar 21 16:29:13 2024 +0100

    WIP Initial, naive implementation of sending stars to fed repos

    Currently no rate limits are respected
    The mechanisms to use the Federated repo table need to be used

commit 0c6c43003c
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Mar 21 16:27:35 2024 +0100

    Implement getting APAPIURL for repo and user

commit ed256ca540
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Mar 21 16:27:08 2024 +0100

    Implement NewForgeLike

commit 2e0584bdf3
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Mar 21 15:37:37 2024 +0100

    Clearer error message

    "May" is also interchangeable with "could". "Should" fits better in this context.

commit 84f2aab570
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Mar 21 14:42:38 2024 +0100

    Add todo

commit 42a41ce2bc
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Mar 21 14:42:16 2024 +0100

    Remove todo

commit a02ec0363b
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Mar 21 14:42:04 2024 +0100

    Add todo

commit e4242dafd9
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Mar 21 14:41:11 2024 +0100

    Add Function description

commit 689837b63a
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Mar 21 12:59:59 2024 +0100

    Fix typos

commit f327c0da24
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Mar 21 12:18:29 2024 +0100

    Cap max size of federated repo list at 2048 bytes

commit 6055b4fca0
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Mar 21 11:42:12 2024 +0100

    Add todo

commit b4bb41e0e3
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Mar 21 08:25:40 2024 +0100

    introduce federated repo

commit 3b30c678e7
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Mar 20 16:22:35 2024 +0100

    Remove ToDo

commit b6035c03ae
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Mar 20 16:14:54 2024 +0100

    Rephrasing for clearness

commit 2e803e10c0
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Mar 20 16:12:42 2024 +0100

    Do not use binding at this stage

    It wasn't clear how to utilize the "type" field in the .tmpl for our
    purposes.

commit 13bf84e89e
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Mar 20 16:12:20 2024 +0100

    Implent checking for list of repos

commit 3dda92b52b
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Mar 20 13:26:46 2024 +0100

    Update Locales to reflect changes

commit ea4471d0db
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Mar 20 13:22:56 2024 +0100

    Remove ToDos

commit d1190423bb
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Mar 20 13:21:17 2024 +0100

    Implement single Repo validation and saving POC

commit 1cbd5e33cb
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Mar 20 13:16:53 2024 +0100

    Validate Federated Repos Field

    Considering this from a POC perspective we might want to avoid misuse
    of this field. In other words, we want this field to be used as
    intended.

commit 584af0486d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Mar 20 13:13:23 2024 +0100

    Add Federation specific URL validation

commit 41da150fb3
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Mar 19 19:28:33 2024 +0100

    add review comment

commit 84f236a58d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 19 15:30:56 2024 +0100

    Add more todos

commit 884e38bdab
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 19 15:25:52 2024 +0100

    WIP Implement proper saving of federated repo urls

    Added ToDos where relevant

commit 9337274334
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 19 13:56:12 2024 +0100

    Revert to input

commit abc7aa0972
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 19 13:53:00 2024 +0100

    Display data on text area

commit 048ff5da11
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 19 13:52:14 2024 +0100

    Fix typos

commit 4c1d12b2e4
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 19 13:52:00 2024 +0100

    Use textarea as we expect lots of input

commit 09cac163e0
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 19 13:17:27 2024 +0100

    Add a field for listing the federated repos

commit a6d45f8b97
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Mar 19 11:56:25 2024 +0100

    Implement FederationEnabled function for templates

commit 26eb01b509
Author: Mirco <mirco.zachmann@meissa.de>
Date:   Tue Mar 19 10:25:20 2024 +0100

    corr var label name

commit 3018769d26
Author: Mirco <mirco.zachmann@meissa.de>
Date:   Tue Mar 19 10:05:31 2024 +0100

    Federation settigs :: set label name for internationalisation

commit 6901ae4b99
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Mar 19 08:29:57 2024 +0100

    wip: found backend for settings update

commit 9dcdf8d828
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Mar 16 12:46:43 2024 +0100

    Locales, field & action

commit fdcff3cc43
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Mar 8 18:25:37 2024 +0100

    found the template for frontend

commit 93d7de147b
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Mar 4 13:57:33 2024 +0100

    adjust to new dev-model

commit e41fa653d9
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Mar 4 13:43:16 2024 +0100

    fix en name of score :-)

commit 0e73dfccbb
Merge: e2ca63ca38 db2f896264
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Feb 14 18:23:15 2024 +0100

    Merge branch 'forgejo-federated-star' of codeberg.org:meissa/forgejo into forgejo-federated-star

commit e2ca63ca38
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Feb 14 18:23:10 2024 +0100

    Add Malicious Controlled Forge - kudos to gusted

commit db2f896264
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Tue Feb 13 11:09:31 2024 +0100

    small fix by adding id as pk for FederatedUser

commit 086c66b06a
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Mon Feb 12 13:07:15 2024 +0100

    make tidy

commit 2e41fe0a46
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Mon Feb 12 13:00:47 2024 +0100

    fix import

commit d65cd5a17a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Feb 12 10:55:00 2024 +0100

    ActorID gets source type from NodeInfo

commit 181d743a8a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Feb 12 10:14:29 2024 +0100

    update copyright

commit 9662aee375
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Feb 12 10:14:16 2024 +0100

    reflect hard fork

commit 6e6813a88b
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Feb 9 18:17:40 2024 +0100

    make operatorid unique

commit 6d17f45986
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Feb 9 17:56:17 2024 +0100

    fix misspell

commit eecb9b8040
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Feb 9 17:46:27 2024 +0100

    fmt fix

commit 664144930e
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Feb 9 17:10:59 2024 +0100

    result of lint-fix

commit 5fa62287d6
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Feb 9 17:00:21 2024 +0100

    undo rebase conflicts

commit 3ef57385ec
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Feb 9 16:44:03 2024 +0100

    fix linting

commit 3b244d673b
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Feb 9 16:24:51 2024 +0100

    small fixes

commit ac82486a95
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Feb 9 15:31:58 2024 +0100

    This months blog

commit 8917bfca0c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Feb 9 15:12:49 2024 +0100

    add a arch federation overview

commit 94937abc04
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Feb 9 15:12:26 2024 +0100

    Source is no longer needed - see adr-federated-star

commit b2cc848e7d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Feb 8 15:31:02 2024 +0100

    clean up aliases

commit e733809ef2
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Feb 8 15:16:37 2024 +0100

    symetric handling for value/reference

commit d2d5e84977
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Feb 8 15:16:02 2024 +0100

    federated user is not entity - so no need for ID

commit 91f7541add
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Feb 8 13:31:27 2024 +0100

    refactor for semantic and cycle free deps

commit 66bc7a9a0c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Feb 8 11:09:55 2024 +0100

    Search federatedUser instead of loginName

commit e44be72251
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Feb 8 09:56:49 2024 +0100

    Add tx around user creation

commit edf7f61b83
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Feb 7 17:11:43 2024 +0100

    mv federated_user_creation to user package

commit e180467760
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Wed Feb 7 16:42:40 2024 +0100

    added user creation from ap

commit a702da69cc
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Feb 7 16:12:23 2024 +0100

    added test for federated user

commit 67f3f66be4
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Wed Feb 7 15:37:48 2024 +0100

    Created FederatedUser

commit e477181e23
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Wed Feb 7 15:03:21 2024 +0100

    fix typos

commit a1ca7e958a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Feb 7 14:59:39 2024 +0100

    use local fqdn for generated user email

commit 5a7f6f15a6
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Feb 7 14:30:17 2024 +0100

    ensure federation info fqdn to lowercase

commit e05c810823
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Feb 7 13:52:25 2024 +0100

    document usermapping chosen

commit e255f73731
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Feb 6 13:30:09 2024 +0100

    make class diagram more accurate

commit 7db83688db
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Feb 6 12:45:33 2024 +0100

    updated rebase process

commit ed99dfa993
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Feb 2 17:25:02 2024 +0100

    new threats thx to gusted

commit 56660e3a0b
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Feb 1 15:48:56 2024 +0100

    add aspect resulting from our discussion

commit b02b8a307c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sun Jan 28 12:48:44 2024 +0100

    fix wording

commit c45e726383
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sun Jan 28 12:43:56 2024 +0100

    fix wording

commit 5ef823e3af
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Jan 27 15:03:37 2024 +0100

    adjust urls to changed username

commit a08e435a1e
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 26 17:16:26 2024 +0100

    updated rebase instructions

commit 6b14d1a562
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 26 16:13:55 2024 +0100

    updated rebase instructions

commit 49b014f28f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 19 16:33:59 2024 +0100

    add reply attack to blog

commit c58a995fb2
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 19 16:26:16 2024 +0100

    refactor FederationInfo -> FederationHost

commit e926ea16e2
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Jan 18 20:06:56 2024 +0100

    improve english ..

commit e1f27a950c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Jan 18 20:01:22 2024 +0100

    improve english ..

commit 2c55c0252f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Jan 18 19:48:36 2024 +0100

    prepare discussion

commit 2b5360a000
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Jan 18 19:20:15 2024 +0100

    work on adr

commit a6b7cc8e70
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Jan 18 19:20:02 2024 +0100

    update needed modules

commit 0453598e3d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Jan 16 09:31:36 2024 +0100

    add some todos

commit 48c6d62e47
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Jan 16 09:31:27 2024 +0100

    blog: newest on top

commit c6981cdbf6
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Jan 16 08:28:12 2024 +0100

    proposals for federatedPerson Mapping

commit e2291fec1e
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Jan 15 08:12:40 2024 +0100

    think about federated persons

commit 5a88eef78e
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Jan 15 08:12:26 2024 +0100

    Propose the current solution

commit 0ddc2db46a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sun Jan 14 14:53:00 2024 +0100

    mitigate Block by future StartTime

commit 1b35bd2911
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sun Jan 14 13:03:51 2024 +0100

    lint fix

commit f25eab35fc
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Jan 13 17:16:43 2024 +0100

    Update for new implementation

commit c4eb763f4a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Jan 13 17:06:40 2024 +0100

    lint fix

commit 9a9ac33766
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Jan 13 16:22:49 2024 +0100

    lint fix

commit ca5eaa8c6b
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Jan 13 16:08:12 2024 +0100

    introduce FI Factory

commit dabd773f6b
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Jan 13 14:17:11 2024 +0100

    Fix error handling & add timestamp check

commit 40ec049013
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 12 18:12:22 2024 +0100

    add the next todo

commit 7d30d14c76
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Fri Jan 12 17:49:07 2024 +0100

    breaking  struct adjustment

commit 1f989f2ecd
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Fri Jan 12 17:27:52 2024 +0100

    Added FederationInfo Create function

commit 380d3db0bf
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 12 17:00:17 2024 +0100

    integrate federation info in api call

commit 52400f7978
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Fri Jan 12 16:12:54 2024 +0100

    Added FederationInfo get methods for repository

commit bbccc24ed1
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 12 15:34:34 2024 +0100

    test federationinfo validation

commit 9c37272ee9
Author: Clemens <clemens.geibel@meissa-gmbh.de.de>
Date:   Fri Jan 12 14:57:22 2024 +0100

    make validateNotEmpty more generic

commit c67be3b668
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 12 14:35:43 2024 +0100

    start work on federationinfo

commit 8610d94af8
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 12 14:33:52 2024 +0100

    start work on federationinfo

commit 12558d62c8
Author: bom <mattis.boeckle@meissa-gmbh.de>
Date:   Fri Jan 12 12:43:14 2024 +0100

    Remove MaxConnsPerHost limit for outgoing connections

commit 87bfa79f71
Author: bom <mattis.boeckle@meissa-gmbh.de>
Date:   Fri Jan 12 12:29:00 2024 +0100

    Configure client against DOS

commit ecf391dcbf
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Jan 9 09:14:52 2024 +0100

    add some user creation unittests

commit de2569618c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Jan 8 18:21:55 2024 +0100

    fix: wmail should start with char

commit f0af660cf9
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 5 18:19:46 2024 +0100

    give names to threats

commit a8b132da80
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 5 17:43:18 2024 +0100

    provide the next testing

commit 2d98b22604
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 5 17:11:20 2024 +0100

    blog the next test release

commit 0fac86a384
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 5 16:42:57 2024 +0100

    update to new star activity

commit 42eab2d304
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 5 12:03:36 2024 +0100

    add test-release-branch

commit 680213b479
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 5 11:43:52 2024 +0100

    translate scoring

commit 1fc1dda59d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 5 11:40:35 2024 +0100

    Fix wording

commit b978642da0
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Jan 5 11:34:32 2024 +0100

    improve sequence

commit fe9f26305f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Jan 4 18:25:43 2024 +0100

    update ThreatAnalysis for Like Aktivity

commit 6e46739090
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Jan 4 18:04:46 2024 +0100

    validate person

commit 0505baab2b
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Jan 3 18:52:41 2024 +0100

    ad validation for like activity

commit 3ab2d9a449
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Jan 3 18:29:12 2024 +0100

    rename star -> ForgeLike

commit 4473fb788a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Jan 3 18:10:24 2024 +0100

    start refactoring star->like

commit 38438b592f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 29 18:09:27 2023 +0100

    rebase conflicts to fix

commit f673dd1ca7
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 29 16:31:52 2023 +0100

    source no longer needed

commit 084eed82a4
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 29 16:30:58 2023 +0100

    use federate-repo users for our local test

commit b2a9b53041
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 29 15:54:13 2023 +0100

    use nodeInfo.Source instead of startActivity.Source

commit 8116214727
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 29 15:48:45 2023 +0100

    introduce nodeinfo

commit 587bd07372
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 29 15:48:31 2023 +0100

    mv more fkt to http-client

commit 310d740cee
Author: bom <mattis.boeckle@meissa-gmbh.de>
Date:   Fri Dec 29 12:10:07 2023 +0100

    Start NodeInfo implementation

commit 3c2493902d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 29 09:43:10 2023 +0100

    adjust to ugly linting

commit e704e5adcc
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 22 15:10:21 2023 +0100

    adjust to ugly linting

commit 1e40b814a1
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Dec 22 15:00:42 2023 +0100

    Linting

commit 8585edc47a
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Dec 22 14:52:10 2023 +0100

    Linting

commit 7d78fb8adc
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 22 14:47:34 2023 +0100

    adjust to ugly linting

commit a64ce2feb1
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 22 14:20:30 2023 +0100

    removed resolved todos

commit 2e031a9763
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Dec 22 13:44:45 2023 +0100

    WIP Generic IsValid for *Id structs

commit e69e5df089
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Dec 22 13:42:07 2023 +0100

    Assume validated url.URL for NewActorID

commit 6e4467d49d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 22 11:48:24 2023 +0100

    experiment on generalization

commit 75cc5b900d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Dec 22 10:19:01 2023 +0100

    Add review todo

commit 1dd3084f66
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 21 15:01:49 2023 +0100

    Split test according to actor.go

commit 48cfb521d1
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 21 14:22:42 2023 +0100

    Add suffix checking helper

commit c887bddb72
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 21 14:22:23 2023 +0100

    Attempt generalization of Id creation

commit 15775ad891
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 21 14:21:47 2023 +0100

    Fix import

commit 715afb2468
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 21 09:30:07 2023 +0100

    Add newlines for readability

commit fff4c3f9fc
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Dec 20 20:12:31 2023 +0100

    fix typo

commit 5317832fef
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Dec 20 13:04:40 2023 +0100

    odd one mor picture to the blog

commit 433a38699a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Dec 20 12:55:28 2023 +0100

    improve test description

commit 65e3f1d0ed
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Dec 20 09:33:29 2023 +0100

    update adr lining out a second option

commit 4d1492831d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 20 12:30:22 2023 +0100

    Move char_limiter to utils and rename

commit afc9acd925
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 20 12:23:13 2023 +0100

    Limit number of characters on body log

commit 3363b3bf0c
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 20 12:22:03 2023 +0100

    Validate response before further processing

commit 2f4b1a5cd4
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 20 12:20:41 2023 +0100

    Use id of existing repo for convenience

commit ff146a9430
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 20 11:27:44 2023 +0100

    Add review todos

commit 071b47b8d0
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Dec 19 12:26:55 2023 +0100

    Catch edge case: remote user does not exist on remote repo

commit 0378b2dc7d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Dec 19 10:55:30 2023 +0100

    Add questions for review discussion

commit 8a8b6821ba
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Dec 19 11:32:57 2023 +0100

    Fix bash code block

commit 3327fbc39a
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Dec 19 10:19:35 2023 +0100

    Fix typos, small rewordings

commit bd640a7099
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Dec 19 09:21:23 2023 +0100

    add some pros to the source field

commit 70fbfd6cf3
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Dec 19 08:36:02 2023 +0100

    reflect the discussion with kik

commit f636de050a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Dec 16 18:47:39 2023 +0100

    some improvements

commit bc7515fa31
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Dec 16 18:45:14 2023 +0100

    some improvements

commit f9bbb91f11
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Dec 16 18:38:31 2023 +0100

    expose instance for tests

commit 1704ac5bc2
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 15 16:02:50 2023 +0100

    fix most of the tests

commit 9e6c45f87d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 15 15:37:00 2023 +0100

    make flows more precise

commit e1d7db178c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 15 14:45:20 2023 +0100

    unify logging & minor improvements

commit 42854c9003
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Dec 13 16:49:23 2023 +0100

    remove global actionUser

commit a0c008b880
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Dec 13 16:44:11 2023 +0100

    cleand up user creation from ap

commit 6de8fba14d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Dec 13 16:06:53 2023 +0100

    minor refactorings

commit 44e10ed65a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Dec 13 16:06:37 2023 +0100

    get wo body

commit c2a42587d2
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Dec 12 11:08:57 2023 +0100

    remove panics - that is not a exception replacement

commit b27460d3fe
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Dec 12 11:04:03 2023 +0100

    minor refactorings & reviews

commit e893618cdc
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Dec 11 08:14:18 2023 +0100

    add more threats

commit 9633a2005a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Dec 9 19:23:48 2023 +0100

    add a sql injection threat

commit bad8e04c3c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Dec 9 19:11:38 2023 +0100

    cleanup & minor refactorings

commit 3172eb69d2
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Dec 9 18:30:47 2023 +0100

    introduce RepositoryId

commit 1fe35e14a5
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Dec 9 14:53:40 2023 +0100

    mv our actor code to forgefed

commit abdf56dde1
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Dec 9 14:27:29 2023 +0100

    move forgefed to models

commit 0b2cf2a55b
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Sat Dec 9 14:26:49 2023 +0100

    remov unused experiments

commit 184388015d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 8 20:51:54 2023 +0100

    added more tests

commit b5a467e94d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 8 20:37:26 2023 +0100

    remove unused & implement webfinger

commit 73a38ea0d1
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 8 19:52:09 2023 +0100

    use new factory function

commit e8371ca94c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 8 19:43:49 2023 +0100

    ActorId -> PersonId

commit 3151c8fe81
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 8 19:41:22 2023 +0100

    make validate more compact

commit be4d3544ae
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 8 18:33:26 2023 +0100

    Refactor ActorID -> ActorId

commit 7c86f13728
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 8 18:09:22 2023 +0100

    make route more compact

commit afcc7f0def
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 8 18:08:54 2023 +0100

    factory instead of parse & validate

commit 6fef54ed1c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 8 18:08:16 2023 +0100

    there is a validation module

commit a10a9141f8
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Dec 8 15:44:00 2023 +0100

    Remove useless call to repo, add todos

commit 3c515c2614
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Dec 8 11:54:07 2023 +0100

    Add review todos

commit 22d71e6b30
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 13:53:37 2023 +0100

    Update ToDo

commit afe659f9f4
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 13:54:07 2023 +0100

    Implement 5s waiting

commit 745598bba4
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 13:24:01 2023 +0100

    Implement starring

commit 976256bf3d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 13:21:26 2023 +0100

    Refactor if conditional to switch, use split up functions

commit 75ee273f40
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 13:18:33 2023 +0100

    Split user creation and saving user to db

commit 7f4667696f
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 13:17:51 2023 +0100

    Cleanup imports

commit 6ad52a6d67
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 12:03:42 2023 +0100

    Update tests

commit 25d34e0c14
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 12:03:28 2023 +0100

    Check for empty path in IRI

commit f84e0b27e1
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 11:45:24 2023 +0100

    Use ValidateAndParseIRI, pass this to ParseActorID

commit fa1acd1ebb
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 11:44:59 2023 +0100

    Extract url string validation and parsing from ActorID parsing

commit 4d3ab4dda2
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 11:24:47 2023 +0100

    Update Validate()

commit 39d4c8dd2d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 11:24:27 2023 +0100

    Generalize validate_is_not_empty

commit 085db0c127
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 10:51:58 2023 +0100

    Remove todo

commit 54ef78034e
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 10:51:03 2023 +0100

    Don't parse received repoID

commit e3defaa212
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 10:44:35 2023 +0100

    Split getPersonByRest function

    This leaves us with two easier to read functions, encapsulating
    two different functionalities.

commit bdddde8b68
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Dec 7 10:42:05 2023 +0100

    Fix erroneous param and deprecated --name

commit 28a290da10
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Dec 6 18:32:26 2023 +0100

    reviewed current work

commit 02dc8901af
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 16:14:50 2023 +0100

    Fix tests

commit 68cd621053
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 16:14:39 2023 +0100

    Test for empty string

commit d27cac5bae
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 15:56:26 2023 +0100

    Move federated user creation to func

commit 01506f9836
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 15:50:38 2023 +0100

    Clearer description

commit 77b6402e77
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 15:37:58 2023 +0100

    Add missing error treatment

commit 946e5cf34c
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 15:37:14 2023 +0100

    Remove typo in func

commit c0f1681fa3
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 15:16:01 2023 +0100

    Allow parsing of repository-id too

commit 4f25e5057a
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 15:15:39 2023 +0100

    Make the source an argument to the parser

commit 2fb893843b
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 15:13:53 2023 +0100

    Move getting person to own function

commit 6d143e74cf
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 13:36:26 2023 +0100

    More clear distinction between sender and receiver of star

commit 52e950a492
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 13:06:30 2023 +0100

    Check the path for empty strings

commit 65f7124c67
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 12:05:47 2023 +0100

    Use u.Hostname() instead of u.Host

    u.Host returns hostname:port.

commit 27c9db1027
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Dec 6 11:24:42 2023 +0100

    Better function descriptions

commit 9b5d8bbeda
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Dec 6 09:07:09 2023 +0100

    If we use user.loginname to store the actor.id we can search for local users earlier

commit ed1af14ceb
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Dec 5 14:54:03 2023 +0100

    Panic on error, use correct function names

commit 9dcbe0177e
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Dec 5 14:53:10 2023 +0100

    Rename targe to remoteStargazer

commit de9e4dea61
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Dec 5 14:52:33 2023 +0100

    Update todos, remove comments

commit 68cc74d139
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Dec 5 14:50:46 2023 +0100

    Use actionsUser for creating http client

commit d65e5aa70e
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Dec 5 14:49:27 2023 +0100

    Move helper functions to top

commit 1c145d9d68
Author: Mirco <mirco.zachmann@meissa.de>
Date:   Tue Dec 5 12:19:22 2023 +0100

    WIP: fit generateUUIDMail for testing purposes

commit 11e93784fe
Author: Mirco <mirco.zachmann@meissa.de>
Date:   Tue Dec 5 11:46:11 2023 +0100

    WIP: log Info User created

commit a20f535211
Author: Mirco <mirco.zachmann@meissa.de>
Date:   Tue Dec 5 11:38:36 2023 +0100

    WIP: pwdgen, username

commit 85e09a7ada
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Dec 5 10:37:51 2023 +0100

    WIP: Generate User if not exists

commit 94880d64f4
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Dec 5 09:26:03 2023 +0100

    higlight the need for id normalization

commit 231bdb65b8
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Dec 1 17:06:39 2023 +0100

    searching for the local person

commit edd7fb77fd
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Dec 1 15:07:13 2023 +0100

    WIP create user if not exists

commit 159f3dc3aa
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Nov 30 17:41:08 2023 +0100

    describe the current state

commit 41e12d09ef
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Dec 1 11:56:12 2023 +0100

    WIP create User from person

commit c8456d57ff
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 30 16:10:26 2023 +0100

    Add thoughts on user creation

commit c61be31c72
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 30 16:04:26 2023 +0100

    Remove redundant person implementation

commit 22ba03ae4d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 30 16:01:20 2023 +0100

    Don't use redundant implementation of person

commit b00b5fa7af
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 30 16:00:39 2023 +0100

    Add some thoughts on repo testing

commit eab016e896
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Nov 29 09:21:54 2023 +0100

    add threat analyses

commit a8d5e7ba77
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 29 15:45:04 2023 +0100

    Fix typos and format

commit d43c4ba739
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 29 15:34:02 2023 +0100

    Use person generation

commit 9f016d3673
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 29 15:33:22 2023 +0100

    Move to extra var

commit 7071117864
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 29 15:32:15 2023 +0100

    Implement Person creation

commit fde8de4f90
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 29 13:26:35 2023 +0100

    Rename to ParseActorIDFromStarActivity

commit 2c4089ba1d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 29 13:24:59 2023 +0100

    Add star json with links to lokalhost

commit ede86df685
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 29 11:46:24 2023 +0100

    Remove todo

commit 7529b9da91
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 28 15:17:59 2023 +0100

    Note ToDos for setting up useful tests

commit e60d89cb67
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 28 15:17:34 2023 +0100

    Use correct target for get request

commit 0388240039
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 28 13:03:45 2023 +0100

    WIP Use non generated HTTP client

commit 4b490802d7
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 28 13:03:07 2023 +0100

    Test creation of client only

commit 61afc65377
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 28 10:55:53 2023 +0100

    Implement Get method on Client struct

commit 56d11bbff4
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 28 10:55:18 2023 +0100

    Don't hardcode method in NewRequest function

commit 8a53331283
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 24 14:01:32 2023 +0100

    Add ToDo

commit 93d79646de
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 24 13:56:53 2023 +0100

    Fix api url

commit 9568eab62a
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 24 13:23:03 2023 +0100

    Fix tests

commit 6284355e1e
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 24 12:51:36 2023 +0100

    Remove redundant ValidateStar and err check, call coorect function

commit 43ac3ddca9
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 24 12:50:15 2023 +0100

    Remove star validation as it happens in actor validation now

commit 566b3bc459
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 24 12:49:36 2023 +0100

    Parse Actor from star activity, Update function declaration order

commit 3a938b6c3f
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 24 12:48:14 2023 +0100

    Use and validate source in ActorID struct

commit 546ce50337
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 24 11:40:12 2023 +0100

    Use PanicIfInvalid in repository.go

commit 9566e9bc5d
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 24 11:38:01 2023 +0100

    Change tests to use IsValid method

commit fccf5c37ca
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 24 11:37:29 2023 +0100

    Add IsValid and PanicIfInvalid methods for ActorID

commit 8300d3fbde
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 24 09:55:47 2023 +0100

    Add ToDos from code review

commit 34c511ae98
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 23 17:04:58 2023 +0100

    Use data from actor, improve formatting

commit aee2ee2596
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 23 17:04:22 2023 +0100

    Also log error on person creation

commit 91baf2be32
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 23 17:03:24 2023 +0100

    Add get functions for userId and HostAndPort

commit 92c089a4e2
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 23 17:02:54 2023 +0100

    Add a test for getting host and port

commit 863b340622
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 23 17:02:36 2023 +0100

    Update dev notes with create repo curl cmd

commit 8657f70960
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 23 14:50:32 2023 +0100

    Add todo

commit 5efce01f6f
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 23 14:17:35 2023 +0100

    Make test messages consistent

commit ad8adc880f
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 22 16:40:28 2023 +0100

    Create easier to read tests for parser and validator

commit 62eae6564f
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 22 16:40:03 2023 +0100

    Fix bug in validation

commit d205c50a43
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 22 16:08:14 2023 +0100

    Implement generic validation on ActorID

commit 7b5d13a625
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 22 15:27:44 2023 +0100

    Split check for schema and host

commit 3d2b5115ad
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 22 15:25:43 2023 +0100

    Implement and use Validatable interface

commit 235ed7cd1e
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 22 13:28:13 2023 +0100

    Rename to actorID

commit 5e111f14ef
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 17 17:20:36 2023 +0100

    use the swagger-api

commit 109dbd7d75
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 17 17:20:22 2023 +0100

    swager generated api

commit 07bd30cf20
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 17 17:19:53 2023 +0100

    exosy has moved this package to service

commit 604f0a2477
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 17 17:19:08 2023 +0100

    swagger client generation

commit 9e74de829e
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 17 13:38:20 2023 +0100

    swagger client generation

commit bc1ff23b23
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 17 10:49:01 2023 +0100

    swagger client generation

commit d81647b36e
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 17 10:37:47 2023 +0100

    wip: swagger client generation

commit a954c9764f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 17 10:10:28 2023 +0100

    wip: swagger client generation

commit fbff67f11a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 17 10:10:04 2023 +0100

    add some more todos

commit 5c998a5c46
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 17 08:22:27 2023 +0100

    add comment

commit 5729cee3e5
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 16 16:04:50 2023 +0100

    Move test to model/activitypub

commit 7193c0bd9b
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 16 16:03:05 2023 +0100

    WIP test for parsing the actor

commit 0c367070af
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 16 15:06:41 2023 +0100

    Call validate star

commit b1f3706575
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 16 15:02:59 2023 +0100

    Introduce validation against source

commit 78fc75135f
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 16 15:02:20 2023 +0100

    Rename to ActorData

commit 09058c13c5
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 16 14:53:54 2023 +0100

    Rename to actor

commit 91dcd59e68
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 16 14:50:01 2023 +0100

    Import parser from model and call validation

commit 273ca49e22
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 16 14:49:05 2023 +0100

    Validate on ActorData independently and move to model

commit e44321221e
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 15 15:07:23 2023 +0100

    WIP: Add test for parser

commit ad65976677
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 15 14:27:47 2023 +0100

    Reorder functions

commit d52bb4bf8f
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 15 12:31:16 2023 +0100

    Remove newline from error string

commit b869d91dc1
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 15 12:29:17 2023 +0100

    Parse Actor URL

commit 7541251d63
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 15 12:28:26 2023 +0100

    Correct API urls

commit 9fa8d19cf4
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 15 12:10:31 2023 +0100

    Fix typo

commit d10c1094d9
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Nov 15 09:23:03 2023 +0100

    add some pseudocode

commit ab92891091
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 15 08:59:55 2023 +0100

    Use actor

commit b085ce37a6
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Wed Nov 15 08:53:02 2023 +0100

    Review

commit d7abff31f6
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 14 15:29:13 2023 +0100

    Add ToDos

commit d2b464582f
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 14 15:29:00 2023 +0100

    Add ToDo

commit e18e90f8df
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 14 15:28:38 2023 +0100

    Add fieldname and type

commit f48b4d1f55
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 14 15:27:32 2023 +0100

    Get Activity field from star

commit e8013250b8
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 14 14:56:16 2023 +0100

    Add question

commit 7790e98f47
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Tue Nov 14 14:53:47 2023 +0100

    Remove unused funcs and structs

commit 51cb9aded0
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Nov 15 09:08:17 2023 +0100

    generate ap-person client

commit 14c74f27cb
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 10 17:00:08 2023 +0100

    tests are now working

commit d28ea1a30b
Author: bom <mattis.boeckle@meissa-gmbh.de>
Date:   Fri Nov 10 16:43:44 2023 +0100

    Start implementing UnmarshalJSON for Star

commit 43014ca473
Author: bom <mattis.boeckle@meissa-gmbh.de>
Date:   Fri Nov 10 16:08:15 2023 +0100

    Implement MarshallJSON for Star activity

commit a1885a5767
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 10 15:13:26 2023 +0100

    star: test first

commit 1044e44ee5
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 10 14:51:33 2023 +0100

    we got a parsed actor

commit b08580280a
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 10 14:37:36 2023 +0100

    np in case of unauthenticated user

commit 6c1ec05458
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 10 14:37:00 2023 +0100

    extract the relevant app.ini parts

commit 460e2fb644
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 10 14:10:23 2023 +0100

    prepare next steps

commit 5b01517c12
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 10 14:26:13 2023 +0100

    Get data from form

commit e846e8225b
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Fri Nov 10 14:06:17 2023 +0100

    Update dev-notes

commit a1e9783cec
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Nov 9 21:59:51 2023 +0100

    expose star activity to swagger

commit d7dfdca8b9
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 9 15:38:55 2023 +0100

    WIP Add star to swagger

commit 17dfc7bdc1
Author: erik <erik.seiert@meissa-gmbh.de>
Date:   Thu Nov 9 14:24:19 2023 +0100

    Clearer wording, fix typos

commit 07cf963af3
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Thu Nov 9 21:54:17 2023 +0100

    expose star activity to swagger

commit dc1a82bf4c
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Wed Nov 8 08:56:22 2023 +0100

    use star as swagger model

commit 18f4c514ec
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Nov 7 18:01:52 2023 +0100

    add one more step to rebase procedure

commit 46fb4fec8f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Nov 7 09:30:32 2023 +0100

    add star activity & bind to swagger

commit ff5a4405fd
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Nov 6 18:29:48 2023 +0100

    introduce repo from exosy

commit 157effdd8f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Nov 6 18:29:24 2023 +0100

    adjust star activity example

commit a0efbf7d72
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Nov 6 09:27:41 2023 +0100

    improve git-setup-doc

commit 1f80e99857
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Nov 6 09:12:09 2023 +0100

    improve git-setup-doc

commit cde603dd0e
Author: Mirco <mirco.zachmann@meissa.de>
Date:   Fri Nov 3 17:58:47 2023 +0100

    improve git sync procedure

commit 7195141805
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Nov 6 08:50:36 2023 +0100

    wip: lets define the post input more close

commit 6587b6d62b
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Nov 6 08:49:58 2023 +0100

    log who is doing the inbox post

commit 4e1e65e14f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 3 17:45:53 2023 +0100

    log repository under activity

commit fe6f625923
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 3 17:45:21 2023 +0100

    temp deactivate security

commit b7082b7e98
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Nov 3 17:05:48 2023 +0100

    improve rebase procedure

commit 87324d1553
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 27 20:14:52 2023 +0200

    ctx action should no be good enough

commit 0d5702e501
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 27 20:13:51 2023 +0200

    fill in some minimal information to an actor

commit 6ceb1d2040
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 27 20:13:24 2023 +0200

    add f3 dep

commit 0572725204
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 27 14:33:14 2023 +0200

    add some rought branch sync description

commit fe2a3d86d4
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 27 14:10:13 2023 +0200

    get repo now works somehow

commit da7a38b03d
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 27 13:24:05 2023 +0200

    enable federation

commit 64abf87fb0
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 27 12:12:31 2023 +0200

    added some logs

commit 3dbcf34a16
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 27 11:50:39 2023 +0200

    share dev notes

commit 511ab65df4
Author: Mirco <mirco.zachmann@meissa.de>
Date:   Tue Oct 24 10:34:53 2023 +0200

    Fix syntax error, unexpected new line

commit 154be0a637
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Tue Oct 24 09:10:31 2023 +0200

    wip: compile one step further

commit 317b7fac8f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Mon Oct 23 17:16:38 2023 +0200

    wip: load repo to ctx

commit 643681663f
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 20 16:27:55 2023 +0200

    add activity sequence

commit 68318f2632
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 20 16:12:37 2023 +0200

    considerations about star activity

commit d4f507a223
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 20 15:45:12 2023 +0200

    remove unused imports

commit a87cbda165
Author: Michael Jerger <michael.jerger@meissa-gmbh.de>
Date:   Fri Oct 20 15:16:04 2023 +0200

    add repository actor
 2024-06-06 08:58:11 +02:00
Earl Warren
592469464b
test(oauth): RFC 6749 Section 10.2 conformance 
See:

1b088fade6 Prevent automatic OAuth grants for public clients
07fe5a8b13 use existing oauth grant for public client
 2024-06-05 17:50:15 +02:00
Earl Warren
32c882af91
test(oauth): coverage for the redirection of a denied grant 
See 886a675f62 Return `access_denied` error when an OAuth2 request is denied
 2024-06-05 12:51:44 +02:00
Earl Warren
c2382d4f5b Merge pull request '[gitea] week 2024-23 cherry pick (gitea/main -> forgejo)' (#3989) from earl-warren/wcp/2024-23 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3989
Reviewed-by: Otto <otto@codeberg.org>
 2024-06-04 07:40:35 +00:00
Earl Warren
bbdba70db6 Merge pull request 'fix(hook): repo admins are wrongly denied the right to force merge' (#3976) from earl-warren/forgejo:wip-admin-protection into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3976
Reviewed-by: Victoria <efertone@noreply.codeberg.org>
 2024-06-02 19:48:44 +00:00
Lunny Xiao
62448bfb93
Fix push multiple branches error with tests (#31151) 
(cherry picked from commit 5c1b550e00e9460078e00c41a32d206b260ef482)

Conflicts:
	tests/integration/git_push_test.go
	trivial context conflict because of
	2ac3dcbd43 test: hook post-receive for sha256 repos
 2024-06-02 20:39:42 +02:00
Earl Warren
166bb2861f
tests(api): POST /repos/{owner}/{repo}/push_mirrors coverage 2024-06-02 16:31:41 +02:00
metiftikci
ca0921a95a
Prevent simultaneous editing of comments and issues (#31053) 
fixes #22907

Tested:
- [x] issue content edit
- [x] issue content change tasklist
- [x] pull request content edit
- [x] pull request change tasklist

![issue-content-edit](https://github.com/go-gitea/gitea/assets/29250154/a0828889-fb96-4bc4-8600-da92e3205812)

(cherry picked from commit aa92b13164e84c26be91153b6022220ce0a27720)

Conflicts:
	models/issues/comment.go
	 c7a389f2b2 [FEAT] allow setting the update date on issues and comments

	options/locale/locale_en-US.ini
	 trivial context conflicts

	routers/api/v1/repo/issue_comment.go
	routers/api/v1/repo/issue_comment_attachment.go
	services/issue/comments.go
	services/issue/content.go
         user blocking is implemented differently in Forgejo

	routers/web/repo/issue.go
	 trivial difference from 6a0750177f Allow to save empty comment
         user blocking is implemented differently in Forgejo

	templates/repo/issue/view_content/conversation.tmpl
	 templates changed a lot in Forgejo but the change is
	 trivially ported

	tests/integration/issue_test.go
	 other tests were added in the same region

	web_src/js/features/repo-issue-edit.js
	 the code is still web_src/js/features/repo-legacy.js
	 trivially ported
 2024-06-02 16:26:54 +02:00
Lunny Xiao
a7591f9738
Rename project board -> column to make the UI less confusing (#30170) 
This PR split the `Board` into two parts. One is the struct has been
renamed to `Column` and the second we have a `Template Type`.

But to make it easier to review, this PR will not change the database
schemas, they are just renames. The database schema changes could be in
future PRs.

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: yp05327 <576951401@qq.com>
(cherry picked from commit 98751108b11dc748cc99230ca0fc1acfdf2c8929)

Conflicts:
	docs/content/administration/config-cheat-sheet.en-us.md
	docs/content/index.en-us.md
	docs/content/installation/comparison.en-us.md
	docs/content/usage/permissions.en-us.md
	non existent files

	options/locale/locale_en-US.ini
	routers/web/web.go
	templates/repo/header.tmpl
	templates/repo/settings/options.tmpl
	trivial context conflicts
 2024-06-02 09:42:39 +02:00
Earl Warren
793421bf59
tests(integration): add TestPullMergeBranchProtect 
Verify variations of branch protection that are in play when merging a
pull request as:

* instance admin
* repository admin / owner
* user with write permissions on the repository

In all cases the result is expected to be the same when merging
the pull request via:

* API
* web

Although the implementations are different.
 2024-06-01 23:50:57 +02:00
Earl Warren
e0eba21ab7
test(integration): add protected file to doBranchProtect 
A protected file pushed to a protected branch branch is not allowed.
 2024-06-01 23:50:57 +02:00
Earl Warren
0d8478b82e
test(integration): refactor doBranchProtectPRMerge 
* group test cases to clarify their purpose
* remove pull request branch protection tests, they are redundant
  with TestPullMergeBranchProtect
 2024-06-01 23:50:57 +02:00
Earl Warren
20591d966e
test(integration): refactor testPullMerge 
* split into testPullMergeForm which can be called directly if
  the caller wants to specify extra parameters.
* testPullMergeForm can expect something different than StatusOK
 2024-06-01 23:50:57 +02:00
Earl Warren
49aea9879b
test(integration): refactor doAPIMergePullRequest 
* http.StatusMethodNotAllowed can be expected: only retry if the
  error message is "Please try again later"
* split into doAPIMergePullRequestForm which can be called directly if
  the caller wants to specify extra parameters.
 2024-06-01 23:50:57 +02:00
Earl Warren
70aa294cc1
test(integration): refactor doProtectBranch 
explicitly specify the parameters instead of providing them as
arguments so the caller has a more fine grain control over them.
 2024-06-01 23:50:57 +02:00
Earl Warren
4c2ed3c35d
test(integration): add t.Helper() to reduce stack polution 
Without the a testify stack is likely to not show the relevant test.
 2024-06-01 23:50:57 +02:00
Earl Warren
f887972348 Merge pull request 'forgejo-federated-star: UI to define following repos' (#3886) from meissa/forgejo:forgejo-federated-pr5 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3886
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-05-31 15:57:17 +00:00
Earl Warren
b1e04a89be Merge pull request 'Fix localization of release/tag counters on releases page' (#3938) from 0ko/forgejo:i18n-release-page into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3938
 2024-05-29 22:06:22 +00:00
0ko
83e6b0c0c6 Fix localization of release/tag counters on releases page 2024-05-29 22:46:36 +05:00
Michael Jerger
2f7f1aab8a fix review 2024-05-29 18:31:06 +02:00
Lunny Xiao
7d7ea45465
Fix automerge will not work because of some events haven't been triggered (#30780) 
Replace #25741
Close #24445
Close #30658
Close #20646
~Depends on #30805~

Since #25741 has been rewritten totally, to make the contribution
easier, I will continue the work in this PR. Thanks @6543

---------

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit c6cf96d31d80ab79d370a6192fd761b4443daec2)

Conflicts:
	tests/integration/editor_test.go
	trivial context conflict because of 75ce1e2ac1 [GITEA] Allow user to select email for file operations in Web UI
	tests/integration/pull_merge_test.go
	trivial context conflicts in imports because more tests were added in Forgejo
 2024-05-26 19:01:36 +02:00
wxiaoguang
f6e50abd65
Fix data-race during testing (#30999) 
Fix #30992

(cherry picked from commit 47accfebbd69e5f47d1b97a3e39cf181fab7e597)

Conflicts:
	models/unit/unit.go
	trivial context conflict because of
	e07b0e75ff Add a direct link from repo header to unit settings
 2024-05-26 18:28:26 +02:00
Earl Warren
a05eb66c99
tests(web): verify compressed files are not re-compressed 
the test file used has a size below the default threshold and will
never be compressed because of that, regardless of its extension. Reduce
the threshold to 10 bytes otherwise the test is a false positive.
 2024-05-25 23:54:28 +02:00
Earl Warren
509a077ec0 Merge pull request 'mysql: faster user deletion (hook_task query) for mariadb 10' (#3865) from oliverpool/forgejo:join_delete_hook_task into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3865
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-05-24 12:44:03 +00:00
oliverpool
bb165fadf6 test: check hook_task deletion 
move test to integration to ensure Sqlite + MySQL testing
 2024-05-24 10:31:41 +02:00
Gergely Nagy
fd9ee1901b
tests: Add a test for code expansion on PRs 
This adds a new test case to `TestCompareCodeExpand` to exercise the
case where we're viewing a PR's diff.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-05-24 10:30:38 +02:00
wxiaoguang
a62a887649
Fix incorrect "blob excerpt" link when comparing files (#31013) 
When comparing files between the base repo and forked repo, the "blob
excerpt" link should point to the forked repo, because the commit
doesn't exist in base repo.

Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit f48cc501c46a2d34eb701561f01d888d689d60d5)

Conflicts:
	- templates/repo/diff/section_split.tmpl
	- templates/repo/diff/section_unified.tmpl
          Resolved the conflict by picking Gitea's change over ours, and
	  porting it.
	- tests/integration/compare_test.go
	  Kept our test, but picked the "compare all of the relevant
	  links" part of the Gitea test.
 2024-05-24 10:08:24 +02:00
Michael Jerger
b01f3bb2a1 federated-star: finalize receive activity (#3871) 
PR will finalize the ability to receive a federated star from a remote instance.

This is part of: https://codeberg.org/forgejo/forgejo/pulls/1680

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3871
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
Co-committed-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
 2024-05-24 00:25:57 +00:00
Earl Warren
d8e21e673d Merge pull request 'Creation of federated user' (#3792) from meissa/forgejo:forgejo-federated-pr3 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3792
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-05-22 11:11:42 +00:00
Clemens
1c24e2dec6 Removed test case from integration test which will be added in a later pr 2024-05-22 12:37:52 +02:00
oliverpool
c19b1cc76d test-sha256: skip push-create 
See #3783 why it is hard to support
 2024-05-21 21:24:06 +02:00
oliverpool
7e1f7f6a50 test-sha256: GitPushCreate 2024-05-21 21:24:06 +02:00
Michael Jerger
735d9629cf add more integration testcases 2024-05-21 18:49:31 +02:00
Earl Warren
74e07656d2 Merge pull request '[gitea] week 2024-21 cherry pick (gitea/main -> forgejo)' (#3838) from algernon/wcp/2024-21 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3838
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-05-21 08:05:01 +00:00
Earl Warren
fb1338537b Merge pull request '[FEAT] Wiki Search' (#3847) from snematoda/wiki-search-grep into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3847
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-05-21 06:27:30 +00:00
Mai-Lapyst
d4b1ed859c Port: Fix issue/PR title edit (gitea#30858) (#3797) 
This PR ports [gitea#30858](https://github.com/go-gitea/gitea/pull/30858) / [this commit](5c236bd4c0) to forgejo.

[week 2024-20 cherry pick](https://codeberg.org/forgejo/forgejo/pulls/3729)

## Tests
- [ ] Click "edit" to get into edit mode, change the title and then use Alt+Enter to save the title

## Screenshots

Before:
![grafik](/attachments/bb0b2562-7da0-4205-a647-3270d66f2ad7)
![grafik](/attachments/c3d05a21-659d-4616-b357-87de57232182)

After:
![grafik](/attachments/d9af6966-3282-439b-a845-76618a24b9a6)
![grafik](/attachments/5acd6684-69c4-41a4-8e27-7cb75fe3c7e4)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3797
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
Co-committed-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
 2024-05-20 23:32:48 +00:00
Léana 江
3561cc710b [I18N] Injected updated time in translation string (#3837) 
Hello,

It is more idiomatic to put the date/time before the action in Mandarin (in this context). To achieve this, instead of having the time following the string that's passed to the translating function, I added it as a parameter so that one can reference it and reorder the sentence for better translatability.

Only Traditional Chinese has been changed at the time of opening this PR, as this is more of a proof of concept and I would like to have feedbacks on whether this is a good solution or is there a better alternative.

Thank you and have a nice day :)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3837
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Léana 江 <leana.jiang+git@icloud.com>
Co-committed-by: Léana 江 <leana.jiang+git@icloud.com>
 2024-05-20 18:47:35 +00:00
Shiny Nematoda
ec4f5495ba feat: wiki search using git-grep 
+ add release note
 2024-05-20 13:48:50 +00:00
Gergely Nagy
d6915f4d5f
badges: Relax the default workflow badge conditions 
Previously, if no branch was explicitly specified for a workflow, it
defaulted to the default branch of the repo. This worked fine for
workflows that were triggered on push, but it prevented showing badges
for workflows that only run on tags, or on schedule - since they do not
run on a specific branch.

Thus, relax the conditions, and if no branch is specified, just return
the latest run of the given workflow. If one is specified, *then*
restrict it to said branch.

Fixes #3487.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-05-20 11:20:11 +02:00
Haoyuan (Bill) Xing
6cb8c81de1 Add minimal implementation for RubyGems compact index API. (#3811) 
Current package registry for RubyGems does not work with Bundler, because it implements neither the [compact index](https://guides.rubygems.org/rubygems-org-compact-index-api/) or the [dependency API](https://guides.rubygems.org/rubygems-org-api/). As a result, bundler complains about finding non-existing dependencies when installing anything with dependency: `revealed dependencies not in the API or the lockfile`.

This patch provides a minimal implementation for the compact index API to solve this issue. Specifically, we implemented a version that does not cache the results / do incremental updates; which is consistent with the current implementation.

Testing:
  * Modified existing integration tests.
  * Manually Verified bundler is able to parse the served versions / info file.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3811
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Haoyuan (Bill) Xing <me@hoppinglife.com>
Co-committed-by: Haoyuan (Bill) Xing <me@hoppinglife.com>
 2024-05-19 23:30:41 +00:00
KN4CK3R
597dcd864a
Protected tag is no internal server error (#30962) 
Fixes #30959

Adds an API test for protected tags.
Fix existing tag in combination with fixtures.

(cherry picked from commit b1d8f13bd0ecd9c576ebf2ecbd9c7dbeb3f5254f)
 2024-05-19 13:12:35 +02:00
Zettat123
8e1de85980
Support using label names when changing issue labels (#30943) 
Resolve #30917

Make the APIs for adding labels and replacing labels support both label
IDs and label names so the
[`actions/labeler`](https://github.com/actions/labeler) action can work
in Gitea.

<img width="600px"
src="https://github.com/go-gitea/gitea/assets/15528715/7835c771-f637-4c57-9ce5-e4fbf56fa0d3"
/>

(cherry picked from commit b3beaed147466739de0c24fd80206b5af8b71617)

Conflicts:
	- modules/structs/issue_label.go
	  Resolved by applying the Gitea change by hand.
	- tests/integration/api_issue_label_test.go
	  Resolved by copying the new tests.
 2024-05-19 13:12:35 +02:00
Michael Jerger
b2c3eb1644 add migration & enhance int-test 2024-05-16 18:25:16 +02:00
oliverpool
67effd6985 test-sha256: APICreateFile 2024-05-16 11:01:47 +02:00
oliverpool
df8aaeb1d5 test-sha256: APICreateBranch 2024-05-16 10:54:40 +02:00
oliverpool
348182f4b3 test-sha256: PushDeployKeyOnEmptyRepo 2024-05-16 10:54:40 +02:00
oliverpool
e3e82d02ad test: useless duplication 2024-05-16 09:56:13 +02:00
oliverpool
2ac3dcbd43 test: hook post-receive for sha256 repos 
failing push-to-create for sha256 will be fixed in a followup PR
 2024-05-15 16:27:00 +02:00
Earl Warren
77092c7a0c Merge pull request 'Federation: Parse ActorId & cache FederationHost' (#3662) from meissa/forgejo:forgejo-federated-parse-actorId into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3662
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-05-14 22:42:02 +00:00
Shiny Nematoda
b6ca8abcfd [FEAT] support searching non default branches/tags when using git-grep (#3654) 
resolves https://codeberg.org/forgejo/forgejo/pulls/3639#issuecomment-1806676 and https://codeberg.org/forgejo/forgejo/pulls/3513#issuecomment-1794990

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3654
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
 2024-05-14 15:41:03 +00:00
Earl Warren
1b3e6a4831 Merge pull request '[gitea] week 2024-20 cherry pick (gitea-github/main -> forgejo)' (#3729) from earl-warren/wcp/2024-20 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3729
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
 2024-05-14 12:23:10 +00:00
Gergely Nagy
220c3fe3b3
Expand code diffs against the commits repo 
When expanding code diffs, the expansion should search for more context
in the commits repo, rather than in the repo in context, because the
commit may not be available in the base repo. For example, when
previewing a pull request, the commit is not in the target repo yet -
it's in the fork.

Fixes #3746.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-05-14 10:25:28 +02:00
Michael Jerger
fc38e56373 enhance test & fix reviews 2024-05-14 08:24:31 +02:00
Zettat123
8f0f6bf89c
Update issue indexer after merging a PR (#30715) 
Fix #30684

(cherry picked from commit f09e68ec33262d5356779572a0b1c66e6e86590f)

Conflicts:
	tests/integration/pull_merge_test.go
	trivial context conflict
 2024-05-12 20:03:10 +02:00
Lunny Xiao
7d3ca90dfe
Fix various problems around projects board view (#30696) 
The previous implementation will start multiple POST requests from the
frontend when moving a column and another bug is moving the default
column will never be remembered in fact.

- [x] This PR will allow the default column to move to a non-first
position
- [x] And it also uses one request instead of multiple requests when
moving the columns
- [x] Use a star instead of a pin as the icon for setting the default
column action
- [x] Inserted new column will be append to the end
- [x] Fix #30701 the newly added issue will be append to the end of the
default column
- [x] Fix when deleting a column, all issues in it will be displayed
from UI but database records exist.
- [x] Add a limitation for columns in a project to 20. So the sorting
will not be overflow because it's int8.

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit a303c973e0264dab45a787c4afa200e183e0d953)

Conflicts:
	routers/web/web.go
	e91733468ef726fc9365aa4820cdd5f2ddfdaa23 Add missing database transaction for new issue (#29490) was not cherry-picked
	services/issue/issue.go
	fe6792dff3 Enable/disable owner and repo projects independently (#28805) was not cherry-picked
 2024-05-12 20:03:10 +02:00
Michael Jerger
33648f2a4c add second federated instance to integration test 2024-05-10 17:30:34 +02:00
Gergely Nagy
ac4d535dbf
templates: Be more forgiving about missing package metadata 
When rendering templates for packages, be more forgiving about missing
metadata. For some repository types - like maven - metadata is uploaded
separately. If that upload fails, or does not happen, there will be no
metadata.

In that case, Forgejo should handle it gracefully, and render as much of
the information as possible, without erroring out. Rendering without
metadata allows one to delete a partial package, while if we throw
errors, that becomes a whole lot harder.

This patch adjusts the generic metadata template, and also the maven
template. There may be more cases of the same problem lying around.

Fixes #3663.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-05-10 12:07:24 +02:00
Earl Warren
456b82d2bb Merge pull request '[PORT] gitea#29674: Add result check in TestAPIEditUser' (#3686) from algernon/forgejo:gitea/port/29674 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3686
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-05-09 18:35:29 +00:00
yp05327
f81890fa95
Add result check in TestAPIEditUser (#29674) 
Fix #29514
There are too many usage of `NewRequestWithValues`, so there's no need
to check all of them.
Just one is enough I think.

(cherry picked from commit ecd1d96f494d2400f7659165ff9376354edda395)

Conflicts:
	- tests/integration/api_admin_test.go
	  Conflict resolved by manually applying the change to
	  `full_name`.
 2024-05-09 19:26:21 +02:00
Gergely Nagy
9cb2aa989a
Teach activities.GetFeeds() how to avoid returning duplicates 
Before explaining the fix itself, lets look at the `action` table, and
how it is populated. Data is only ever inserted into it via
`activities_model.NotifyWatchers`, which will:

- Insert a row for each activity with `UserID` set to the acting user's
  ID - this is the original activity, and is always inserted if anything
  is to be inserted at all.
- It will insert a copy of each activity with the `UserID` set to the
  repo's owner, if the owner is an Organization, and isn't the acting
  user.
- It will insert a copy of each activity for every watcher of the repo,
  as long as the watcher in question has read permission to the repo
  unit the activity is about.

This means that if a repository belongs to an organizations, for most
activities, it will have at least two rows in the table. For
repositories watched by people other than their owner, an additional row
for each watcher.

These are useful duplicates, because they record which activities are
relevant for a particular user. However, for cases where we wish to see
the activities that happen around a repository, without limiting the
results to a particular user, we're *not* interested in the duplicates
stored for the watchers and the org. We only need the originals.

And this is what this change does: it introduces an additional option to
`GetFeedsOptions`: `OnlyPerformedByActor`. When this option is set,
`activities.GetFeeds()` will only return the original activities, where
the user id and the acting user id are the same. As these are *always*
inserted, we're not missing out on any activities. We're just getting
rid of the duplicates. As this is an additional `AND` condition, it can
never introduce items that would not have been included in the result
set before, it can only reduce, not extend.

These duplicates were only affecting call sites where `RequestedRepo`
was set, but `RequestedUser` and `RequestedTeam` were not. Both of those
call sites were updated to set `OnlyPerformedByActor`. As a result,
repository RSS feeds, and the `/repos/{owner}/{repo}/activities/feeds`
API end points no longer return dupes, only the original activities.

Rather than hardcoding this behaviour into `GetFeeds()` itself, I chose
to implement it as an explicit option, for the sake of clarity.

Fixes Codeberg/Community#684, and addresses gitea#20986.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-05-09 18:33:33 +02:00
Yaroslav Halchenko
2b2fd2728c Add codespell support and fix a good number of typos with its help (#3270) 
More about codespell: https://github.com/codespell-project/codespell .

I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.

```
❯ grep lint-spell Makefile
	@echo " - lint-spell                       lint spelling"
	@echo " - lint-spell-fix                   lint spelling and fix issues"
lint: lint-frontend lint-backend lint-spell
lint-fix: lint-frontend-fix lint-backend-fix lint-spell-fix
.PHONY: lint-spell
lint-spell: lint-codespell
.PHONY: lint-spell-fix
lint-spell-fix: lint-codespell-fix
❯ git grep lint- -- .forgejo/
.forgejo/workflows/testing.yml:      - run: make --always-make -j$(nproc) lint-backend checks-backend # ensure the "go-licenses" make target runs
.forgejo/workflows/testing.yml:      - run: make lint-frontend
```
so how would you like me to invoke `lint-codespell` on CI? (without that would be IMHO very suboptimal and let typos sneak in)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3270
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-committed-by: Yaroslav Halchenko <debian@onerussian.com>
 2024-05-09 13:49:37 +00:00
Earl Warren
a2c8fe0370 Merge pull request '[gitea] week 2024-19 cherry pick (gitea-github/main -> forgejo)' (#3639) from earl-warren/wcp/2024-19 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3639
Reviewed-by: Gergely Nagy <algernon@noreply.codeberg.org>
 2024-05-07 22:47:53 +00:00
Earl Warren
3f6e4af5a9 Merge pull request 'UI: Hide hidden email from own profile, again' (#3636) from n0toose/profile/hide-unhidden-hidden-email into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3636
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
 2024-05-07 10:39:01 +00:00
Michael Jerger
2177d38e9c feat(federation): validate like activities (#3494) 
First step on the way to #1680

The PR will

* accept like request on the api
* validate activity in a first level

You can find

* architecture at: https://codeberg.org/meissa/forgejo/src/branch/forgejo-federated-star/docs/unsure-where-to-put/federation-architecture.md

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3494
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
Co-committed-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
 2024-05-07 07:59:49 +00:00
0ko
b034ab5a8e [UI] Allow org members to navigate between the org and the dashboard 
- add a new button to the org view that is only shown to the org members
- add integration test to verify the expected navigatability
- add a new translation string to that button
- fix display style of "View <orgname>" button on the dashboard
- fix gap size between buttons on the org view by utilizing the common class top-right-buttons
 2024-05-05 23:14:57 +05:00
Kemal Zebari
e388822e9d
Don't only list code-enabled repositories when using repository API (#30817) 
We should be listing all repositories by default.

Fixes #28483.

(cherry picked from commit 9f0ef3621a3b63ccbe93f302a446b67dc54ad725)

Conflict:
   -		if ctx.IsSigned && ctx.Doer.IsAdmin || permission.UnitAccessMode(unit_model.TypeCode) >= perm.AccessModeRead {
   +		if ctx.IsSigned && ctx.Doer.IsAdmin || permission.HasAccess() {
   because of https://codeberg.org/forgejo/forgejo/pulls/2001
 2024-05-05 12:15:40 +01:00
yp05327
6a4bc0289d
Fix no edit history after editing issue's title and content (#30814) 
Fix #30807

reuse functions in services

(cherry picked from commit a50026e2f30897904704895362da0fb12c7e5b26)

Conflicts:
	models/issues/issue_update.go
	routers/api/v1/repo/issue.go
	trivial context conflict because of 'allow setting the update date on issues and comments'
 2024-05-05 12:15:40 +01:00
Kemal Zebari
9cd0441cd3
Catch and handle unallowed file type errors in issue attachment API (#30791) 
Before, we would just throw 500 if a user passes an attachment that is
not an allowed type. This commit catches this error and throws a 422
instead since this should be considered a validation error.

(cherry picked from commit 872caa17c0a30d95f85ab75c068d606e07bd10b3)

Conflicts:
	tests/integration/api_comment_attachment_test.go
	tests/integration/api_issue_attachment_test.go
	trivial context conflict because of 'allow setting the update date on issues and comments'
 2024-05-05 12:15:40 +01:00
wxiaoguang
4e35e5b8ae
Skip gzip for some well-known compressed file types (#30796) 
Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit be112c1fc30f87a248b30f48e891d1c8c18e8280)

Conflicts:
	routers/web/web.go
	trivial conflict because of https://codeberg.org/forgejo/forgejo/pulls/1533
 2024-05-05 12:15:40 +01:00
Panagiotis "Ivory" Vasilopoulos
d03be77665 UI: Hide hidden email from own profile, again 
This is a follow-up for 5e1bd8af5f, which
was my first commit to Gitea. It is also a follow up for the
Gitea PR #29300 (https://github.com/go-gitea/gitea/pull/23900) created
by myself, which turned stale.

This change partially restores the behavior of Gitea PR #23747
(https://github.com/go-gitea/gitea/pull/23747) by wxiaoguang, but
maintains the lock.

The original idea was to differentiate things from GitHub and GitLab a
little bit, and show the email address on the profile. The profile is
not only a place where the user chooses to show how they present
themselves on an instance, it is also a place where they can assess
their relationship *with* the instance, as it provides features such
as the Public Activity feed that can be only shown to the user, in
private.

It's, in some way, a dashboard. The email was shown there to remind
the user that this is the primary email that will be used by a supposed
administrator to contact them. There were other motivations behind that
change as well, but, long story short, the idea did not work very well,
as some people (e.g. people livestreaming on the Internet, or 'normal'
users sharing their screens) do not want to put their email address
out there when showing their screen to other people.

Other alternatives, such as blurring the text or only showing the real
email address, were explored, but were rejected because of
browser compatibility and simplicity reasons. The padlock icon that
is shown when showing the email address to other people has been kept.
One viable alternative could be displaying the placeholder email
instead, but that requires some more thought.

Fixes https://codeberg.org/forgejo/forgejo/issues/1950.
 2024-05-05 13:08:31 +02:00
silverwind
9792a377e4
Fix tautological conditions (#30735) 
As discovered by https://github.com/go-gitea/gitea/pull/30729.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit 610802df85933e7a190a705bc3f7800da87ce868)

Conflicts:
	tests/integration/git_test.go
	trivial conflict because of https://codeberg.org/forgejo/forgejo/pulls/2834
 2024-05-05 08:59:40 +01:00
6543
51b8d964c8
Get repo assignees and reviewers should ignore deactivated users (#30770) (#30782) 
Backport  #30770

If an user is deactivated, it should not be in the list of users who are
suggested to be assigned or review-requested.

old assignees or reviewers are not affected.

---
*Sponsored by Kithara Software GmbH*

(cherry picked from commit f2d8ccc5bb2df25557cc0d4d23f2cdd029358274)

Conflicts:
	models/repo/user_repo_test.go
	because there is one less fixture user compared to Gitea
 2024-05-05 08:53:27 +01:00
Chongyi Zheng
c504461b66
Resolve lint for unused parameter and unnecessary type arguments (#30750) 
Resolve all cases for `unused parameter` and `unnecessary type
arguments`

Related: #30729

---------

Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit e80466f7349164ce4cf3c07bdac30d736d20f035)

Conflicts:
	modules/markup/markdown/transform_codespan.go
	modules/setting/incoming_email.go
	routers/api/v1/admin/user_badge.go
	routers/private/hook_pre_receive.go
	tests/integration/repo_search_test.go
	resolved by discarding the change, this is linting only and
	for the sake of avoiding future conflicts
 2024-05-05 08:38:16 +01:00
Earl Warren
c9624d4cdb Merge pull request 'Add an immutable tarball link to archive download headers for Nix' (#3615) from jadeprime/forgejo:jade/nix-tarball-link into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3615
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-05-04 07:01:02 +00:00
Jade Lovelace
6631f56ebf Add an immutable tarball link to archive download headers for Nix 
This allows `nix flake metadata` and nix in general to lock a *branch*
tarball link in a manner that causes it to fetch the correct commit even
if the branch is updated with a newer version.

For further context, Nix flakes are a feature that, among other things,
allows for "inputs" that are "github:someuser/somerepo",
"https://some-tarball-service/some-tarball.tar.gz",
"sourcehut:~meow/nya" or similar. This feature allows our users to fetch
tarballs of git-based inputs to their builds rather than using git to
fetch them, saving significant download time.

There is presently no gitea or forgejo specific fetcher in Nix, and we
don't particularly wish to have one. Ideally (as a developer on a Nix
implementation myself) we could just use the generic tarball fetcher and
not add specific forgejo support, but to do so, we need additional
metadata to know which commit a given *branch* tarball represents, which
is the purpose of the Link header added here.

The result of this patch is that a Nix user can specify `inputs.something.url =
"https://forgejo-host/some/project/archive/main.tar.gz"` in flake.nix
and get a link to some concrete tarball for the actual commit in the
lock file, then when they run `nix flake update` in the future, they
will get the latest commit in that branch.

Example of it working locally:

 » nix flake metadata --refresh 'http://localhost:3000/api/v1/repos/jade/cats/archive/main.tar.gz?dir=configs/nix'
Resolved URL:  http://localhost:3000/api/v1/repos/jade/cats/archive/main.tar.gz?dir=configs/nix
Locked URL:    804ede182b.tar.gz?dir=configs
/nix&narHash=sha256-yP7KkDVfuixZzs0fsqhSETXFC0y8m6nmPLw2GrAMxKQ%3D
Description:   Computers with the nixos
Path:          /nix/store/s856c6yqghyan4v0zy6jj19ksv0q22nx-source
Revision:      804ede182b6b66469b23ea4d21eece52766b7a06
Last modified: 2024-05-02 00:48:32

For details on the header value, see:
56763ff918/doc/manual/src/protocols/tarball-fetcher.md
 2024-05-03 15:21:45 -07:00
JakobDev
d50efa626a Show repo count in blocked users tab (#3601) 
Fixes #3595

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3601
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: JakobDev <jakobdev@gmx.de>
Co-committed-by: JakobDev <jakobdev@gmx.de>
 2024-05-02 15:51:27 +00:00
Earl Warren
9bc866124b Merge pull request 'Use PostFormValue instead of PostForm.Get' (#3563) from algernon/forgejo:s/Req.PostForm.Get/Req.PostFormValue/g into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3563
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-05-02 15:48:28 +00:00
Gergely Nagy
b08aef967e
Use PostFormValue instead of PostForm.Get 
In `repo.RemoveDependency`, use `PostFormValue` instead of
`PostForm.Get`. The latter requires `ParseForm()` to be called prior,
and in this case, has no benefit over `PostFormValue` anyway (which
calls `ParseForm()` if necessary).

While this currently does not cause any issue as far as I can tell, it
feels like a bug lying in wait for the perfect opportunity. Lets squash
it before it can do harm.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-05-02 10:51:07 +02:00
Gergely Nagy
21911bfe57
Add a test case for unsubscribing from an issue 
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-05-01 11:06:38 +02:00
Gergely Nagy
8cc5d5dc78
tests: Support creating a declarative repo without AutoInit 
To be able to easily test cases where the repository does not have any
code, where the git repo itself is completely uninitialized, lets
support a case where the `AutoInit` property is false.

For the sake of backwards compatibility, if the option is not set either
way, it will default to `true`.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-05-01 11:06:38 +02:00
Earl Warren
79ffb2de47 Merge pull request '[gitea] week 2024-18 cherry pick (gitea-github/main -> forgejo)' (#3513) from earl-warren/wcp/2024-18 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3513
Reviewed-by: jean-daricade <jean-daricade@noreply.codeberg.org>
 2024-04-30 06:42:26 +00:00
Earl Warren
ce2becb55e Merge pull request 'feat: implement PKCE when acting as oauth2 client (for user login)' (#3307) from oliverpool/forgejo:pkce into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3307
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-29 10:58:17 +00:00
oliverpool
e1d93950ad feat: implement PKCE when acting as oauth2 client (for user login) 
Closes #2766
 2024-04-29 11:20:26 +02:00
Beowulf
fb5e36bc6f
Fixes that the settings button moves in the overflow menu 
and the add more button is on the right

This fix moves the settings button back to the right and the add more
button back to the left.
 2024-04-28 23:31:31 +02:00
Beowulf
c54896ba70 Show repo activities even if only code unit active or git repo is empty but issue is active (#3455) 
When all repository units are deactivated except for the code unit, the activity tab will not be shown.
Since the activities tab also shows contributing stats, it would be good to show the activities tab also when only code is active.
This commit changes the behavior when the activities tab is shown.
Previous it would only be shown when Issues, Pull-Requests or Releases are activated. Now it would additionally be shown when the code unit is activated.

Refs: #3429

| Before (Code + Issues - Owner) | Before (Code - Viewer) | After (Code + Issues - Owner) | After (Code - Viewer) |
| -- | -- | -- | -- |
| ![image](/attachments/2af997bc-1f38-48c6-bdf3-cfbd7087b220)  | ![image](/attachments/ef1797f0-5c9a-4a1a-ba82-749f3ab4f403) | ![image](/attachments/fd28a96c-04ca-407e-a70d-d28b393f223d) | ![image](/attachments/2cd0d559-a6de-4ca0-a736-29c5fea81b5a) |
|  | `/activity` returns 404 for everyone | ![image](/attachments/e0e97d8f-48cb-4c16-a505-1fafa46c4b8e)  | - |

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3455
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: Beowulf <beowulf@beocode.eu>
Co-committed-by: Beowulf <beowulf@beocode.eu>
 2024-04-28 13:47:52 +00:00
Chongyi Zheng
7517e70740
Use ProtonMail/go-crypto for opengpg in tests (#30736) 
(cherry picked from commit 8b8b48ef5fb1c5c164d5534ea4b8049f1db26ce9)

Conflicts:
	go.mod
	trivial context confllict
 2024-04-28 15:39:02 +02:00
Chongyi Zheng
781789e779
Replace deprecated math/rand functions (#30733) 
Suggested by logs in #30729

- Remove `math/rand.Seed`
`rand.Seed is deprecated: As of Go 1.20 there is no reason to call Seed
with a random value.`
- Replace `math/rand.Read`
`rand.Read is deprecated: For almost all use cases, [crypto/rand.Read]
is more appropriate.`
- Replace `math/rand` with `math/rand/v2`, which is available since Go
1.22

(cherry picked from commit 7b8e418da1e082786b844562a05864ec1177ce97)
 2024-04-28 15:39:02 +02:00
Kemal Zebari
4ed372af13
Prevent allow/reject reviews on merged/closed PRs (#30686) 
Resolves #30675.

(cherry picked from commit dd301cae1c40c9ef2805bd13af6b09a81ff4f5d7)

Conflicts:
	tests/integration/pull_review_test.go
	trivial context conflict in import
 2024-04-28 15:39:01 +02:00
Bo-Yi Wu
7b456a28d1
feat(api): enhance Actions Secrets Management API for repository (#30656) 
- Add endpoint to list repository action secrets in API routes
- Implement `ListActionsSecrets` function to retrieve action secrets
from the database
- Update Swagger documentation to include the new
`/repos/{owner}/{repo}/actions/secrets` endpoint
- Add `actions` package import and define new routes for actions,
secrets, variables, and runners in `api.go`.
- Refactor action-related API functions into `Action` struct methods in
`org/action.go` and `repo/action.go`.
- Remove `actionAPI` struct and related functions, replacing them with
`NewAction()` calls.
- Rename `variables.go` to `action.go` in `org` directory.
- Delete `runners.go` and `secrets.go` in both `org` and `repo`
directories, consolidating their content into `action.go`.
- Update copyright year and add new imports in `org/action.go`.
- Implement `API` interface in `services/actions/interface.go` for
action-related methods.
- Remove individual action-related functions and replace them with
methods on the `Action` struct in `repo/action.go`.

---------

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: appleboy <appleboy.tw@gmail.com>
(cherry picked from commit 852547d0dc70299589c7bf8d00ea462ed709b8e5)

Conflicts:
	routers/api/v1/api.go
	trivial conflict because of Fix #2512 /api/forgejo/v1/version auth check (#2582)
 2024-04-28 15:39:01 +02:00
silverwind
12b199c5e5
Enable more revive linter rules (#30608) 
Noteable additions:

- `redefines-builtin-id` forbid variable names that shadow go builtins
- `empty-lines` remove unnecessary empty lines that `gofumpt` does not
remove for some reason
- `superfluous-else` eliminate more superfluous `else` branches

Rules are also sorted alphabetically and I cleaned up various parts of
`.golangci.yml`.

(cherry picked from commit 74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2)

Conflicts:
	.golangci.yml
	apply the linter recommendations to Forgejo code as well
 2024-04-28 15:39:00 +02:00
Earl Warren
e8361b3c0e Merge pull request 'Move settings button back to the right in repo and org header' (#3462) from Beowulf/forgejo:move-repo-settings-btn-back-to-right into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3462
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-28 06:20:32 +00:00
Baptiste Daroussin
08f5a25d3b ldap: default domain name (#3414) 
When the ldap synchronizer is look for an email address and fails at
finding one, it falls back at creating one using "localhost.local"
domain.

This new field makes this domain name configurable.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3414
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Baptiste Daroussin <bapt@FreeBSD.org>
Co-committed-by: Baptiste Daroussin <bapt@FreeBSD.org>
 2024-04-26 22:38:58 +00:00
Beowulf
f9628f883d
Move settings button back to the right in repo and org header 
This will move the settings button back to the right, like known from
older versions.
For this, the overflow-menu was changed when a setting button is
available. If no settings button is available, the behavior will not
change.

Fixes #3301
 2024-04-26 23:59:08 +02:00
Earl Warren
c864448dc9 Merge pull request 'services/convert: Convert a Repository's ObjectFormatName too' (#3464) from algernon/forgejo:i-object-exclamationmark-format-name into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3464
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-26 08:27:41 +00:00
Gergely Nagy
2385f3c9db
services/convert: Convert a Repository's ObjectFormatName too 
When converting a `repo_model.Repository` to `api.Repository`, copy the
`ObjectFormatName` field too.

Fixes #3458.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-26 09:25:30 +02:00
Earl Warren
4036448c02
fix(ui): /settings/lfs/find 500 error (take 2) 
Make the test actually fails on error and not just report failure on
the output and succeed.
 2024-04-25 23:00:11 +02:00
Earl Warren
94d7523f83 Merge pull request '[BUG] save empty comments' (#3442) from oliverpool/forgejo:empty_comments into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3442
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-25 19:32:28 +00:00
Earl Warren
302daddcd1 Merge pull request 'Implement remote user login source and promotion to regular user' (#2465) from earl-warren/forgejo:wip-remote-user into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2465
 2024-04-25 15:25:05 +00:00
Earl Warren
078229a5e4
fix(ui): /settings/lfs/find 500 error 
When in the repository settings, visiting

- `LFS` to `/{owner}/{repo}/settings/lfs`
- `Find pointer files` to `/{owner}/{repo}/settings/lfs/pointers`
- `Find commits` to `/{owner}/{repo}/settings/lfs/find?oid=...`

failed with an error 500 because of an incorrect evaluation of the
template.

Regression introduced by
cbf923e87b

A test is added to visit the page and guard against future
regressions.

Refs: https://codeberg.org/forgejo/forgejo/issues/3438
 2024-04-25 16:37:12 +02:00
Earl Warren
7cabc5670d
Implement remote user login source and promotion to regular user 
A remote user (UserTypeRemoteUser) is a placeholder that can be
promoted to a regular user (UserTypeIndividual). It represents users
that exist somewhere else. Although the UserTypeRemoteUser already
exists in Forgejo, it is neither used or documented.

A new login type / source (Remote) is introduced and set to be the login type
of remote users.

Type        UserTypeRemoteUser
LogingType  Remote

The association between a remote user and its counterpart in another
environment (for instance another forge) is via the OAuth2 login
source:

LoginName   set to the unique identifier relative to the login source
LoginSource set to the identifier of the remote source

For instance when migrating from GitLab.com, a user can be created as
if it was authenticated using GitLab.com as an OAuth2 authentication
source.

When a user authenticates to Forejo from the same authentication
source and the identifier match, the remote user is promoted to a
regular user. For instance if 43 is the ID of the GitLab.com OAuth2
login source, 88 is the ID of the Remote loging source, and 48323
is the identifier of the foo user:

Type        UserTypeRemoteUser
LogingType  Remote
LoginName   48323
LoginSource 88
Email       (empty)
Name        foo

Will be promoted to the following when the user foo authenticates to
the Forgejo instance using GitLab.com as an OAuth2 provider. All users
with a LoginType of Remote and a LoginName of 48323 are examined. If
the LoginSource has a provider name that matches the provider name of
GitLab.com (usually just "gitlab"), it is a match and can be promoted.

The email is obtained via the OAuth2 provider and the user set to:

Type        UserTypeIndividual
LogingType  OAuth2
LoginName   48323
LoginSource 43
Email       foo@example.com
Name        foo

Note: the Remote login source is an indirection to the actual login
source, i.e. the provider string my be set to a login source that does
not exist yet.
 2024-04-25 13:03:49 +02:00
oliverpool
0d37f3a79b test: empty existing comment 2024-04-25 11:20:04 +02:00
Earl Warren
1e0642b086 Merge pull request 'api: The repo wiki APIs should respect WikiBranch' (#3430) from algernon/forgejo:master-of-branches into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3430
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-25 05:37:25 +00:00
Earl Warren
d0bfd3e523 Merge pull request 'tests: Refactor CreateDeclarativeRepo' (#3432) from algernon/forgejo:declaration-of-repositorytance into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3432
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-24 22:38:14 +00:00
Gergely Nagy
a1dfe07bfc
tests: Test the Wiki APIs with a non-master branch 
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-25 00:36:58 +02:00
Gergely Nagy
6d2f645363
tests: Let CreateDeclarativeRepoWithOptions create a Wiki too 
Add a new member to `DeclarativeRepoOptions`: `WikiBranch`. If
specified, create a Wiki with the given branch, and a single "Home"
page.

This will be used by an upcoming test.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-25 00:36:58 +02:00
Earl Warren
bdb729a5f2 Merge pull request 'fix(cli): admin user create first user never require a password change' (#3412) from earl-warren/forgejo:wip-cli-user-create into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3412
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
 2024-04-24 22:12:05 +00:00
Gergely Nagy
e7fcf3f189
tests: Refactor CreateDeclarativeRepo 
Lets introduce a new helper function,
`CreateDeclarativeRepoWithOptions`! This is almost the same as the
existing `CreateDeclarativeRepo` helper, but instead of taking a list of
random parameters the author thought of at the time of its introduction,
it takes a `DeclarativeRepoOptions` struct, with optional members.

This makes it easier to extend the function, as new members can be added
without breaking or having to update existing callsites, as long as the
newly added members default to compatible values.

`CreateDeclarativeRepo` is then reimplemented on top of the new
function. Callsites aren't updated yet, we can do that organically,
whenever touching code that uses the older function.

No new functionality is introduced just yet, this is merely a refactor.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-24 23:39:47 +02:00
JakobDev
1bce2dc5c5 [FEAT]Add Option to hide Release Archive links (#3139) 
This adds a new options to releases to hide the links to the automatically generated archives. This is useful, when the automatically generated Archives are broken e.g. because of Submodules.

![grafik](/attachments/5686edf6-f318-4175-8459-89c33973b181)
![grafik](/attachments/74a8bf92-2abb-47a0-876d-d41024770d0b)

Note:
This juts hides the Archives from the UI. Users can still download 5the Archive if they know t correct URL.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3139
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: JakobDev <jakobdev@gmx.de>
Co-committed-by: JakobDev <jakobdev@gmx.de>
 2024-04-24 15:15:55 +00:00
Earl Warren
b9424e634f
test(cli): admin user change-password --must-change-password 2024-04-24 15:43:27 +02:00
Earl Warren
eb74846d7d
test(cli): admin user create and must change password value 2024-04-24 15:43:24 +02:00
Earl Warren
c22110cf21 Merge pull request 'Fix user search paging' (#3379) from algernon/forgejo:paging-all-users-exclamationmark into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3379
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-22 23:12:28 +00:00
Gergely Nagy
9b85f97835
Fix user search paging 
When searching for users, page the results by default, and respect the
default paging limits.

This makes queries like '/api/v1/users/search?limit=1' actually work.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-23 00:06:05 +02:00
Earl Warren
54285319f6
fix(incoming): allow replies to comments 
- allow attachments to code comments
- incoming mails from issue comments are now identified as comments

Fixes: https://codeberg.org/forgejo/forgejo/issues/3374
 2024-04-23 00:05:12 +02:00
silverwind
3918db10c8
Run go generate and go vet on all packages (#30529) 
Fixes: https://github.com/go-gitea/gitea/issues/30512

I think this does mean those tools would run on a potential `vendor`
directory, but I'm not sure we really support vendoring of dependencies
anymore.

`release` has a `vendor` prerequisite so likely the source tarballs
contain vendor files?

(cherry picked from commit 8e12ef911a1d10dedb03e3127c42ca76f9850aca)

Conflicts:
	- Makefile
	  Manually adjusted the changes.
 2024-04-21 16:28:16 +02:00
Bo-Yi Wu
e025ec0131
feat(api): implement branch/commit comparison API (#30349) 
- Add new `Compare` struct to represent comparison between two commits
- Introduce new API endpoint `/compare/*` to get commit comparison
information
- Create new file `repo_compare.go` with the `Compare` struct definition
- Add new file `compare.go` in `routers/api/v1/repo` to handle
comparison logic
- Add new file `compare.go` in `routers/common` to define `CompareInfo`
struct
- Refactor `ParseCompareInfo` function to use `common.CompareInfo`
struct
- Update Swagger documentation to include the new API endpoint for
commit comparison
- Remove duplicate `CompareInfo` struct from
`routers/web/repo/compare.go`
- Adjust base path in Swagger template to be relative (`/api/v1`)

GitHub API
https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#compare-two-commits

---------

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
(cherry picked from commit c70e442ce4b99e2a1f1bf216afcfa1ad78d1925a)

Conflicts:
	- routers/api/v1/swagger/repo.go
	  Conflict resolved by manually adding the lines from the Gitea
	  PR.
 2024-04-21 11:58:18 +02:00
Gergely Nagy
8eba631f8d
hooks: Harden when we accept push options that change repo settings 
It is possible to change some repo settings (its visibility, and
template status) via `git push` options: `-o repo.private=true`, `-o
repo.template=true`.

Previously, there weren't sufficient permission checks on these, and
anyone who could `git push` to a repository - including via an AGit
workflow! - was able to change either of these settings. To guard
against this, the pre-receive hook will now check if either of these
options are present, and if so, will perform additional permission
checks to ensure that these can only be set by a repository owner or
an administrator. Additionally, changing these settings is disabled for
forks, even for the fork's owner.

There's still a case where the owner of a repository can change the
visibility of it, and it will not propagate to forks (it propagates to
forks when changing the visibility via the API), but that's an
inconsistency, not a security issue.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
Signed-off-by: Earl Warren <contact@earl-warren.org>
 2024-04-19 16:53:14 +02:00
0ko
67d6c674df Merge pull request 'Remove EasyMDE from various areas' (#2916) from 0ko/forgejo:easymde into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2916
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-04-19 13:48:34 +00:00
Earl Warren
6316e21be2
fix(tests): 30s to cancel processes to avoid false negatives 
on slower machines it can take more than 1 second to cancel leftover
tasks
 2024-04-18 18:47:49 +02:00
Earl Warren
d07f12e010 Merge pull request 'Do not require login_name & source_id for /admin/user/{username}' (#3278) from algernon/forgejo:leave-your-name-at-the-door into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3278
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-17 11:05:13 +00:00
Gergely Nagy
d07c8c821c
Do not require login_name & source_id for /admin/user/{username} 
When editing a user via the API, do not require setting `login_name` or
`source_id`: for local accounts, these do not matter. However, when
editing a non-local account, require *both*, as before.

Fixes #1861.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-17 10:33:52 +02:00
Earl Warren
e4aa7bd511 Merge pull request 'webhook: improve UX for sourcehut and matrix' (#3156) from oliverpool/forgejo:webhook_sourcehut_polish into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3156
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-17 06:39:54 +00:00
Gergely Nagy
ea4071ca9f Allow admins to fork repos even when creation limits are exhausted (#3277) 
This is a continuation of #2728, with a test case added.

Fixes #2633.

I kept @zareck 's commit as is, because I believe it is correct. We can't move the check to `owner.CanForkRepo()`, because `owner` is the future owner of the forked repo, and may be an organization. We need to check the admin permission of the `doer`, like in the case of repository creation.

I verified that the test fails without the `ForkRepository` change, and passes with it.

Co-authored-by: Cassio Zareck <cassiomilczareck@gmail.com>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3277
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Gergely Nagy <forgejo@gergo.csillger.hu>
Co-committed-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-17 05:52:02 +00:00
Gergely Nagy
df8e58c5cb
Allow changing global wiki editability via the API 
The global wiki editability can be set via the web UI, this patch makes
it possible to set the same thing via the API too. This is accomplished
by adjusting the GET and PATCH handlers of the
`/api/v1/repos/{owner}/{repo}` route.

The first will include the property when checking the repo's settings,
the second allows a repo admin to change the setting too.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-16 22:51:36 +02:00
oliverpool
ada8bfa52f Merge pull request 'Fix release published actions not triggering for releases created from existing tags' (#3220) from zotan/forgejo:forgejo into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3220
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-16 18:27:59 +00:00
Laura Hausmann
8506dbe2e5
Add tests for webhook release events 
Co-authored-by: oliverpool <git@olivier.pfad.fr>
 2024-04-16 19:25:26 +02:00
Earl Warren
a5a0fc7344 Merge pull request '[BUG] Escape editor.add_tmpl translation' (#3269) from gusted/forgejo-escape-tr into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3269
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-16 16:19:47 +00:00
Gusted
a0f47b8de7
[BUG] Escape editor.add_tmpl translation 
- Previously translations were escaped, but now translations are
accepted as-is and will be rendered as HTML. Use `TrString` to escape
the translation value.
- Adds integration test.
- Regression of 65248945c9.
- Resolves #3260
 2024-04-16 15:50:49 +02:00
Lunny Xiao
6495741238
Add commit status summary table to reduce query from commit status table (#30223) 
This PR adds a new table named commit status summary to reduce queries
from the commit status table. After this change, commit status summary
table will be used for the final result, commit status table will be for
details.

---------

Co-authored-by: Jason Song <i@wolfogre.com>
 2024-04-16 12:01:20 +02:00
oliverpool
99830a40a1 webhook: matrix access_token helper text 2024-04-16 08:59:56 +02:00
oliverpool
36f05e6f4e webhook: sourcehut_builds: ask for access_token instead of authorization_header 2024-04-16 08:59:55 +02:00
Gergely Nagy
5bf959a3a5
Convert the remaining interface{}s to any 
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-15 20:01:36 +02:00
0ko
089e37026f Add integration test for EasyMDE button 2024-04-15 22:59:26 +05:00
Earl Warren
51c2daec6e Merge pull request 'fix(actions): call automerge service on successful commit state' (#3231) from viceice/forgejo:fix/actions/automerge-head into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3231
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-15 16:47:23 +00:00
Michael Kriese
36f4732e6a
fix(actions): call automerge service on successful commit state 
- Backport of https://github.com/go-gitea/gitea/pull/30225
 2024-04-15 16:17:45 +02:00
Gusted
db39b8f4a7
[PORT] gitea#30430: Fix rename branch 500 when the target branch is deleted but exist in database 
Fix https://github.com/go-gitea/gitea/issues/30428

---

Conflict resolution: trivial and move test to own subtest run directly
after `Normal`.

(cherrypicked commit 9466fec879f4f2c88c7c1e7a5cffba319282ab66)
 2024-04-15 16:03:09 +02:00
Earl Warren
b833e5e7db Merge pull request '[BUG] Fix code search in explore reporting as git grep even with indexer enabled' (#3173) from snematoda/fix-grep-tmpl into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3173
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-13 08:52:08 +00:00
Shiny Nematoda
a67ca43f75 add test 2024-04-13 06:04:00 +00:00
Earl Warren
828ae39c22 Merge pull request '[BUG] Fix for PyPi Registry PEP 503 Compliance' (#3190) from Zottelchen/forgejo:bug/pep-503 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3190
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-12 22:19:51 +00:00
Zottelchen
14badb37fe Update tests/integration/api_packages_pypi_test.go 2024-04-12 21:02:42 +00:00
Gergely Nagy
65ed86e396
Fix the settings tab highlighting 
When visiting a repos `/settings/units` page, highlight the active tab
properly: "Add more..." if the tab is displayed, or "Settings"
otherwise.

Fixes #3188.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-12 19:11:21 +02:00
Gusted
0c42e3c755 Merge pull request '[CHORE] Remove println' (#3185) from gusted/forgejo-println into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3185
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-12 12:35:38 +00:00
Gusted
706846b628
[CHORE] Remove println 
- It's not recommended to use it per the documentation: https://pkg.go.dev/builtin#println.
 2024-04-12 13:36:31 +02:00
Antonin Delpeuch
592c20c7d4 Fix spelling mistakes caught by golangci-lint 2024-04-11 17:16:26 +02:00
Earl Warren
ad8a3ed2a1 Merge pull request 'Do not update PRs based on events that happened before they existed' (#2932) from earl-warren/forgejo:wip-superfluous into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2932
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
 2024-04-11 12:07:07 +00:00
Earl Warren
998a431747
Do not update PRs based on events that happened before they existed 
* Split TestPullRequest out of AddTestPullRequestTask
* A Created field is added to the Issue table
* The Created field is set to the time (with nano resolution) on creation
* Record the nano time repo_module.PushUpdateOptions is created by the hook
* The decision to update a pull request created before a commit was
  pushed is based on the time (with nano resolution) the git hook
  was run and the Created field

It ensures the following happens:

* commit C is pushed
* the git hook queues AddTestPullRequestTask for processing and returns with success
* TestPullRequest is not called yet
* a pull request P with commit C as the head is created
* TestPullRequest runs and ignores P because it was created after the commit was received

When the "created" column is NULL, no verification is done, pull
requests that were created before the column was created in the
database cannot be newer than the latest call to a git hook.

Fixes: https://codeberg.org/forgejo/forgejo/issues/2009
 2024-04-11 11:16:23 +02:00
Earl Warren
fd62033b98
[TESTS] disable test failure on log.Error for now (part 2) 
Fixes: https://codeberg.org/forgejo/forgejo/issues/3153
 2024-04-11 07:36:59 +02:00
Earl Warren
0905961fde Merge pull request '[BUG] webhook: fix admin-hooks and add more tests' (#3125) from oliverpool/forgejo:webhook_admin_fix into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3125
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-09 21:55:54 +00:00
oliverpool
8ffaa08b04 add missing defer 2024-04-09 21:14:51 +02:00
oliverpool
aba99ab8fc [TEST] cancel all processes on PrepareTestEnv 2024-04-09 21:14:51 +02:00
oliverpool
9a94019db4 webhook: add admin-hooks tests 2024-04-09 20:02:14 +02:00
oliverpool
c1f7c49804 webhook: add admin-hooks new list test 2024-04-09 20:02:14 +02:00
oliverpool
07d044a32c Makefile: test-e2e-sqlite-firefox 2024-04-09 16:50:10 +02:00
oliverpool
7d95cf6472 webhook: add org tests 2024-04-09 12:02:10 +02:00
Earl Warren
2d3705bb81 Merge pull request '[CHORE] Remove Microsoft SQL Server support' (#3040) from gusted/forgejo-rm-mssql into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3040
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-09 05:34:54 +00:00
Earl Warren
26fc7c3461 Merge pull request '[gitea] week 15 cherry pick' (#3091) from algernon/forgejo:wcp/week-15 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3091
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-09 05:31:44 +00:00
JakobDev
613e5387c5 Count downloads for tag archives 2024-04-08 12:51:27 +02:00
sillyguodong
16696a42f5
Add API for Variables (#29520) 
close #27801

---------

Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit 62b073e6f31645e446c7e8d6b5a506f61b47924e)

Conflicts:
	- modules/util/util.go
          Trivial resolution, only picking the newly introduced function
	- routers/api/v1/swagger/options.go
          Trivial resolution. We don't have UserBadges, don't pick that part.
	- templates/swagger/v1_json.tmpl
          Regenerated.
 2024-04-07 10:57:53 +02:00
Shiny Nematoda
baac15f316 [FEAT] Support Include/Exclude Filters for Grep (#3058) 
fixes `TestRepoSearch` failing occasionally

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3058
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
 2024-04-06 13:25:39 +00:00
Gusted
5691becace Merge pull request 'Fix "view file" button in diff compare view' (#3046) from Mai-Lapyst/forgejo:fix-diffcompare-viewfile-url into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3046
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-04-06 12:25:12 +00:00
Gusted
d8eebe7698 Merge pull request 'Add optional pronoun field in user settings' (#1518) from hazy/forgejo:feat/pronoun-field into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/1518
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Gergely Nagy <algernon@noreply.codeberg.org>
 2024-04-06 12:23:54 +00:00
Gusted
d5fd40821e Merge pull request 'feat: extend webfinger to respond to profile page URIs' (#2883) from realaravinth/forgejo:cb-2870 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2883
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-04-06 12:21:35 +00:00
Mai-Lapyst
ca8479c681
Update integration test 2024-04-06 11:19:32 +02:00
Earl Warren
3093f8765f Merge pull request 'Fix #3030 add Cache-Control header for health-check' (#3060) from adaaa/forgejo:cache-control-healthz into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3060
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-04-06 08:09:39 +00:00
Earl Warren
6077d10be3 Merge pull request 'feat: improve nuget nuspec api' (#2996) from viceice/forgejo:feat/nuget/nuspec-api into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2996
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-04-06 07:48:31 +00:00
Earl Warren
a015ada29a Merge pull request '[BUG] fix webhook creation payload ref' (#3055) from oliverpool/forgejo:webhook_fix_create_payload_ref into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3055
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-06 07:25:20 +00:00
Ada
323d7ad507
Remove useless t.run 2024-04-06 00:43:22 +02:00
Ada
84f5115bd1
Add health-check test 2024-04-06 00:34:55 +02:00
Michael Kriese
bc72fd7f46
feat: improve nuget nuspec api 2024-04-05 23:39:45 +02:00
Gusted
2d9afd0c21
[CHORE] Remove Microsoft SQL Server Support 
- Per https://codeberg.org/forgejo/discussions/issues/122
 2024-04-05 23:37:36 +02:00
Earl Warren
8205ed9495 Merge pull request '[FEAT] sourcehut webhooks' (#3022) from oliverpool/forgejo:webhook_7_sourcehut into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3022
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
 2024-04-05 19:23:54 +00:00
oliverpool
9d2919248b [TEST] webhook creation payload ref 2024-04-05 16:21:41 +02:00
oliverpool
ed9dd0e62a [FEAT] sourcehut webhooks 2024-04-05 10:20:40 +02:00
Mai-Lapyst
06478da63b
Add integration test 2024-04-05 08:25:24 +02:00
Earl Warren
4ccb8c8b1f Merge pull request '[FEAT] Add label filters in organization issues dashboard' (#2944) from iminfinity/forgejo:add/label-filters into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2944
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-04-04 16:58:12 +00:00
Aravinth Manivannan
855d75d0bc fix: respond with 404 when webfingered with non-actor URIs 2024-04-04 16:52:25 +00:00
Aravinth Manivannan
1cc6ed8fb6 chore: add trailing slash query test case for webfinger endpoint 2024-04-04 16:52:25 +00:00
Aravinth Manivannan
fc31f14507 feat: extend webfinger to respond to profile page URIs 2024-04-04 16:52:25 +00:00
Gusted
b0cd0ebb91
[BUG] Fix crash in issue forms 
- Fix a crash in the issue forms, because `ctx.Ctx` was trying to be
accessed, however this is not set in all contexts thus could result to NPE.
- Adds integration test.
- Resolves #3011
 2024-04-04 15:54:06 +02:00
iminfinity
8d13ed4a8d add label filters in org/{org_name}/issues 2024-04-04 17:57:11 +05:30
hazycora
2bed909a17
use EqualValues in test of pronouns not being displayed when unspecified 2024-04-03 15:24:23 -05:00
Gergely Nagy
9bb7b3fbdd
Add a new test for "Unspecified" pronouns 
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-03 15:18:54 -05:00
hazycora
152f26f05b
remove unused assignment 2024-04-03 15:18:53 -05:00
Gergely Nagy
276bf850c9
Add tests for the Pronouns field 
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-04-03 15:18:53 -05:00
Earl Warren
efd0f0f224 Merge pull request 'Port archived labels visual filter' (#2887) from 0ko/forgejo:lable-archive-bw into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2887
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-03 20:06:39 +00:00
Earl Warren
c360b630e3 Merge pull request '[FEAT] Allow non-explicit push options' (#2984) from gusted/forgejo-push-options into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2984
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
 2024-04-03 19:00:16 +00:00
Gusted
f5ad6d4be5
[FEAT] Allow non-explicit push options 
- Currently the parsing of the push options require that `=` is present
in the value, however we shouldn't be that strict and assume if that's
not set the value is `true`.
- This allow for more natural commands, so become `-o force-push=true`
simply `-o force-push`.
- Add unit test.
 2024-04-03 20:11:49 +02:00
Gusted
8df9100994
[BUG] Disable 'View at this point in history' for wikis 
- Don't show the 'View at this point in history' button for wikis as
wikis don't have this feature.
- Adds integration test
- Resolves https://codeberg.org/forgejo/forgejo/issues/2995
 2024-04-03 16:00:36 +02:00
0ko
2f38c2220f [I18N] Allow custom repo size format 
Following https://codeberg.org/forgejo/forgejo/pulls/2528#issuecomment-1721846

- simplify the code
- allow to have custom format in translations
- provide proper Russian translation because test depends on it
 2024-04-02 18:43:12 +05:00
Aravinth Manivannan
2c2f146895
fix: respond with JSON Resource Descriptor Content-Type per RFC7033 2024-04-02 14:11:47 +05:30
Earl Warren
385bcca788 Merge pull request 'Data size unit localization' (#2528) from 0ko/forgejo:sizelocalize into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2528
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-04-01 19:31:26 +00:00
Earl Warren
ec091b59af Merge pull request '[FEAT] Configure if protected branch rule should apply to admins' (#2867) from gusted/forgejo-protectedbranch-admins into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2867
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-04-01 19:28:29 +00:00
0ko
53dc9f3393 Add integration test for (non-)archived label properties 2024-04-01 21:38:34 +05:00
Earl Warren
b9a1d5c2be Merge pull request 'Highlight signed tags like signed commits' (#2534) from algernon/forgejo:message-in-a-bottle-ctrl-w-tag into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2534
 2024-04-01 13:38:55 +00:00
0ko
c2d137d1f2 Rename ByteSize to ReadableSize 2024-03-31 20:17:12 +05:00
Earl Warren
99842e9ff5 Merge pull request '[TESTS] prevent overriding testlogger when calling mainApp' (#2846) from oliverpool/forgejo:non_failing_test into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2846
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-31 13:50:20 +00:00
oliverpool
6b857193ff [TESTS] pull review deleted from gitea#29888 
Instead of db.TruncateBeans(db.DefaultContext, &issues_model.Review{}), reviews are deleted using issue.DeleteReview
 2024-03-31 13:53:47 +02:00
oliverpool
bd97bd875d [TESTS] deliver webhooks on localhost 2024-03-31 10:34:37 +02:00
Gergely Nagy
bc080070ed
An integration test for SSH signed tags 
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-03-30 20:14:42 +01:00
0ko
bba1884582 Add integration test for TrSize 2024-03-30 21:10:47 +05:00
wxiaoguang
ea4755be6d
Relax generic package filename restrictions (#30135) 
Now, the chars `=:;()[]{}~!@#$%^ &` are possible as well
Fixes #30134

---------

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
(cherry picked from commit 1ad48f781eb0681561b083b49dfeff84ba51f2fe)
 2024-03-30 07:17:31 +01:00
crazeteam
3aa6f17e1e
Remove repetitive words (#30091) 
remove repetitive words

Signed-off-by: crazeteam <lilujing@outlook.com>
(cherry picked from commit ecbc9cee2b69cd9707acb1e23ccbca048484c460)
 2024-03-30 07:17:30 +01:00
Lunny Xiao
3ba127c618
[Port] gitea#29999: Fix Add/Remove WIP on pull request title failure 
Fix #29997

---

Conflict resolution:
- Use Forgejo's user blocking feature (services/issue/issue.go)
- Trivial (tests/integration/pull_review_test.go)
Ref: https://codeberg.org/forgejo/forgejo/pulls/2872
(cherry picked from commit 475b6e839caa88994318f905f0965c3b418f876a)
 2024-03-29 12:21:51 +01:00
Gusted
79b7089360
[FEAT] Configure if protected branch rule should apply to admins 
- Currently protected branch rules do not apply to admins, however in
some cases (like in the case of Forgejo project) you might also want to
apply these rules to admins to avoid accidental merges.
- Add new option to configure this on a per-rule basis.
- Adds integration tests.
- Resolves #65
 2024-03-29 00:21:49 +01:00
Earl Warren
6bf6a473cf Merge pull request '[BUG] Do not allow deletion of internal references' (#2834) from gusted/forgejo-internal-reference into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2834
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-28 16:53:53 +00:00
Earl Warren
340aa1960e Merge pull request '[Port] gitea#29842: Notify reviewers added via CODEOWNERS' (#2855) from gusted/forgejo-port-29842 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2855
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-28 16:40:17 +00:00
silverwind
1ee494a045
[Port] gitea#29982 Introduce .secondary-nav and handle .page-content spacing universally 
Fixes: https://github.com/go-gitea/gitea/issues/29981. Introduce
`.secondary-nav` as a universal way for styling and margin adjustments
inside `.page-content`.

If the first child of `.page-content` is `.secondary-nav`, we add margin
below it, otherwise we add padding to the first child. Notable changes:

- `--color-header-wrapper` is replaced with `--color-secondary-nav-bg`.
- `navbar` class is removed.

Co-authored-by: Giteabot <teabot@gitea.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

---

Conflict resolution: Trivial conflict & changed selector to reflect new
classes.
Ref: https://codeberg.org/forgejo/forgejo/issues/2776
(cherry picked from commit 3ccda41a539b8ba7841919ee12dc2877ddc03818)
 2024-03-28 16:43:09 +01:00
Jimmy Praet
003881b06d
[Port] gitea#29842: Notify reviewers added via CODEOWNERS 
Fixes https://github.com/go-gitea/gitea/issues/28297

This PR also fixed a problem that it needs a database transaction when
removing the WIP title.

---

Resolves #2771
Also partially ports gitea#29783

(cherry picked from commit 17d7ab5ad4ce3d0fbc1251572c22687c237a30b1)
 2024-03-28 14:58:39 +01:00
Earl Warren
26f6a3b578 Merge pull request 'Revert "avoid superfluous synchronized pull_request run when opening a PR"' (#2848) from earl-warren/forgejo:wip-revert-bad-race-fix into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2848
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
 2024-03-28 10:38:55 +00:00
Earl Warren
327deee2d7 Merge pull request '[PORT] Support repo code search without setting up an indexer (gitea#29998)' (#2813) from snematoda/port-git-grep into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2813
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-28 08:15:47 +00:00
Earl Warren
ceea9c4334
Revert "avoid superfluous synchronized pull_request run when opening a PR" 
The fix against the race incorrectly assumes the sha of the commit being
pushed belongs to the base repository. It finds the highest possible
pull request ID from the head repository instead of looking it up in
the base repository.

Figuring out if a PR was created in the future based on the highest
index of the base repository would require collecting all of them
because there is no way to know in advance which repository may be
involved in the race.

Fixing this race can be done either by:

* Introducing a new field in the pull_request table https://codeberg.org/forgejo/forgejo/pulls/2842
  which feels more like a hack than a real solution
* Refactoring the logic
  which would be a significant undertaking

The race has been in the codebase for a very long time and manifests
itself in the CI, when events happen in quick succession. The only
concrete manifestation was however fixed by https://codeberg.org/forgejo/forgejo/issues/2009

Since this race now only exists in theory and not in practice, let's
revert this bugous commit until a proper solution is implemented.

Fixes: https://codeberg.org/forgejo/forgejo/issues/2817

This reverts commit 036f1eddc5.

Conflicts:
	services/pull/pull.go
 2024-03-28 07:08:17 +01:00
Shiny Nematoda
488a99fb56 Reverts commits releated to git-grep 
This reverts commit
	51fb6f3983
	71a72d8a22
 2024-03-28 05:09:41 +00:00
oliverpool
5785ae72c7 [TESTS] prevent overriding testlogger when calling mainApp 2024-03-27 22:54:13 +01:00
oliverpool
c0dd92e9c5 [REFACTOR] webhook move edit endpoints 2024-03-27 22:26:55 +01:00
oliverpool
635230ca5d [TESTS] webhook forms keep submitted data when invalid 2024-03-27 22:26:55 +01:00
Gusted
9d82059840
[BUG] Do not allow deletion of internal references 
- Currently it's possible to modify remote references such as
`refs/pull/<idx>/head` and `refs/heads/<branch>`.
- Disallow that the pull request reference is deleted, as this should
not be at the control of the user. Doing so would result in
inconsistencies within Forgejo and lead to internal server errors when
trying access the pull request, this action should be reserved for
Forgejo.
- Do this by utilizing the `update` hook, which process each reference
individually and therefore allow to only skip deleting internal
references and still allow other modifications that is being done in
the same push.
- Ref: https://codeberg.org/Codeberg/Community/issues/1517
 2024-03-27 18:27:00 +01:00
oliverpool
8dfbbfef07 [REFACTOR] webhook matrix endpoints 2024-03-27 15:38:38 +01:00
Earl Warren
e41e18f87e Merge pull request '[REFACTOR] webhook.Handler interface' (#2758) from oliverpool/forgejo:webhook_2_interface into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2758
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-27 13:45:04 +00:00
Earl Warren
ac672fc3ff Merge pull request '[ACTIONS] port scheduled actions from Gitea' (#2826) from earl-warren/forgejo:wip-gitea-schedule into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2826
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-03-27 06:23:56 +00:00
6543
ab5f0b7558
Determine fuzziness of bleve indexer by keyword length (#29706) 
also bleve did match on fuzzy search and the other way around. this also fix that bug.

(cherry picked from commit b9c57fb78e8e0d80d786d8e1da433b6c7ebf2f1c)

Conflicts:
	tests/integration/repo_search_test.go
	simple conflict resolution in the tests
 2024-03-26 19:04:27 +01:00
silverwind
3ea7437fa6
Fix incorrect tailwind migration (#30007) 
Fixes https://github.com/go-gitea/gitea/issues/30005. Regression from
https://github.com/go-gitea/gitea/pull/29945.

There was only once instance of `tw-content-center` before that PR, so I
just ran below command and reverted that one instance.

```sh
perl -p -i -e 's#tw-content-center#tw-items-center#g' web_src/js/**/* templates/**/* models/**/* tests/**/*
```

(cherry picked from commit 04f9ad056882fc3f21b247b16f84437adf0f36d8)

Conflicts:
	templates/repo/diff/conversation.tmpl
	templates/repo/header.tmpl
	templates/repo/issue/filter_list.tmpl
	templates/repo/issue/view_content/conversation.tmpl
	templates/repo/wiki/view.tmpl
	web_src/js/components/DashboardRepoList.vue
	re-ran the command after discarding the Gitea changes to
	ensure all Forgejo files are also covered
 2024-03-26 19:04:27 +01:00
silverwind
2befd9a3cf
Replace 10 more gt- classes with tw- (#29945) 
Likely the biggest change of the tailwind refactors. Only thing of note
is that `tw-flex-1` resolves to `flex: 1 1 0%` while our `gt-f1` was
`flex: 1 1 0`, I don't think it will make any difference. Commands I've
ran:

```sh
perl -p -i -e 's#gt-vm#tw-align-middle#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-fw#tw-flex-wrap#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-f1#tw-flex-1#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-fc#tw-flex-col#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-sb#tw-justify-between#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-je#tw-justify-end#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-jc#tw-justify-center#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-ac#tw-content-center#g' web_src/js/**/* templates/**/* models/**/* tests/**/*
perl -p -i -e 's#gt-df#tw-flex#g' web_src/js/**/* templates/**/* models/**/* tests/**/*
perl -p -i -e 's#gt-dib#tw-inline-block#g' web_src/js/**/* templates/**/* models/**/* tests/**/*

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit f88ad5424f381bf2a45fd863b551c5a72891bb68)

Conflicts:
	templates/repo/diff/conversation.tmpl
	templates/repo/header.tmpl
	templates/repo/issue/filter_actions.tmpl
	templates/repo/issue/filter_list.tmpl
	templates/repo/issue/view_content/conversation.tmpl
	templates/repo/release/list.tmpl
	templates/repo/wiki/view.tmpl
	web_src/js/components/DashboardRepoList.vue
	discard the proposed changes and prefer Forgejo. A followup
	commit will apply the same commands.
 2024-03-26 19:04:27 +01:00
Lunny Xiao
d92c2048b3
Performance improvements for pull request list page (#29900) 
This PR will avoid load pullrequest.Issue twice in pull request list
page. It will reduce x times database queries for those WIP pull
requests.

Partially fix #29585

---------

Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit 62f8174aa2fae1481c7e17a6afcb731a5b178cd0)

Conflicts:
	models/activities/notification_list.go
	moved to models/activities/notification.go
 2024-03-26 19:04:26 +01:00
Earl Warren
4061cb32f7
Remove unnecessary ".Link" usages (#29909) (part 2) 
5143ebb507 Add rel="nofollow" to issue filter links

has a test that fails because it assumes the link starts with the link
where it now starts with a ?
 2024-03-26 19:04:26 +01:00
wxiaoguang
c758c5612e
Remove unnecessary ".Link" usages (#29909) 
In HTML, `?key=val` already means "use the current link with new query parameters"

(cherry picked from commit 4c476fa41dc29dc24afda0925023ae3d0b9707cd)

Conflicts:
	templates/repo/issue/filter_list.tmpl
	templates/shared/issuelist.tmpl
	trivial context conflict because the lines in Forgejo have rel=nofollow
 2024-03-26 19:04:26 +01:00
Jason Song
18e95af24f
Restore deleted branches when syncing (#29898) 
Regression of #29493. If a branch has been deleted, repushing it won't
restore it.

Lunny may have noticed that, but I didn't delve into the comment then
overlooked it:
https://github.com/go-gitea/gitea/pull/29493#discussion_r1509046867

The additional comments added are to explain the issue I found during
testing, which are unrelated to the fixes.

(cherry picked from commit f371f84fa3456c2a71470632b6458d81e4892a54)
 2024-03-26 19:04:25 +01:00
yp05327
e8e8d14b53
Fix invalid link of the commit status when ref is tag (#29752) 
Fix #29731
Caused by #24634
Also remove fixme.

ps: we can not fix the existed runs, as wrong refs are all recorded in
DB, and we can not know whether they are branch or tag:

![image](https://github.com/go-gitea/gitea/assets/18380374/cb7cf266-f73f-419a-be1a-4689fdd1952a)

(cherry picked from commit 98217b034076157547cf688cc10f47cd3275c872)

Conflicts:
	tests/integration/actions_trigger_test.go
	there is a need for more imports because the exist tests
	are done differently, using CreateDeclarativeRepo
 2024-03-26 19:04:25 +01:00
Earl Warren
a117dfd2b1
[ACTIONS] port scheduled actions from Gitea 
Refs: https://codeberg.org/forgejo/forgejo/issues/2798
 2024-03-26 16:51:56 +01:00
Gusted
0f79122053
[BUG] Detect protected branch on branch rename 
- If a branch cannot be renamed due to a protected branch rule, show
this error in the UI instead of throwing an internal server error.
- Add integration test (also simplify the existing one).
- Resolves #2751
 2024-03-26 15:58:52 +01:00
Earl Warren
9397bfd276 Merge pull request 'Offer to remove WIP: prefix in sidebar' (#2660) from 0ko/forgejo:convert-to-normal into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2660
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-25 10:30:11 +00:00
oliverpool
702152bfde [REFACTOR] webhook.Handler interface 2024-03-24 10:35:06 +01:00
Earl Warren
5a18b74632 Merge pull request '[TESTS] fail when log.Error is called' (#2657) from oliverpool/forgejo:fail_test_on_log_error into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2657
 2024-03-24 07:28:31 +00:00
oliverpool
7b576d0a5d activitypub: warn instead of error 2024-03-24 07:12:31 +01:00
oliverpool
2536c2db89 fix webhook fixtures 2024-03-24 07:11:19 +01:00
oliverpool
e43c6cd9df fail test when log.Error is called 
except for some specific messages (to make the test pass for now)
 2024-03-24 07:11:18 +01:00
Earl Warren
0bfd4ca532 Merge pull request 'Allow users to hide all "Add more units..." hints' (#2533) from algernon/forgejo:less-is-more into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2533
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-24 05:42:37 +00:00
oliverpool
33a3ee1955 [TESTS] webhook forms creation and edition 2024-03-23 23:02:06 +01:00
Gergely Nagy
87cd08539e
Update the TestRenderAlertBlocks integration test 
The alert/callout blocks rendering has been changed in the previous few
commits, this adapts the test case that verifies them to the updated
output.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-03-23 15:38:43 +01:00
Gergely Nagy
6c330a85ec
Add tests for the "Open with" repository clone menu 
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-03-23 11:58:54 +01:00
Gergely Nagy
3123725ff3
Revert "[GITEA] Configurable clone methods" 
This reverts commit 1d8bca07f3.
 2024-03-23 11:58:54 +01:00
0ko
60a9df1908
Add test for pull summary 2024-03-22 07:11:52 +01:00
0ko
8e1b6a4090 Add test for add/remove WIP link display 2024-03-21 19:33:02 +05:00
Gergely Nagy
36147f580c
Allow users to hide all "Add more units..." hints 
Repositories displaying an "Add more..." tab on the header is a neat way
to let people discover they can enable more units. However, displaying
it all the time for repository owners, even when they deliberately do
not want to enable more units gets noisy very fast.

As such, this patch introduces a new setting which lets people disable
this hint under the appearance settings.

Fixes #2378.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-03-21 08:15:51 +01:00
Gergely Nagy
8433f3aa09
Fix repo badges when the label or text contains dashes 
shields.io uses dashes to separate parts of the badge it needs to
return. If our label or text parts contain dashes, we need to encode
those for shields.io to recognise what we want it to do, and to have the
correct text on the badge, too.

Fortunately, this is as simple as replacing all dashes with double
dashes in both the label and the text parts. We do not need to do the
same for the color, because that part is not user controlled.

This fixes the badges for cases when a workflow name includes dashes, or
when a release's tag name does.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-03-20 22:41:20 +01:00
Earl Warren
84f33ead4e Merge pull request '[BUG] Reflect Cargo index state in settings' (#2698) from gusted/forgejo-cargo-index into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2698
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-20 11:38:26 +00:00
Earl Warren
468b879fe8 Merge pull request '[PORT] add skip ci support for pull request title (#29774)' (#2701) from earl-warren/forgejo:wip-gitea-skip-ci into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2701
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
 2024-03-20 11:34:49 +00:00
Gusted
461f925554
[BUG] Reflect Cargo index state in settings 
- Currently in the Cargo section of the packages setting menu two
buttons are always shown, "Initalize index" and "Rebuild index", however
only of these should be shown depending on the state of the index, if
there's no index the "Initalize index" button should be shown and if
there's an index the "Rebuild index" button should be shown. This patch
does exactly that.
- Resolves #2628
 2024-03-20 09:17:49 +01:00
norohind
d74f74a025
Fix PR creation via api between branches of same repo with head field namespaced (#26986) 
Fix #20175

Current implementation of API does not allow creating pull requests
between branches of the same
repo when you specify *namespace* (owner of the repo) in `head` field in
http request body.

---

Although GitHub implementation of API allows performing such action and
since Gitea targeting
compatibility with GitHub API I see it as an appropriate change.

I'm proposing a fix to the described problem and test case which covers
this logic.

My use-case just in case:
https://github.com/go-gitea/gitea/issues/20175#issuecomment-1711283022

(cherry picked from commit ed02d1fab85c9b8206c0af84dcfc3792e61609cf)
 2024-03-20 08:46:30 +01:00
Yarden Shoham
24305e4d09
Remove the time-since class (#29826) 
It serves no purpose.

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit 3f1e4896b6d71dc061e23fa2dcac4c1b7d412540)
 2024-03-20 08:46:30 +01:00
yp05327
2da0628f18
Fix incorrect menu/link on webhook edit page (#29709) 
Fix #29699

---------

Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit 2da13675c0cfdc531044553636c3b74f2fda3eb4)
 2024-03-20 08:46:29 +01:00
Zettat123
2559c80bec
Add a warning for disallowed email domains (#29658) 
Resolve #29660

Follow #29522 and #29609

Add a warning for disallowed email domains when admins manually add/edit
users.

Thanks @yp05327 for the
[comment](https://github.com/go-gitea/gitea/pull/29605#issuecomment-1980105119)

![image](https://github.com/go-gitea/gitea/assets/15528715/6737b221-a3a2-4180-9ef8-b846c10f96e0)

(cherry picked from commit 4129e0e79bbf30e4297efd33feb2602c40322d10)
 2024-03-20 08:46:28 +01:00
Earl Warren
19d7ff9c9e
[TESTS] testPullCreate do not assume the default branch is master 2024-03-20 06:52:37 +01:00
Denys Konovalov
d3d0c4cbe7
add skip ci support for pull request title (#29774) 
Extends #28075 to support [skip ci] inside PR titles.

Close #29265

(cherry picked from commit 7a90e5954f8515329f20ff0e391130e1ee7b8864)

Conflicts:
	services/actions/notifier_helper.go
	tests/integration/actions_trigger_test.go
	conflicts easily resolved because of
	[TESTS] Convert more tests to CreateDeclarativeRepo
	[ACTIONS] skip superflous pull request synchronized event (#2314)
 2024-03-20 06:07:50 +01:00
oliverpool
ce6db31efe Merge pull request '[Port] Sync branches to DB immediately when handle git hook calling gitea#29493' (#2684) from oliverpool/forgejo:sync_branch into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2684
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-03-19 08:37:30 +00:00
Earl Warren
c16866d4a5 Merge pull request 'English fixes and improvements' (#2631) from 0ko/forgejo:english20240311 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2631
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-03-19 08:09:27 +00:00
Ada
41676a8634 Fix #2512 /api/forgejo/v1/version auth check (#2582) 
Add the same auth check and middlewares as the /v1/ API.
It require to export some variable from /v1 API, i am not sure if is the correct way to do

Co-authored-by: oliverpool <git@olivier.pfad.fr>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2582
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Ada <ada@gnous.eu>
Co-committed-by: Ada <ada@gnous.eu>
 2024-03-19 07:16:19 +00:00
Jason Song
286d09203f Sync branches to DB immediately when handle git hook calling (gitea#29493) 
Unlike other async processing in the queue, we should sync branches to
the DB immediately when handling git hook calling. If it fails, users
can see the error message in the output of the git command.

It can avoid potential inconsistency issues, and help #29494.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2024-03-18 17:38:01 +01:00
0ko
4c1af0d9a6 [I18N] Fix capitalization in English and reword a few strings 
fixes #2551
 2024-03-17 21:04:11 +05:00
oliverpool
98f1fe7944 Makefile: check git diff exit-code (#2651) 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2651
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-03-14 10:38:58 +00:00
Gusted
fbdda5d5b0 Merge pull request '[PORT] Test /user/settings/security auth sources' (#2641) from oliverpool/forgejo:security_test into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2641
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-03-13 21:57:14 +00:00
Earl Warren
226fa396df Merge pull request 'Accessibility: Taborder in repo explore' (#2636) from fnetx/explore-taborder into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2636
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-13 02:31:47 +00:00
oliverpool
d49c116ce5 [PORT] Test /user/settings/security auth sources 2024-03-12 15:41:10 +01:00
Otto Richter
16a63a16b3 Playwright e2e test for taborder 
This should be a failing test for Firefox (but working in Chrome?) for
the taborder in the explore page.

Tabbing through the page should ensure that certain elements are focused
at least once.
 2024-03-12 02:23:29 +01:00
oliverpool
63973e2c70
add repo_settings_hook_test 2024-03-11 23:37:00 +07:00
wxiaoguang
abb0294996
Partially enable MSSQL case-sensitive collation support (#29238) 
Follow #28662

(cherry picked from commit 29a8c8de779924694fadad80b31cc855dd62c0f2)
 2024-03-11 23:36:59 +07:00
Zettat123
e7afba21ce
Skip email domain check when admins edit user emails (#29609) 
Follow #29522

Administrators should be able to set a user's email address even if the
email address is not in `EMAIL_DOMAIN_ALLOWLIST`

(cherry picked from commit 136dd99e86eea9c8bfe61b972a12b395655171e8)
 2024-03-11 23:36:58 +07:00
Zettat123
b6057a34db
Skip email domain check when admin users adds user manually (#29522) 
Fix #27457

Administrators should be able to manually create any user even if the
user's email address is not in `EMAIL_DOMAIN_ALLOWLIST`.

(cherry picked from commit 4fd9c56ed09b31e2f6164a5f534a31c6624d0478)
 2024-03-11 23:36:58 +07:00
Gusted
4dbf2d7c11 Merge pull request 'Better number for UserCards pagination' (#2584) from 0ko/forgejo:its39 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2584
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
 2024-03-11 15:53:59 +00:00
0ko
b2bc233517 Test pagination of repo stars, watchers and forks 
based on code suggested in https://codeberg.org/forgejo/forgejo/pulls/2584#issuecomment-1647897 and https://codeberg.org/forgejo/forgejo/pulls/2584#issuecomment-1655289

Co-authored-by: Gusted <gusted@noreply.codeberg.org>
 2024-03-10 17:15:59 +05:00
0ko
8f8b608fd7 Add test to UI of archive/unarchive related actions 2024-03-09 13:29:23 +00:00
oliverpool
ecfcbcb19f [BUG] prevent removing session cookie when redirect_uri query contains :// 2024-03-07 10:52:30 +01:00
Gusted
b9e27b64e6 Merge pull request '[BUG] Disable CODEOWNERS for forked repositories' (#2537) from gusted/forgejo-codeowner-forked into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2537
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-06 18:18:58 +00:00
Gusted
e793e28f94
[BUG] Remember topic only in repo search 
- Ports b4360d504c
 2024-03-06 13:22:39 +01:00
Earl Warren
a39f69ac28
Revert "[BUG] Remember topic only in repo search" 
This reverts commit b4360d504c.
 2024-03-06 12:10:46 +08:00
KN4CK3R
47a913d40d
Add support for API blob upload of release attachments (#29507) 
Fixes #29502

Our endpoint is not Github compatible.

https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28#upload-a-release-asset

---------

Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit 70c126e6184872a6ac63cae2f327fc745b25d1d7)
 2024-03-06 12:10:46 +08:00
ChristopherHX
66632c4958
Actions Artifacts v4 backend (#28965) 
Fixes #28853

Needs both https://gitea.com/gitea/act_runner/pulls/473 and
https://gitea.com/gitea/act_runner/pulls/471 on the runner side and
patched `actions/upload-artifact@v4` / `actions/download-artifact@v4`,
like `christopherhx/gitea-upload-artifact@v4` and
`christopherhx/gitea-download-artifact@v4`, to not return errors due to
GHES not beeing supported yet.

(cherry picked from commit a53d268aca87a281aadc2246541f8749eddcebed)
 2024-03-06 12:10:45 +08:00
wxiaoguang
459ee98136
Only use supported sort order for "explore/users" page (#29430) 
Thanks to inferenceus : some sort orders on the "explore/users" page
could list users by their lastlogintime/updatetime.

It leaks user's activity unintentionally. This PR makes that page only
use "supported" sort orders.

Removing the "sort orders" could also be a good solution, while IMO at
the moment keeping the "create time" and "name" orders is also fine, in
case some users would like to find a target user in the search result,
the "sort order" might help.

![image](https://github.com/go-gitea/gitea/assets/2114189/ce5c39c1-1e86-484a-80c3-33cac6419af8)

(cherry picked from commit eedb8f41297c343d6073a7bab46e4df6ee297a90)
 2024-03-06 12:10:43 +08:00
Lunny Xiao
894d9b2836
Move context from modules to services (#29440) 
Since `modules/context` has to depend on `models` and many other
packages, it should be moved from `modules/context` to
`services/context` according to design principles. There is no logic
code change on this PR, only move packages.

- Move `code.gitea.io/gitea/modules/context` to
`code.gitea.io/gitea/services/context`
- Move `code.gitea.io/gitea/modules/contexttest` to
`code.gitea.io/gitea/services/contexttest` because of depending on
context
- Move `code.gitea.io/gitea/modules/upload` to
`code.gitea.io/gitea/services/context/upload` because of depending on
context

(cherry picked from commit 29f149bd9f517225a3c9f1ca3fb0a7b5325af696)

Conflicts:
	routers/api/packages/alpine/alpine.go
	routers/api/v1/repo/issue_reaction.go
	routers/install/install.go
	routers/web/admin/config.go
	routers/web/passkey.go
	routers/web/repo/search.go
	routers/web/repo/setting/default_branch.go
	routers/web/user/home.go
	routers/web/user/profile.go
	tests/integration/editor_test.go
	tests/integration/integration_test.go
	tests/integration/mirror_push_test.go
	trivial context conflicts
	also modified all other occurrences in Forgejo specific files
 2024-03-06 12:10:43 +08:00
Earl Warren
21b1381e36 Merge pull request 'Move migration functions to services layer - port of gitea#29497' (#2546) from algernon/forgejo:gitea/port/29497 into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2546
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-04 10:01:26 +00:00
Gergely Nagy
f9894f4c51
A release title should always be a link 
This partially reverts c41b2c73ef: for the
sake of consistency, the title of a release should always be a link,
whether it's a tag-only release or not.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-03-04 08:29:11 +01:00
Gergely Nagy
19ff532d42
Test that tags without a release display properly 
Update the `TestTagViewWithoutRelease` test case with another assert:
one that checks that the release title is properly displayed.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-03-04 08:29:11 +01:00
Lunny Xiao
ff8cb299d1
Move migration functions to services layer (#29497) 2024-03-04 07:10:53 +01:00
Earl Warren
ad547edf3b
[TESTS] enable AddFixtures in unit tests 
Use setting.AppWorkPath instead of filepath.Dir(setting.AppPath). It
is the common denominator between:

* models/unittest/testdb.go:MainTest
* tests/test_utils.go:InitTest

which makes it usable in unit tests as well as integration tests.
 2024-03-03 11:11:26 +08:00
Gusted
c63b52c126
[FEAT] Show follow symlink button 
- When a user goes opens a symlink file in Forgejo, the file would be
rendered with the path of the symlink as content.
- Add a button that is shown when the user opens a *valid* symlink file,
which means that the symlink must have an valid path to an existent
file and after 999 follows isn't a symlink anymore.
- Return the relative path from the `FollowLink` functions, because Git
really doesn't want to tell where an file is located based on the blob ID.
- Adds integration tests.
 2024-03-02 17:58:09 +01:00
Gusted
abe3351187 Merge pull request '[BUG] Allow to select commit email for file updload/delete' (#2383) from 0ko/forgejo:fix-commit-del into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2383
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-03-02 12:00:45 +00:00
Gusted
2658d4361e
[BUG] Disable CODEOWNERS for forked repositories 
- Disable the CODEOWNERS feature for forked repositories, as it would
otherwise inadvertently request reviewers when for example a pull
request is opened against a forked repository to propose changes to an
existant pull request in the original repository.
- Adds integration test.
- Resolves #2525
 2024-03-01 23:19:18 +01:00
Gusted
86b46085c7
[BUG] Sort file list case insensitively 
- Make the sorting done on the entries list case insensitive.
- Adds integration test.
- Resolves #317
 2024-02-29 21:14:06 +01:00
Gusted
d0e5af7079 Merge pull request '[UI] Actions: Link to Workflow in View' (#1866) from n0toose/forgejo:forgejo-add-workflow-link into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/1866
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-02-28 17:28:16 +00:00
Earl Warren
7af1349c1d Merge pull request '[BUG] Correct changed files for codeowners' (#2507) from gusted/forgejo-codeowner-diff into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2507
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
 2024-02-28 12:15:49 +00:00
Gusted
64a0d61aff [BUG] Implement commit mail selection for other Git operations 
- Implement the commit mail selection feature for the other supported
Git operations that can be done trough the web UI.
- Adds integration tests (goodluck reviewing this).
- Ref: #1788

Co-authored-by: 0ko <0ko@noreply.codeberg.org>
 2024-02-27 22:41:58 +00:00
Gusted
fb2795b5bb
[BUG] Correct changed files for codeowners 
- The CODEOWNER feature relies on the changed files to determine which
reviewers should be added according to the `CODEOWNER` file.
- The current approach was to 'diff' between the base and head branch,
which seems logical but fail in practice when the pull request is out of
date with the base branch. Therefore it should instead diff between the
head branch and the merge base of the head and base branch, so only the
actual affected files by the pull requests are used, the same approach
is used by the diff of an unmerged pull request.
- Add integration testing (for the feature as well).
- Resolves #2458
 2024-02-27 23:16:00 +01:00
Earl Warren
2855727c85 Merge pull request 'Disabling Stars should disable the routes too' (#2471) from algernon/forgejo:stars/disable-routes into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2471
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-02-27 21:24:25 +00:00
Gergely Nagy
aef0b024b7 Fix the Fork button in repo headers 
In #2445, I lifted out the fork button into its own template, but did
not update it properly. This resulted in the fork button's counter not
displaying, and pointing to the wrong place too.

This patch updates the template to account for it moving to a separate
file, and also adds test cases to verify the button is display as it
should be.

Fixes #2494.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-27 18:36:37 +00:00
0ko
2e76e4fb33 [I18N] Improve English strings & consistency 2024-02-27 17:42:59 +00:00
Gergely Nagy
c9b410fb35
Highlight the correct small menu item when viewing a tag 
When viewing a tag that isn't associated with a release, highlight the
"N Tags" sub-menu item, rather than the "M releases" one.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-27 13:32:55 +01:00
Gergely Nagy
fc635f1014
Restore the ability to view tags without a release 
The `repo.SingleRelease` handler was broken by gitea#29149, as the
switch to `getReleaseInfos` stopped returning tags without an associated
release. This resulted in the web UI showing a 404 when trying to view a
tag without a release.

This restores the functionality by explicitly including tags in the
search, and also adds tests to exercise the fix.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-27 13:32:55 +01:00
Earl Warren
3fa4962a88 Merge pull request '[gitea] cherry-pick' (#2478) from earl-warren/forgejo:wip-gitea-cherry-pick into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2478
 2024-02-27 10:39:41 +00:00
Earl Warren
d9ae3717b5 Merge pull request '[BUG] Remember topic only in repo search' (#2489) from gusted/forgejo-topic-explore into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2489
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-02-26 22:40:34 +00:00
Zettat123
77c56e29de
Allow non-admin users to delete review requests (#29057) 
Fix #14459

The following users can add/remove review requests of a PR
- the poster of the PR
- the owner or collaborators of the repository
- members with read permission on the pull requests unit

(cherry picked from commit c42083a33950be6ee9f822c6d0de3c3a79d1f51b)

Conflicts:
	models/repo/repo_list_test.go
	tests/integration/api_nodeinfo_test.go
	tests/integration/api_repo_test.go
	shared fixture counts
 2024-02-26 22:30:27 +01:00
KN4CK3R
5f79550a0d
Prevent double use of git cat-file session. (#29298) 
Fixes the reason why #29101 is hard to replicate.
Related #29297

Create a repo with a file with minimum size 4097 bytes (I use 10000) and
execute the following code:
```go
gitRepo, err := gitrepo.OpenRepository(db.DefaultContext, <repo>)
assert.NoError(t, err)

commit, err := gitRepo.GetCommit(<sha>)
assert.NoError(t, err)

entry, err := commit.GetTreeEntryByPath(<file>)
assert.NoError(t, err)

b := entry.Blob()

// Create a reader
r, err := b.DataAsync()
assert.NoError(t, err)
defer r.Close()

// Create a second reader
r2, err := b.DataAsync()
assert.NoError(t, err) // Should be no error but is ErrNotExist
defer r2.Close()
```

The problem is the check in `CatFileBatch`:

79217ea63c/modules/git/repo_base_nogogit.go (L81-L87)
`Buffered() > 0` is used to check if there is a "operation" in progress
at the moment. This is a problem because we can't control the internal
buffer in the `bufio.Reader`. The code above demonstrates a sequence
which initiates an operation for which the code thinks there is no
active processing. The second call to `DataAsync()` therefore reuses the
existing instances instead of creating a new batch reader.

(cherry picked from commit f74c869221624092999097af38b6f7fae4701420)
 2024-02-26 22:30:25 +01:00
6543
f796548225
Workaround to clean up old reviews on creating a new one (#28554) 
close  #28542

blocks  #28544

---
*Sponsored by Kithara Software GmbH*

(cherry picked from commit 217d71c48a10265e08b95cc961656b921f61f9ff)

Conflicts:
	tests/integration/api_pull_review_test.go
	context
 2024-02-26 21:42:14 +01:00
Gergely Nagy
0b4a9c4ec2
Disabling Stars should disable the routes too 
Similarly to how `[repository].DISABLE_FORKS` works, lets make
`[repository].DISABLE_STARS` disable the routes too, not just hide the
functionality from the UI.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-26 20:50:32 +01:00
Gusted
b4360d504c
[BUG] Remember topic only in repo search 
- If the user is searching repositories with an specific topic, adding
any other filter option, such as showing unrelevant repositories or
using another sort Forgejo should remember that 'topic only' was set.
- Adds integration test.
- Resolves #2461
 2024-02-26 16:25:01 +01:00
Earl Warren
775956cc68 Merge pull request '[BUG] Don't overwrite protected branch accidentally' (#2473) from gusted/forgejo-error-duplicate into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2473
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-02-26 14:55:09 +00:00
Earl Warren
f91702dd74 Merge pull request 'Split up repo.Action in routers/web into smaller functions.' (#2476) from algernon/forgejo:refactor/routes/web/repo-action into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2476
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-02-26 14:54:35 +00:00
Gergely Nagy
ae0635fd61
Correctly support linguist-documentation=false 
If a documentation file is marked with a `linguist-documentation=false`
attribute, include it in language stats.

However, make sure that we do *not* include documentation languages as
fallback.

Added a new test case to exercise the formerly buggy behaviour.

Problem discovered while reviewing @KN4CK3R's tests from gitea#29267.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-26 14:18:33 +01:00
Gergely Nagy
7e6fe41389
Add tests for the star/unstar & watch/unwatch UI 
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-26 09:14:11 +01:00
qwerty287
feb189554e
Add API to get PR by base/head (#29242) 
Closes https://github.com/go-gitea/gitea/issues/16289

Add a new API `/repos/{owner}/{repo}/pulls/{base}/{head}` to get a PR by
its base and head branch.
 2024-02-26 03:41:42 +01:00
Gusted
1bab4358ac
[BUG] Don't overwrite protected branch accidentally 
- If a user tries to create another protected branching rule that
specifies a set of branches already used by another rule, do not allow
it.
- Update the translation accordingly.
- Adds integration test.
- Resolves #2455
 2024-02-25 20:09:18 +01:00
Earl Warren
f991f107da Merge pull request 'Improve display of 404/500 error pages' (#2466) from 0ko/forgejo:errorcodes into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2466
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-02-25 15:53:09 +00:00
Earl Warren
649ca2b230 Merge pull request 'Allow instance-wide disabling of forking' (#2445) from algernon/forgejo:f/disable-forks into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2445
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-02-25 15:13:15 +00:00
Earl Warren
bc2a105cbb Merge pull request '[FEAT] Check if commit is already present in target branch' (#2450) from gusted/forgejo-agit-contain-commit into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2450
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-02-25 15:05:33 +00:00
Earl Warren
ef1d579c41 Merge pull request '[UI] Agit: Add AGit label to AGit-created PRs' (#2444) from n0toose/agit-indicator into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2444
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-02-25 14:48:09 +00:00
0ko
a748ba70a8 10-year old images are gone 2024-02-25 18:13:59 +05:00
Gergely Nagy
0ea021c8c9
Allow instance-wide disabling of forking 
For small, personal self-hosted instances with no user signups, the fork
button is just a noise. This patch allows disabling them like stars can
be disabled too.

Disabling forks does not only remove the buttons from the web UI, it
also disables the routes that could be used to create forks.

Fixes #2441.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-25 12:00:17 +01:00
Earl Warren
3471adb14a Merge pull request '[FEAT] Enable ambiguous character detection in configured contexts' (#2427) from gusted/forgejo-ambigious-characters into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2427
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
 2024-02-24 12:25:31 +00:00
Earl Warren
bc8d61d12e Merge pull request '[FEAT] Restrict file size of blame operation' (#2395) from gusted/forgejo-blame-restrict into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2395
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-02-23 23:17:02 +00:00
Gusted
f0ed6de89d
[FEAT] Check if commit is already present in target branch 
- Check if someone is (accidentally) trying to create a pull request via
AGit with changes already in the target branch and fail if that is the
case.
- Added integration test.
 2024-02-23 21:42:15 +01:00
Panagiotis "Ivory" Vasilopoulos
bf7fb89178 [UI] Agit: Add AGit label to AGit-created PRs 
Adds a label to Pull Requests that were created using AGit-Flow,
in order to prevent situations where a contributor uses AGit-Flow
to push new changes - only to realize that they did not use AGit-Flow
in the first place, and that they just opened a new PR accidentally
(that was me).

Also intended to raise general awareness about the feature. Some
additional work, such as adding a tooltip, still needs to be
done.

A small typo fix for a comment and (exclusively) formatting fixes
in the copyright header are also included.

Refs: https://codeberg.org/forgejo/forgejo/issues/2433
 2024-02-23 21:09:08 +01:00
Gusted
5b3a82d621
[FEAT] Enable ambiguous character detection in configured contexts 
- The ambiguous character detection is an important security feature to
combat against sourcebase attacks (https://trojansource.codes/).
- However there are a few problems with the feature as it stands
today (i) it's apparantly an big performance hitter, it's twice as slow
as syntax highlighting (ii) it contains false positives, because it's
reporting valid problems but not valid within the context of a
programming language (ambiguous charachters in code comments being a
prime example) that can lead to security issues (iii) charachters from
certain languages always being marked as ambiguous. It's a lot of effort
to fix the aforementioned issues.
- Therefore, make it configurable in which context the ambiguous
character detection should be run, this avoids running detection in all
contexts such as file views, but still enable it in commits and pull
requests diffs where it matters the most. Ideally this also becomes an
per-repository setting, but the code architecture doesn't allow for a
clean implementation of that.
- Adds unit test.
- Adds integration tests to ensure that the contexts and instance-wide
is respected (and that ambigious charachter detection actually work in
different places).
- Ref: https://codeberg.org/forgejo/forgejo/pulls/2395#issuecomment-1575547
- Ref: https://codeberg.org/forgejo/forgejo/issues/564
 2024-02-23 13:12:17 +01:00
Gergely Nagy
98943fdb43
tests: Add a basic test for artifact deletion 
Adds a very bare-bones test for artifact deletion. It does not exercise
the functionality itself, just the presence of the functionality.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-23 09:24:43 +01:00
Earl Warren
c47e6ceb82 Merge pull request '[FEAT] repo search using git grep' (#1594) from snematoda/forgejo:forgejo into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/1594
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-02-22 22:21:44 +00:00
Panagiotis "Ivory" Vasilopoulos
62f3ff6074 [UI] Actions: I will always run make fmt before pushing 
I will always run make fmt before pushing
I will always run make fmt before pushing
I will always run make fmt before pushing
 2024-02-22 22:31:26 +01:00
Panagiotis "Ivory" Vasilopoulos
2a0a5c6ec0 [UI] Actions: Oops, forgot to lint the tests. 2024-02-22 22:26:11 +01:00
Panagiotis "Ivory" Vasilopoulos
785f336c12 [UI] Actions: Improve frontend testing 2024-02-22 22:12:44 +01:00
Gusted
ca798e4cc2
[SECURITY] Test XSS in dismissed review 
It's possible for reviews to not be assiocated with users, when they
were migrated from another forge instance. In the migration code,
there's no sanitization check for author names, so they could contain
HTML tags and thus needs to be properely escaped.
 2024-02-22 15:33:20 +01:00
Gusted
565e331238
[SECURITY] Test XSS in wiki last commit information 
On the wiki and revisions page, information is shown about the last
commit that modified that wiki page. This includes the time it was last
edited and by whom. Verify it is sanitized.
 2024-02-22 15:03:15 +01:00
Panagiotis "Ivory" Vasilopoulos
1668904513 [UI] Actions: Link to Workflow in View 2024-02-22 13:18:06 +01:00
Malte Jürgens
5c67c34ce8
Add e2e debug server 
This adds the ability to run `make test-e2e-debugserver` to start a
forgejo server pupulated with the test data from `models/fixtures`. This
is particularly useful for debugging the e2e tests with a external tool,
such as the Playwright extension for VSCode [1].

[1] https://open-vsx.org/extension/ms-playwright/playwright
 2024-02-21 20:47:57 +01:00
Shiny Nematoda
51fb6f3983 [FEAT] add fallback repo search using git grep 2024-02-20 13:00:34 +00:00
Gusted
cfd6420a0e Merge pull request '[REFACTOR] Refactor the AGit code' (#2386) from gusted/fix-agit into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2386
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-02-19 15:59:10 +00:00
Gusted
d8a267d3ab
[FEAT] Restrict file size of blame operation 
- Currently there exists a restriction to not render and show files that
are larger than what's configured in `[UI].MAX_DISPLAY_FILE_SIZE`.
- Apply the same restriction to the blame operation as well, as the
blame operation can be seen as displaying a file.
- Add integration test.
- Ref: #2394
 2024-02-19 16:39:39 +01:00
Earl Warren
6c9c0aca76 Merge pull request '[gitea] cherry-pick' (#2375) from earl-warren/forgejo:wip-gitea-cherry-pick into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2375
Reviewed-by: Otto <otto@codeberg.org>
 2024-02-19 14:42:41 +00:00
Gusted
c58ad87513
[REFACTOR] Refactor the AGit code 
TLDR: Less code, better maintainability and more comments.

- Add code comments to explain what the code does, it's quite a big
function so it definitely deserved some of that.
- Simplify some logic.
- Load the `pusher` in a single place.
- Update the error messages to be more correct, not capitlized, include
more debug info and remove 'Error:' As it's no need to indicate that,
errors are concenated with `:` seperators.
- Improve the message that a change was rejected, because a force push
was detected and the `force-push` option wasn't set.
- Avoid a second time loading `gitRepo.GetObjectFormat` and handle the
error gracefully for the other occurence.
- Adds integration test for force push detection.
 2024-02-19 13:18:50 +01:00
Earl Warren
5240e27266 Merge pull request 'GitHub-style alert blocks in Markdown (gitea#29121)' (#2348) from algernon/forgejo:f/markdown/alert-blocks-port into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2348
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
 2024-02-18 11:21:36 +00:00
Yarden Shoham
2685be9f95
Fix labels referencing the wrong ID in the user profile settings (#29199) 
2 instances of `for` with a wrong value and 1 `for` that had a reference
to a `name` instead of `id`.

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
(cherry picked from commit 1d275c1748a75a01c270f5c306c5248808016aba)
 2024-02-17 23:24:32 +01:00
Gergely Nagy
cc47808b84
tests: Markdown alert block test cases 
This adds a few test cases to exercise the alert block feature of the
markdown renderer, both the legacy GitHub style, and the modern one.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-17 18:35:45 +01:00
Gusted
f779aa79f2
[BUG] Fix pull request reopen conditions 
- Move the conditions code around, such that the existence of the head
and base is first checked (so a clear error can be given, instead of a
possible server error). This makes it easier to read this code. As the
logic is now grouped together.
- Adds integration testing that simulates the deletion of the base and
head branch and ensures the pull request cannot be opened. The 'normal'
testcase also 'informally' ensures that the previous incorrect condition
is not there, because the branch `base-branch` doesn't exist on the head
repository.
- Resolves #2321
 2024-02-17 15:38:16 +01:00
Gusted
7bf93e5d1a Merge pull request 'A new test to exercise linguist-language=' (#2368) from algernon/tests/linguist/view-guess into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2368
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
 2024-02-17 13:46:43 +00:00
Gusted
0c0b87ec1a Merge pull request 'Add rel="nofollow" to issue filter links' (#2367) from algernon/forgejo:b/issues/nofollow into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2367
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-02-17 10:56:47 +00:00
Gergely Nagy
ae95db12a1
A new test to exercise linguist-language= 
Rename `repo_lang_stats_test.go` to `linguist_test.go`, and add a new
tests that exercises parts of the web UI to ensure that language
overrides in `.gitattributes` work when viewing a file source, and in
the blame view too.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-17 11:24:16 +01:00
Gergely Nagy
5143ebb507
Add rel="nofollow" to issue filter links 
The issue filter links should not be crawled by search engines, because
they they only filter results, and contain nothing new, yet, they put a
considerable load on the server.

To stop - well behaving - search engines from following these links, add
a `rel="nofollow"` property to them. The same property is already
present on the archive download links, and plenty of other places.

Fixes #2361.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-17 10:42:47 +01:00
wxiaoguang
65248945c9
Refactor locale&string&template related code (#29165) 
Clarify when "string" should be used (and be escaped), and when
"template.HTML" should be used (no need to escape)

And help PRs like  #29059 , to render the error messages correctly.

(cherry picked from commit f3eb835886031df7a562abc123c3f6011c81eca8)

Conflicts:
	modules/web/middleware/binding.go
	routers/web/feed/convert.go
	tests/integration/branches_test.go
	tests/integration/repo_branch_test.go
	trivial context conflicts
 2024-02-16 15:20:52 +01:00
oliverpool
0fc61c8836 [BUG] split code conversations in diff tab (#2306) 
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
 2024-02-16 12:16:11 +00:00
Earl Warren
41cc9784f9 Merge pull request 'agit: Automatically fill in the description' (#2344) from algernon/f/agit/description-autofill into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2344
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
 2024-02-14 20:46:00 +00:00
Gergely Nagy
259ad5d614
agit: Automatically fill in the description 
If no `-o description=` is provided, fill it in automatically from the
first commit, just like title. Also allow filling in either, and
specifying them independently.

This means that `git push origin HEAD:refs/for/main/my-local-branch`
will fill in the PR title, *and* the description, without having to
specify additional parameters.

The description is the first commit's message without the first two
lines (the title and a newline, as customary).

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-14 21:17:55 +01:00
Chris Copeland
83123b493f
Add merge style fast-forward-only (#28954) 
With this option, it is possible to require a linear commit history with
the following benefits over the next best option `Rebase+fast-forward`:
The original commits continue existing, with the original signatures
continuing to stay valid instead of being rewritten, there is no merge
commit, and reverting commits becomes easier.

Closes #24906
 2024-02-14 17:19:19 +01:00
Earl Warren
05eaf1cf3e Merge pull request 'Repository settings refactor' (#2221) from algernon/forgejo:repo-units/ui-refactor into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2221
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
 2024-02-14 13:29:04 +00:00
Gergely Nagy
44424bfe60
Add tests for the previous two commits 
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-13 22:42:09 +01:00
Earl Warren
98e7753ade Merge pull request '[FEAT]: Allow forking without a repo ID' (#2310) from algernon/forgejo:f/repo/fork-route into forgejo 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2310
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
 2024-02-12 13:36:49 +00:00
Alexandre Oliveira
29007c09bd Fix Alpine Registry packages with noarch not being found (#2285) 
Fixes #2173
~~Still requires a bit of work to do, I'm not 100% happy with this solution.~~

The idea is to copy the noarch package to the architectures available in the package repository.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2285
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Alexandre Oliveira <me+codeberg@aoalmeida.com>
Co-committed-by: Alexandre Oliveira <me+codeberg@aoalmeida.com>
 2024-02-11 18:02:56 +00:00
Earl Warren
7b4dba3aa0 [ACTIONS] skip superflous pull request synchronized event (#2314) 
Skip a HookEventPullRequestSync event if it has the same CommitSHA as an existing HookEventPullRequest event in the ActionRun table. A HookEventPullRequestSync event must only create an ActionRun if the CommitSHA is different from what it was when the PR was open.

This guards against a race that can happen when the following is done in parallel:

* A commit C is pushed to a repo on branch B
* A pull request with head on branch B

it is then possible that the pull request is created first, successfully. The commit that was just pushed is not known yet but the PR only references the repository and the B branch so it is fine.

A HookEventPullRequest event is sent to the notification queue but not processed immediately.

The commit C is pushed and processed successfully. Since the PR already exists and has a head that matches the branch, the head of the PR is updated with the commit C and a HookEventPullRequestSync event is sent to the notification queue.

The HookEventPullRequest event is processed and since the head of the PR was updated to be commit C, an ActionRun with CommitSHA C is created.

The HookEventPullRequestSync event is then processed and also has a CommitSHA equal to C.

Refs: https://codeberg.org/forgejo/forgejo/issues/2009
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2314
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
 2024-02-11 13:06:54 +00:00
Gergely Nagy
5f2d8be38e
[FEAT]: New route to view lates run of specific workflows 
This adds a new route at `/actions/workflows/{workflow}/runs/latest`,
which will redirect to the latest run of the given workflow. It can be
further restricted by specifying an optional `?branch={branch}` query
parameter. If no branch is specified, the route defaults to using the
repo's default branch.

This route is meant to go hand in hand with the Badge route that returns
the result of the same workflow as a badge. This route can be used to
link to the run that produced that result.

Fixes #2303.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-10 09:15:58 +01:00
Gergely Nagy
f8da672307
[FEAT]: Allow forking without a repo ID 
Forking a repository via the web UI currently requires visiting a
`/repo/fork/{{repoid}}` URL. This makes it cumbersome to create a link
that starts a fork, because the repository ID is only available via the
API. While it *is* possible to create a link, doing so requires extra
steps.

To make it easier to have a "Fork me!"-style links, introduce the
`/{username}/{repo}/fork` route, which will start the forking process
based on the repository in context instead.

The old `/repo/fork/{repoid}` route (with a `GET` request) will remain
there for the sake of backwards compatibility, but will redirect to the
new URL instead. It's `POST` handler is removed.

Tests that used the old route are updated to use the new one, and new
tests are introduced to exercise the redirect.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-10 09:14:14 +01:00
Earl Warren
7cbf05fafb
Merge remote-tracking branch 'forgejo/forgejo-dependency' into wip-forgejo 
Conflicts:
	.forgejo/workflows/testing.yml
	trivial conflict
 2024-02-09 19:00:54 +01:00
Gergely Nagy
1624ebc836
[TESTS] issue & PR templates in .forgejo are recognized 
This adds a few tests for the previous change, to verify that issue
template configs, issue templates and pr templates are all recognized in
`.forgejo` directories.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-06 10:22:32 +01:00
Gergely Nagy
be8d16438a
Fix /api/v1/{owner}/{repo}/issue_templates 
When issue templates were moved into services in
def4956122, the code was also refactored
and simplified. Unfortunately, that simplification broke the
`/api/v1/{owner}/{repo}/issue_templates` route, because it was
previously using a helper function that ignored invalid templates, and
after the refactor, the function it called *always* returned non-nil as
the second return value. This, in turn, results in the aforementioned
end point always returning an internal server error.

This change restores the previous behaviour of ignoring invalid files
returned by `issue.GetTemplatesFromDefaultBranch`, and adds a few test
cases to exercise the endpoint.

Other users of `GetTemplatesFromDefaultBranch` already ignore the second
return value, or handle it correctly, so no changes are necessary there.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
 2024-02-05 20:58:41 +01:00
Earl Warren
094c84ed6d
Merge branch 'rebase-forgejo-dependency' into wip-forgejo 2024-02-05 18:58:23 +01:00
Earl Warren
d7e1854884
Merge branch 'rebase-forgejo-branding' into wip-forgejo 2024-02-05 18:58:18 +01:00
Earl Warren
036f1eddc5
[GITEA] avoid superfluous synchronized pull_request run when opening a PR (#2236) 
* Split TestPullRequest out of AddTestPullRequestTask
* Before scheduling the task, AddTestPullRequestTask stores the max
  index of the repository
* When the task runs, it does not take into account pull requests that
  have an index higher than the recorded max index

When AddTestPullRequestTask is called with isSync == true, it is the
direct consequence of a new commit being pushed. Forgejo knows nothing
of this new commit yet. If a PR is created later and its head
references the new commit, it will have an index that is higher and
must not be taken into account. It would be acting and triggering a
notification for a PR based on an event that happened before it
existed.

Refs: https://codeberg.org/forgejo/forgejo/issues/2009
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2236
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
(cherry picked from commit b3be895a30)
 2024-02-05 16:57:58 +01:00
Gergely Nagy
c335d076aa
[GITEA] admin: "Self Check" should only show for some db types 
The "Self Check" menu essentially runs the collation check that is also
performed at startup, and displays the results. This is only a thing for
MariaDB/MySQL and MSSQL. As such, the menu item should only be available
for these database types.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 0ca118fdc3)
 2024-02-05 16:57:56 +01:00
oliverpool
76c2f5bf92
[GITEA] add test showing bug on resolving invalidated review comment 
(cherry picked from commit 5fb3b927f1)
 2024-02-05 16:57:56 +01:00
Gergely Nagy
fde08f91fd
[GITEA] tests: A workaround for the MySQL collation tests 
Because Forgejo run mysqld with `--innodb-flush-method=nosync` to speed
up the test suite, there are situations where a larger, database-wide
operation does not always fully manifest until later, not even when it
is wrapped in a transaction, nor when we use `FLUSH TABLES` and similar
methods.

In the case of the MySQL collation test, this *sometimes* results in the
database still responding with the old collation to a reader, even after
an `ALTER DATABASE ... COLLATE ...`.

In order to be able to still use the aforementioned flag and enjoy its
benefits, add a five second sleep between `db.ConvertDatabaseTable()`
and `db.CheckCollations()` in the `TestDatabaseCollation()` set of
tests.

This is not a fix - I don't think there is one possible -, but a
workaround. If it breaks again, the correct fix will be to remove the
flag from `mysqld` (it's not a supported flag to begin with).

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit af18ed2ba9)
 2024-02-05 16:57:55 +01:00
Gergely Nagy
2ca4862f8b
[GITEA] Allow changing the repo Wiki branch to main 
Previously, the repo wiki was hardcoded to use `master` as its branch,
this change makes it possible to use `main` (or something else, governed
by `[repository].DEFAULT_BRANCH`, a setting that already exists and
defaults to `main`).

The way it is done is that a new column is added to the `repository`
table: `wiki_branch`. The migration will make existing repositories
default to `master`, for compatibility's sake, even if they don't have a
Wiki (because it's easier to do that). Newly created repositories will
default to `[repository].DEFAULT_BRANCH` instead.

The Wiki service was updated to use the branch name stored in the
database, and fall back to the default if it is empty.

Old repositories with Wikis using the older `master` branch will have
the option to do a one-time transition to `main`, available via the
repository settings in the "Danger Zone". This option will only be
available for repositories that have the internal wiki enabled, it is
not empty, and the wiki branch is not `[repository].DEFAULT_BRANCH`.

When migrating a repository with a Wiki, Forgejo will use the same
branch name for the wiki as the source repository did. If that's not the
same as the default, the option to normalize it will be available after
the migration's done.

Additionally, the `/api/v1/{owner}/{repo}` endpoint was updated: it will
now include the wiki branch name in `GET` requests, and allow changing
the wiki branch via `PATCH`.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit d87c526d2a)
 2024-02-05 16:57:47 +01:00
Gusted
361617eea0
[GITEA] Use correct translations for pull request 
- When a commit references a pull request, the detail strings should
reflect that. Add a new translation string for the pull request.
- Added integration tests.
- Resolves #2256

(cherry picked from commit 0d054cd4d9)
 2024-02-05 16:54:44 +01:00
Gergely Nagy
fdda432d1e
[TESTS] Convert more tests to CreateDeclarativeRepo 
These tests originate from Gitea, so may cause conflicts in the longer
run. But they use the same pattern, so transitioning them to the helper
is hopefully a benefit that offsets the risk.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 2d475af494)
(cherry picked from commit a99c17729c)
 2024-02-05 16:54:44 +01:00
Gergely Nagy
48d752c630
[TESTS] Lift out CreateDeclarativeRepo() 
There are a number of tests which require creating a repository on the
fly, and they each do it their own way. To reduce code duplication, lift
out this common pattern into a helper called `CreateDeclarativeRepo()`,
which lets us create a repository, set up enabled and disabled repo
units, and even add, delete, or update files.

Also convert a number of users of this pattern to the new helper - those
users that I introduced, and are in code introduced by Forgejo in the
first place.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 342b7bae3c)
(cherry picked from commit 2ece8764e9)
 2024-02-05 16:54:44 +01:00
Earl Warren
fe8622dae3
Revert "Fix schedule tasks bugs (#28691)" 
This reverts commit 97292da960.

(cherry picked from commit 83e5eba031)
(cherry picked from commit f6ef8f3819)

Conflicts:
	services/repository/setting.go
 2024-02-05 16:54:42 +01:00
Gergely Nagy
d4396acf82
[GITEA] Don't consider orphan branches as recently pushed 
When displaying the recently pushed branches banner, don't display
branches that have no common history with the default branch. These
branches are usually not meant to be merged, so the banner is just noise
in this case.

Refs: https://codeberg.org/forgejo/forgejo/pulls/2196

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit e1fba517f4)
(cherry picked from commit 2d3c81d4f2)
(cherry picked from commit 624a61b3b8)
 2024-02-05 16:09:43 +01:00
Gergely Nagy
69688628f5
[GITEA] Fix misleading comparisons when comparing branches 
When comparing branches, only offer those branches to use as a base
where the repository allows pull requests. Those that do not allow pull
request would result in a 404, so offering them as an option would be
misleading.

Refs: https://codeberg.org/forgejo/forgejo/pulls/2194

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 022d0e0d71)
(cherry picked from commit 957990b36a)
(cherry picked from commit 6d2df72825)
 2024-02-05 16:09:43 +01:00
Gergely Nagy
bc7e448d49
[GITEA] Rework when recently pushed branches are displayed 
With this change, the "You pushed on branch xyz" banner will be
displayed when either the viewed repository or its base repo (if the
current one's a fork) has pull requests enabled. Previously it only
displayed if the viewed repo had PRs enabled.

Furthermore, if the viewed repository is an original repository that the
viewing user has a fork of, if the forked repository has recently pushed
branches, then the banner will appear for the original repository too.
In this case, the notification will include branches from the viewing
user's fork, and branches they pushed to the base repo, too.

Refs: https://codeberg.org/forgejo/forgejo/pulls/2195

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit a29f10661d)
(cherry picked from commit 70c5e2021d)
(cherry picked from commit 48b25be67a)
 2024-02-05 16:09:43 +01:00
Gusted
bbe5a881cc
[GITEA] Fix API inconsistencies 
- Document the correct content types for Git archives. Add code that
actually sets the correct application type for `.zip` and `.tar.gz`.
- When an action (POST/PUT/DELETE method) was successful, an 204 status
code should be returned instead of status code 200.
- Add and adjust integration testing.
- Resolves #2180
- Resolves #2181

(cherry picked from commit 6c8c4512b5)
(cherry picked from commit 3f74bcb14d)
(cherry picked from commit 6ed9057fd7)
 2024-02-05 16:09:43 +01:00
Earl Warren
0b503e5e86
[GITEA] DELETE /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments/{comment} 
* reuse deleteIssueComment by adding the commentType parameter
* ensure tests start with a PR with no random reviews from fixtures

Refs: https://codeberg.org/forgejo/forgejo/issues/2109
(cherry picked from commit 5b90ab77f6)
(cherry picked from commit 28ecd6f5a6)
(cherry picked from commit 24870cf133)
 2024-02-05 16:09:43 +01:00
Gergely Nagy
8eaa8aeaf9
[GITEA] Improved Linguist compatibility 
Recognise the `linguist-documentation` and `linguist-detectable`
attributes in `.gitattributes` files, and use them in
`GetLanguageStats()` to make a decision whether to include a particular
file in the stats or not.

This allows one more control over which files in their repositories
contribute toward the language statistics, so that for a project that is
mostly documentation, the language stats can reflect that.

Fixes #1672.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 6d4e02fe5f)
(cherry picked from commit ee1ead8189)
(cherry picked from commit 2dbec730e8)
 2024-02-05 16:09:43 +01:00
Earl Warren
bd1cea3f82
[GITEA] GET /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments/{comment} 
Refs: https://codeberg.org/forgejo/forgejo/issues/2109
(cherry picked from commit 69fcf26dee)
(cherry picked from commit 1296f4d115)
(cherry picked from commit 119d10d9e2)
(cherry picked from commit eb5b55b1b7)
 2024-02-05 16:09:43 +01:00
Gergely Nagy
3bdfb7a7aa
[GITEA] Fix the topic search paging 
When searching for repository topics, either via the API, or via
Explore, paging did not work correctly, because it only applied when the
`page` parameter was non-zero. Paging should have applied when the page
size is greater than zero, which is what this patch does.

As a result, both the API, and the Explore endpoint will return paged
results (30 by default). As such, when managing topics on the frontend,
the offered completions will also be limited to a pageful of results,
based on what the user has already typed.

This drastically reduces the amount of traffic, and also the number of
the topics to choose from, and thus, the rendering time too.

The topics will be returned by popularity, with most used topics first.
A single page will contain `[api].DEFAULT_PAGING_NUM` (30 by default)
items that match the query. That's plenty to choose from.

Fixes #132.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 64d4ff41db)
(cherry picked from commit 06b808fa2c)
(cherry picked from commit 9205c9266a)
(cherry picked from commit 47863d4f72)
 2024-02-05 16:09:43 +01:00
Gergely Nagy
2924fcf814
[GITEA] services: Gracefully handle missing branches 
services: in loadOneBranch, return if CountDivergingCommits fail

If we can't count the number of diverging commits for one reason or
another (such as the branch being in the database, but missing from
disk), rather than logging an error and continuing into a crash (because
`divergence` will be nil), return an error instead.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 8266105f24)

services: Gracefully handle missing branches

When loading branches, if loading one fails, log an error, and ignore
the branch, rather than returning and causing an internal server error.

Ideally, we would only ignore the error if it was caused by a missing
branch, and do it silently, like the respective API endpoint does.
However, veryfing that at this place is not very practical, so for the
time being, ignore any and all branch loading errors.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit e552a8fd62)

tests: Add a testcase for missing branches

This tests the scenario reported in Codeberg/Community#1408: a branch
that is recorded in the database, but missing on disk was causing
internal server errors. With recent changes, that is no longer the case,
the error is logged and then ignored.

This test case tests this behaviour, that the repo's branches page on
the web UI functions even if the git branch is missing.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit e20eb7b385)

tests: More testing in TestDatabaseMissingABranch

In the `TestDatabaseMissingABranch` testcase, make sure that the
branches are in sync between the db and git before deleting a branch via
git, then compare the branch count from the web UI, making sure that it
returns an out-of-sync value first, and the correct one after another
sync.

This is currently tested by scraping the UI, and relies on the fact that
the branch counter is out of date before syncing. If that issue gets
resolved, we'll have to adjust the test to verify the sync another way.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 8c2ccfcece)
(cherry picked from commit 439fadf563)
(cherry picked from commit 44dd80552c)
(cherry picked from commit 37b91fe6f2)
 2024-02-05 16:09:42 +01:00
Gusted
2cfcd266b4
[GITEA] Fix panic in canSoftDeleteContentHistory 
- It's possible that `canSoftDeleteContentHistory` is called without
`ctx.Doer` being set, such as an anonymous user requesting the
`/content-history/detail` endpoint.
- Add a simple condition to always set to `canSoftDelete` to false if an
anonymous user is requesting this, this avoids a panic in the code that
assumes `ctx.Doer` is set.
- Added integration testing.

(cherry picked from commit 0b5db0dcc6)
(cherry picked from commit 30d168bcc8)
(cherry picked from commit 19be82b7ef)
(cherry picked from commit 334b703b17)
 2024-02-05 16:09:42 +01:00
Earl Warren
603a44edf0
[GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments 
Refs: https://codeberg.org/forgejo/forgejo/issues/2109
(cherry picked from commit 8b4ba3dce7)
(cherry picked from commit 196edea0f9)

[GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments (squash) do not implicitly create a review

If a comment already exists in a review, the comment is added. If it
is the first comment added to a review, it will implicitly create a
new review instead of adding to the existing one.

The pull_service.CreateCodeComment function is responsibe for this
behavior and it will defer to createCodeComment once the review is
determined, either because it was found or because it was created.

Rename createCodeComment into CreateCodeCommentKnownReviewID to expose
it and change the API endpoint to use it instead. Since the review is
provided by the user and verified to exist already, there is no need
for the logic implemented by CreateCodeComment.

The tests are modified to remove the initial comment from the fixture
because it was creating the false positive. I was verified to fail
without this fix.

(cherry picked from commit 6a555996dc)
(cherry picked from commit b173a0ccee)
(cherry picked from commit 838ab9740a)
 2024-02-05 16:09:42 +01:00
Gergely Nagy
639b428cf4
[FEAT] API support for repository flags 
Expose the repository flags feature over the API, so the flags can be
managed by a site administrator without using the web API.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit bac9f0225d)
(cherry picked from commit e7f5c1ba14)
(cherry picked from commit 95d9fe19cf)
(cherry picked from commit 7fc51991e4)
 2024-02-05 16:09:42 +01:00
Gergely Nagy
36f7c162e2
[FEAT] Repository flags 
This implements "repository flags", a way for instance administrators to
assign custom flags to repositories. The idea is that custom templates
can look at these flags, and display banners based on them, Forgejo does
not provide anything built on top of it, just the foundation. The
feature is optional, and disabled by default. To enable it, set
`[repository].ENABLE_FLAGS = true`.

On the UI side, instance administrators will see a new "Manage flags"
tab on repositories, and a list of enabled tags (if any) on the
repository home page. The "Manage flags" page allows them to remove
existing flags, or add any new ones that are listed in
`[repository].SETTABLE_FLAGS`.

The model does not enforce that only the `SETTABLE_FLAGS` are present.
If the setting is changed, old flags may remain present in the database,
and anything that uses them, will still work. The repository flag
management page will allow an instance administrator to remove them, but
not set them, once removed.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit ba735ce222)
(cherry picked from commit f09f6e029b)
(cherry picked from commit 2f8b041489)
(cherry picked from commit d3186ee5f4)
 2024-02-05 16:09:42 +01:00
Gergely Nagy
9809f96a4a
[GITEA] Disable the RSS feed in file view for non-branches 
Files can have an RSS feed, but those only make sense when taken in the
context of a branch. There is no history to make a feed of on a tag or a
commit: they're static. Forgejo does not provide a feed for them for
this reason.

However, the file view on the web UI was offering a link to these
non-existent feeds. With this patch, it does that no longer, and only
provides a link when viewing the file in the context of a branch.

Fixes #2102.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 4b48d21ea7)
(cherry picked from commit 70cb266760)
(cherry picked from commit 69b45c3fea)

Conflicts:
	options/locale/locale_en-US.ini
	https://codeberg.org/forgejo/forgejo/pulls/2249
(cherry picked from commit 639a2c0741)
 2024-02-05 16:09:42 +01:00
Gergely Nagy
e019eb33a2
[GITEA] Find README.md for user profiles case insensitively 
When trying to find a `README.md` in a `.profile` repo, do so case
insensitively. This change does not make it possible to render readmes
in formats other than Markdown, it just removes the hard-coded
"README.md".

Also adds a few tests to make sure the change works.

Fixes #1494.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit edd219d8e9)
(cherry picked from commit 2c0105ef17)
(cherry picked from commit 3975a9f3aa)
(cherry picked from commit dee4a18423)
(cherry picked from commit 60aee6370f)
 2024-02-05 16:09:42 +01:00
Gusted
159dc74ceb
[GITEA] Check for Commit in opengraph 
- It's possible that `PageIsDiff` is set but not `Commit` resulting in a
NPE in the template. This can happen when the requested commit doesn't exist.
- Regression of c802c46a9b &
5743d7cb5b
- Added 'hacky' integration test.

(cherry picked from commit 8db2d5e4a7)
(cherry picked from commit 8c737a802b)
(cherry picked from commit 6b7c7d18dc)
(cherry picked from commit a2be4fab27)
(cherry picked from commit a1125268ac)
 2024-02-05 16:09:42 +01:00
Gergely Nagy
f90b802634
[GITEA] Add support for shields.io-based badges 
Adds a new `/{username}/{repo}/badges` family of routes, which redirect
to various shields.io badges. The goal is to not reimplement badge
generation, and delegate it to shields.io (or a similar service), which
are already used by many. This way, we get all the goodies that come
with it: different styles, colors, logos, you name it.

So these routes are just thin wrappers around shields.io that make it
easier to display the information we want. The URL is configurable via
`app.ini`, and is templatable, allowing to use alternative badge
generator services with slightly different URL patterns.

Additionally, for compatibility with GitHub, there's an
`/{username}/{repo}/actions/workflows/{workflow_file}/badge.svg` route
that works much the same way as on GitHub. Change the hostname in the
URL, and done.

Fixes gitea#5633, gitea#23688, and also fixes #126.

Work sponsored by Codeberg e.V.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit fcd0f61212)
(cherry picked from commit 20d14f7844)
(cherry picked from commit 4359741431)
(cherry picked from commit 35cff45eb8)
(cherry picked from commit 2fc0d0b8a3)
 2024-02-05 16:09:42 +01:00
Gergely Nagy
92f41d11dd
[GITEA] repo: Don't redirect the repo to external units 
When displaying the repo home view, do not redirect to unit types that
can't be defaults (which, at the moment, are the external wiki and issue
tracker unit types).

If we'd redirect to those, that would mean that a repository with the
Code unit disabled, and an external issue tracker would immediately
redirect to the external issue tracker, making it harder to reach other,
non-external units of the repo.

Fixes #1965.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 44078e5460)
(cherry picked from commit 1868dec2e4)
(cherry picked from commit c3a8e98870)
(cherry picked from commit 9266b1916f)
(cherry picked from commit 8fa5ff65af)
 2024-02-05 16:09:42 +01:00
Gusted
abfc169fc8
[GITEA] Remove redundant syncBranchToDB 
- The transaction in combination with Git push was causing deadlocks if
you had the `push_update` queue set to `immediate`. This was the root
cause of slow integration tests in CI.
- Remove the sync branch code as this is already being done in the Git
post-receive hook.
- Add tests to proof the branch models are in sync even with this code
removed.

(cherry picked from commit 90110e1f44)
(cherry picked from commit a064065cb9)
(cherry picked from commit 7713e558eb)

Conflicts:
	services/repository/branch.go
	https://codeberg.org/forgejo/forgejo/pulls/2068
(cherry picked from commit 3bb73e0813)
(cherry picked from commit c557540926)
(cherry picked from commit 986be6171a)
(cherry picked from commit 7a343877f1)
(cherry picked from commit 51425500f2)
 2024-02-05 16:09:42 +01:00
Gergely Nagy
1d8bca07f3
[GITEA] Configurable clone methods 
Adds `[repository].DOWNLOAD_OR_CLONE_METHODS` (defaulting to
"download-zip,download-targz,download-bundle,vscode-clone"), which lets
an instance administrator override the additional clone methods
displayed on the repository home view.

This is purely display-only, the clone methods not listed here are still
available, unless disabled elsewhere. They're just not displayed.

Fixes #710.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 2aadcf4946)
(cherry picked from commit 42ac34fbf9)
(cherry picked from commit bd231b0245)
(cherry picked from commit 3d3366dbbe)
(cherry picked from commit 0157fb9b88)
(cherry picked from commit bee88f6a83)
 2024-02-05 16:09:42 +01:00