1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-24 13:09:23 -05:00
forgejo/routers
oliverpool 07bc099401 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 14:06:43 +01:00
..
api Fix swift packages not resolving (#29095) (#29102) 2024-02-13 14:29:41 +01:00
common Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
install [GITEA] rework long-term authentication 2024-01-16 14:14:46 +00:00
private [CLI] implement forgejo-cli 2023-11-13 11:52:15 +01:00
utils Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
web [BUG] split code conversations in diff tab (#2306) 2024-02-16 14:06:43 +01:00
init.go [API] Forgejo API /api/forgejo/v1 2023-11-13 12:33:48 +01:00