1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-24 13:09:23 -05:00
forgejo/routers/web
oliverpool 07bc099401 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 14:06:43 +01:00
..
admin Forbid removing the last admin user (#28337) (#28793) 2024-01-16 14:41:11 +00:00
auth [GITEA] rework long-term authentication 2024-01-16 14:14:46 +00:00
devtest Make "cancel" buttons have proper type in modal forms (#25618) 2023-07-03 14:04:50 +08:00
events Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
explore Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
feed Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
healthcheck [BRANDING] cosmetic s/Gitea/Forgejo/ in logs, messages, etc. 2023-11-13 13:58:17 +01:00
misc Refactor CORS handler (#28587) (#28611) 2024-01-16 14:08:38 +00:00
org Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
repo [BUG] split code conversations in diff tab (#2306) 2024-02-16 14:06:43 +01:00
shared Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
user [GITEA] Fix NPE in UsernameSubRoute 2024-01-18 15:31:04 +01:00
base.go Fix panic in storageHandler (#27446) (#27479) 2023-10-06 16:51:26 +02:00
githttp.go Refactor CORS handler (#28587) (#28611) 2024-01-16 14:08:38 +00:00
goget.go Support SSH for go get (#24664) 2023-05-12 09:44:37 +00:00
home.go [GITEA] rework long-term authentication 2024-01-16 14:14:46 +00:00
metrics.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
nodeinfo.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
swagger_json.go Start using template context function (#26254) 2023-08-08 01:22:47 +00:00
web.go [GITEA] rework long-term authentication 2024-01-16 14:14:46 +00:00
webfinger.go Add a link to OpenID Issuer URL in WebFinger response (#26000) 2023-07-20 16:02:45 +08:00